From 8b070c7535e357a6c96746c2e83ff65943645cd5 Mon Sep 17 00:00:00 2001 From: Ori Harel Date: Wed, 13 Sep 2017 14:56:20 +0300 Subject: [PATCH 1/3] re #15915 HeadlessJsTaskService is expected to run on UI thread --- .../facebook/react/HeadlessJsTaskService.java | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/HeadlessJsTaskService.java b/ReactAndroid/src/main/java/com/facebook/react/HeadlessJsTaskService.java index 4d88f009c29ea9..3c7feae5b3cd28 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/HeadlessJsTaskService.java +++ b/ReactAndroid/src/main/java/com/facebook/react/HeadlessJsTaskService.java @@ -116,11 +116,19 @@ public void onReactContextInitialized(ReactContext reactContext) { } } - private void invokeStartTask(ReactContext reactContext, HeadlessJsTaskConfig taskConfig) { - HeadlessJsTaskContext headlessJsTaskContext = HeadlessJsTaskContext.getInstance(reactContext); + private void invokeStartTask(ReactContext reactContext, final HeadlessJsTaskConfig taskConfig) { + final HeadlessJsTaskContext headlessJsTaskContext = HeadlessJsTaskContext.getInstance(reactContext); headlessJsTaskContext.addTaskEventListener(this); - int taskId = headlessJsTaskContext.startTask(taskConfig); - mActiveTasks.add(taskId); + + Runnable myRunnable = new Runnable() { + @Override + public void run() { + int taskId = headlessJsTaskContext.startTask(taskConfig); + mActiveTasks.add(taskId); + } + }; + + UiThreadUtil.runOnUiThread(myRunnable); } @Override From 46d7197599e60461b037526aeca8a9668c7c4a13 Mon Sep 17 00:00:00 2001 From: Ori Harel Date: Wed, 13 Sep 2017 14:56:39 +0300 Subject: [PATCH 2/3] git ignore --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 15a2a9668a1a9f..16716c4aa966b2 100644 --- a/.gitignore +++ b/.gitignore @@ -58,3 +58,7 @@ node_modules /coverage /third-party +gradle-wrapper.jar +gradle-wrapper.properties +gradlew +gradlew.bat From 28b4cc46755caf1dc7545e8edf85a95ec3761f4a Mon Sep 17 00:00:00 2001 From: Ori Harel Date: Wed, 13 Sep 2017 14:58:31 +0300 Subject: [PATCH 3/3] Revert "git ignore" This reverts commit 46d7197599e60461b037526aeca8a9668c7c4a13. --- .gitignore | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.gitignore b/.gitignore index 16716c4aa966b2..15a2a9668a1a9f 100644 --- a/.gitignore +++ b/.gitignore @@ -58,7 +58,3 @@ node_modules /coverage /third-party -gradle-wrapper.jar -gradle-wrapper.properties -gradlew -gradlew.bat