From 15c3a33c91b568e43b4ebbace8d06a4b6a496e78 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 17:59:21 +1100 Subject: [PATCH 01/14] config cocaopods tests --- .circleci/config.yml | 12 ++++++++++++ scripts/objc-test-ios-cocoapods-install.sh | 20 ++++++++++++++++++++ scripts/objc-test-ios-cocoapods.sh | 21 +++++++++++++++++++++ scripts/objc-test.sh | 10 ++++++++-- 4 files changed, 61 insertions(+), 2 deletions(-) create mode 100755 scripts/objc-test-ios-cocoapods-install.sh create mode 100755 scripts/objc-test-ios-cocoapods.sh diff --git a/.circleci/config.yml b/.circleci/config.yml index cc86a51c4688e8..74d393df76322c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -229,6 +229,18 @@ aliases: name: Objective-C tvOS End-to-End Test Suite command: node ./scripts/run-ci-e2e-tests.js --tvos --js --retries 3; + - &build-objc-ios-cocaopods-install + name: Test Cocoapods + command: ./scripts/objc-test-ios-cocoapods-install.sh + + - &build-objc-ios-cocaopods-test-app + name: Build Objective-C iOS Test App + command: ./scripts/objc-test-ios-cocoapods.sh + + - &run-objc-ios-cocaopods-tests + name: Objective-C iOS Test Suite + command: ./scripts/objc-test-ios-cocoapods.sh test + defaults: &defaults working_directory: ~/react-native diff --git a/scripts/objc-test-ios-cocoapods-install.sh b/scripts/objc-test-ios-cocoapods-install.sh new file mode 100755 index 00000000000000..4866e0babc0ebd --- /dev/null +++ b/scripts/objc-test-ios-cocoapods-install.sh @@ -0,0 +1,20 @@ +#!/bin/bash +set -ex + +# Script used to run iOS tests. +# If not arguments are passed to the script, it will only compile +# the RNTester. +# If the script is called with a single argument "test", we'll +# also run the RNTester integration test (needs JS and packager): +# ./objc-test-ios.sh test + +SCRIPTS=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) +ROOT=$(dirname "$SCRIPTS") + +cd "$ROOT" + +SCHEME="RNTester" +SDK="iphonesimulator" +DESTINATION="platform=iOS Simulator,name=iPhone 5s,OS=10.3.1" + +pod install diff --git a/scripts/objc-test-ios-cocoapods.sh b/scripts/objc-test-ios-cocoapods.sh new file mode 100755 index 00000000000000..fdef0d8eef34f5 --- /dev/null +++ b/scripts/objc-test-ios-cocoapods.sh @@ -0,0 +1,21 @@ +#!/bin/bash +set -ex + +# Script used to run iOS tests. +# If not arguments are passed to the script, it will only compile +# the RNTester. +# If the script is called with a single argument "test", we'll +# also run the RNTester integration test (needs JS and packager): +# ./objc-test-ios.sh test + +SCRIPTS=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) +ROOT=$(dirname "$SCRIPTS") + +cd "$ROOT" + +SCHEME="RNTester" +SDK="iphonesimulator" +DESTINATION="platform=iOS Simulator,name=iPhone 5s,OS=10.3.1" + +# If there's a "test" argument, pass it to the test script. +. ./scripts/objc-test.sh $1 workspace diff --git a/scripts/objc-test.sh b/scripts/objc-test.sh index 81614c5f6edffc..dca362e88be0da 100755 --- a/scripts/objc-test.sh +++ b/scripts/objc-test.sh @@ -12,6 +12,12 @@ set -ex SCRIPTS=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) ROOT=$(dirname $SCRIPTS) +XCODE_PROJECT_PATH="RNTester/RNTester.xcodeproj" + +if [ "$2" = "workspace" ]; then + XCODE_PROJECT_PATH="RNTester/RNTester.xcodeproj" +fi + cd $ROOT # Create cleanup handler @@ -77,7 +83,7 @@ rm temp.bundle # the tests before running them. Switch back when this issue with xctool has # been resolved. xcodebuild \ - -project "RNTester/RNTester.xcodeproj" \ + -project $XCODE_PROJECT_PATH \ -scheme $SCHEME \ -sdk $SDK \ -destination "$DESTINATION" \ @@ -91,7 +97,7 @@ else # the tests before running them. Switch back when this issue with xctool has # been resolved. xcodebuild \ - -project "RNTester/RNTester.xcodeproj" \ + -project $XCODE_PROJECT_PATH \ -scheme $SCHEME \ -sdk $SDK \ build From 366a4733c6fe8957bb42ebfaea49945be4f1b14f Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 17:59:38 +1100 Subject: [PATCH 02/14] suggested pod file --- RNTester/Podfile | 50 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 RNTester/Podfile diff --git a/RNTester/Podfile b/RNTester/Podfile new file mode 100644 index 00000000000000..2554602057c12c --- /dev/null +++ b/RNTester/Podfile @@ -0,0 +1,50 @@ +source 'https://github.com/CocoaPods/Specs.git' + +use_frameworks! +inhibit_all_warnings! + +platform :ios, '9.0' + +project 'RNTester.xcodeproj' + +def shared_pods + pod 'yoga', :path => '../ReactCommon/yoga' + + # Third party deps podspec link + pod 'DoubleConversion', :podspec => '../third-party-podspecs/DoubleConversion.podspec' + pod 'Folly', :podspec => '../third-party-podspecs/Folly.podspec' + pod 'glog', :podspec => '../third-party-podspecs/glog.podspec' + + pod 'React', :path => '../', :subspecs => [ + 'Core', + 'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43 + 'RCTText', + 'RCTNetwork', + 'RCTWebSocket', # needed for debugging + 'RCTImage', + 'RCTLinkingIOS', + 'RCTActionSheet', + 'RCTAnimation', + 'CxxBridge' + ] +end + +target 'RNTester' do + shared_pods +end + +target 'RNTesterUnitTests' do + shared_pods +end + +target 'RNTester-tvOS' do + shared_pods +end + +target 'RNTester-tvOSUnitTests' do + shared_pods +end + +target 'RNTester-tvOSIntegrationTests' do + shared_pods +end From ab5cc3fcbb4ebe1340ede3b630acff7e84e1db27 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 17:59:46 +1100 Subject: [PATCH 03/14] correct yoga spec --- ReactCommon/yoga/yoga.podspec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ReactCommon/yoga/yoga.podspec b/ReactCommon/yoga/yoga.podspec index c38f4c09796cb6..8888ae7d1addb5 100644 --- a/ReactCommon/yoga/yoga.podspec +++ b/ReactCommon/yoga/yoga.podspec @@ -41,4 +41,7 @@ Pod::Spec.new do |spec| source_files = 'yoga/**/*.{cpp,h}' source_files = File.join('ReactCommon/yoga', source_files) if ENV['INSTALL_YOGA_WITHOUT_PATH_OPTION'] spec.source_files = source_files + + # Only expose the needed headers + spec.public_header_files = 'yoga/Yoga.h', 'yoga/YGEnums.h', 'yoga/YGMacros.h' end From 7f408323788742dce8aa490fef9392d243a1095b Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:00:02 +1100 Subject: [PATCH 04/14] animatednode --- Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h b/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h index ae2176684007d6..f3931e80cf8048 100644 --- a/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h +++ b/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h @@ -7,7 +7,7 @@ #import -#import +#import "RCTValueAnimatedNode.h" #import #import From 24bcf82cfade6128371f1cc81ec0ab7f9a66367d Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:00:28 +1100 Subject: [PATCH 05/14] make public RCTValueAnimatedNode --- .../RCTAnimation.xcodeproj/project.pbxproj | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/NativeAnimation/RCTAnimation.xcodeproj/project.pbxproj b/Libraries/NativeAnimation/RCTAnimation.xcodeproj/project.pbxproj index 0ba2446271568a..1a7a346a06ddcd 100644 --- a/Libraries/NativeAnimation/RCTAnimation.xcodeproj/project.pbxproj +++ b/Libraries/NativeAnimation/RCTAnimation.xcodeproj/project.pbxproj @@ -34,7 +34,7 @@ 192F698F1E823F4A008692C7 /* RCTPropsAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E01D07A6C9005F35D8 /* RCTPropsAnimatedNode.h */; }; 192F69901E823F4A008692C7 /* RCTStyleAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E21D07A6C9005F35D8 /* RCTStyleAnimatedNode.h */; }; 192F69911E823F4A008692C7 /* RCTTransformAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E41D07A6C9005F35D8 /* RCTTransformAnimatedNode.h */; }; - 192F69921E823F4A008692C7 /* RCTValueAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E61D07A6C9005F35D8 /* RCTValueAnimatedNode.h */; }; + 192F69921E823F4A008692C7 /* RCTValueAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E61D07A6C9005F35D8 /* RCTValueAnimatedNode.h */; settings = {ATTRIBUTES = (Public, ); }; }; 192F69941E823F78008692C7 /* RCTAnimationUtils.h in CopyFiles */ = {isa = PBXBuildFile; fileRef = 13E501B71D07A644005F35D8 /* RCTAnimationUtils.h */; }; 192F69951E823F78008692C7 /* RCTNativeAnimatedModule.h in CopyFiles */ = {isa = PBXBuildFile; fileRef = 13E501BD1D07A644005F35D8 /* RCTNativeAnimatedModule.h */; }; 192F69961E823F78008692C7 /* RCTNativeAnimatedNodesManager.h in CopyFiles */ = {isa = PBXBuildFile; fileRef = 94DA09161DC7971C00AEA8C9 /* RCTNativeAnimatedNodesManager.h */; }; @@ -77,7 +77,7 @@ 1980B7291E80D1C4004DC789 /* RCTPropsAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E01D07A6C9005F35D8 /* RCTPropsAnimatedNode.h */; }; 1980B72B1E80D1C4004DC789 /* RCTStyleAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E21D07A6C9005F35D8 /* RCTStyleAnimatedNode.h */; }; 1980B72D1E80D1C4004DC789 /* RCTTransformAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E41D07A6C9005F35D8 /* RCTTransformAnimatedNode.h */; }; - 1980B72F1E80D1C4004DC789 /* RCTValueAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E61D07A6C9005F35D8 /* RCTValueAnimatedNode.h */; }; + 1980B72F1E80D1C4004DC789 /* RCTValueAnimatedNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 13E501E61D07A6C9005F35D8 /* RCTValueAnimatedNode.h */; settings = {ATTRIBUTES = (Public, ); }; }; 1980B7321E80D259004DC789 /* RCTAnimationUtils.h in CopyFiles */ = {isa = PBXBuildFile; fileRef = 13E501B71D07A644005F35D8 /* RCTAnimationUtils.h */; }; 1980B7351E80DD6F004DC789 /* RCTNativeAnimatedModule.h in CopyFiles */ = {isa = PBXBuildFile; fileRef = 13E501BD1D07A644005F35D8 /* RCTNativeAnimatedModule.h */; }; 1980B7361E80DD6F004DC789 /* RCTNativeAnimatedNodesManager.h in CopyFiles */ = {isa = PBXBuildFile; fileRef = 94DA09161DC7971C00AEA8C9 /* RCTNativeAnimatedNodesManager.h */; }; @@ -157,7 +157,7 @@ 1980B7311E80D21C004DC789 /* CopyFiles */ = { isa = PBXCopyFilesBuildPhase; buildActionMask = 2147483647; - dstPath = include/RCTAnimation; + dstPath = include/React; dstSubfolderSpec = 16; files = ( 194804EF1E975DB500623005 /* RCTDecayAnimation.h in CopyFiles */, @@ -204,7 +204,7 @@ 13E501E31D07A6C9005F35D8 /* RCTStyleAnimatedNode.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTStyleAnimatedNode.m; sourceTree = ""; }; 13E501E41D07A6C9005F35D8 /* RCTTransformAnimatedNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; lineEnding = 0; path = RCTTransformAnimatedNode.h; sourceTree = ""; xcLanguageSpecificationIdentifier = xcode.lang.objcpp; }; 13E501E51D07A6C9005F35D8 /* RCTTransformAnimatedNode.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTTransformAnimatedNode.m; sourceTree = ""; }; - 13E501E61D07A6C9005F35D8 /* RCTValueAnimatedNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; lineEnding = 0; path = RCTValueAnimatedNode.h; sourceTree = ""; xcLanguageSpecificationIdentifier = xcode.lang.objcpp; }; + 13E501E61D07A6C9005F35D8 /* RCTValueAnimatedNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; lineEnding = 0; path = RCTValueAnimatedNode.h; sourceTree = ""; }; 13E501E71D07A6C9005F35D8 /* RCTValueAnimatedNode.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTValueAnimatedNode.m; sourceTree = ""; }; 193F64F21D776EC6004D1CAA /* RCTDiffClampAnimatedNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; lineEnding = 0; path = RCTDiffClampAnimatedNode.h; sourceTree = ""; xcLanguageSpecificationIdentifier = xcode.lang.objcpp; }; 193F64F31D776EC6004D1CAA /* RCTDiffClampAnimatedNode.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTDiffClampAnimatedNode.m; sourceTree = ""; }; From 69cc9ec613ee294ae75eb80e07da86931d15a984 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:00:43 +1100 Subject: [PATCH 06/14] ingore pods directory --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 19c3bbdce24975..c49b2ceaaefd20 100644 --- a/.gitignore +++ b/.gitignore @@ -65,3 +65,4 @@ node_modules /coverage /third-party +/RNTester/Pods From 53d4ec3b0211229df96ffb93aa56b2d51e3c2437 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:00:53 +1100 Subject: [PATCH 07/14] fishhook --- Libraries/WebSocket/RCTReconnectingWebSocket.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/WebSocket/RCTReconnectingWebSocket.m b/Libraries/WebSocket/RCTReconnectingWebSocket.m index 04e5dee57b67e7..fcd951dd59334b 100644 --- a/Libraries/WebSocket/RCTReconnectingWebSocket.m +++ b/Libraries/WebSocket/RCTReconnectingWebSocket.m @@ -9,7 +9,7 @@ #import #import -#import +#import "fishhook.h" #if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000 /* __IPHONE_11_0 */ #import From 06d4102e3f776e50a3b31884abcfb6719fa6674a Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:00:57 +1100 Subject: [PATCH 08/14] gemfile --- Gemfile | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 Gemfile diff --git a/Gemfile b/Gemfile new file mode 100644 index 00000000000000..2a5588ab1ebfe1 --- /dev/null +++ b/Gemfile @@ -0,0 +1,3 @@ +source 'https://rubygems.org' + +gem "cocoapods", "~> 1.2.0" From 96bfcd540d06f71e7d07a258103f9c9f468aa0b2 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:09:04 +1100 Subject: [PATCH 09/14] Adding RCTPushNotification --- RNTester/Podfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RNTester/Podfile b/RNTester/Podfile index 2554602057c12c..0ec107ef2aaede 100644 --- a/RNTester/Podfile +++ b/RNTester/Podfile @@ -25,7 +25,8 @@ def shared_pods 'RCTLinkingIOS', 'RCTActionSheet', 'RCTAnimation', - 'CxxBridge' + 'CxxBridge', + 'RCTPushNotification' ] end From 4258fc3eedd3edfe33f9ad8527f9bac006bfab18 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:21:56 +1100 Subject: [PATCH 10/14] yml files are hard to read adding tests correctly --- .circleci/config.yml | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 74d393df76322c..210c673ba7c9d5 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -366,6 +366,47 @@ jobs: - store_artifacts: path: ~/react-native/reports/junit + # Installs Cocoapods + install_cocoapods_objc_ios_test_app: + <<: *macos_defaults + dependencies: + pre: + - xcrun instruments -w "iPhone 5s (11.1)" || true + steps: + - attach_workspace: + at: ~/react-native + + - run: *build-objc-ios-cocoapods-install + + # Builds iOS test app - cocoapods flavour + build_objc_ios_test_app: + <<: *macos_defaults + dependencies: + pre: + - xcrun instruments -w "iPhone 5s (11.1)" || true + steps: + - attach_workspace: + at: ~/react-native + + - run: *build-objc-ios-cocoapods-test-app + + # Runs unit tests on iOS devices - cocoapods flavour + test_objc_ios: + <<: *macos_defaults + dependencies: + pre: + - xcrun instruments -w "iPhone 5s (11.1)" || true + steps: + - attach_workspace: + at: ~/react-native + + - run: *run-objc-ios-cocoapods-tests + + - store_test_results: + path: ~/react-native/reports/junit + - store_artifacts: + path: ~/react-native/reports/junit + # Builds tvOS test app build_objc_tvos_test_app: <<: *macos_defaults From f499309a24643ba91e7b625fb2470fb7b219af10 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:25:16 +1100 Subject: [PATCH 11/14] typos --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 210c673ba7c9d5..e4b71edae6018c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -229,15 +229,15 @@ aliases: name: Objective-C tvOS End-to-End Test Suite command: node ./scripts/run-ci-e2e-tests.js --tvos --js --retries 3; - - &build-objc-ios-cocaopods-install + - &build-objc-ios-cocoapods-install name: Test Cocoapods command: ./scripts/objc-test-ios-cocoapods-install.sh - - &build-objc-ios-cocaopods-test-app + - &build-objc-ios-cocoapods-test-app name: Build Objective-C iOS Test App command: ./scripts/objc-test-ios-cocoapods.sh - - &run-objc-ios-cocaopods-tests + - &run-objc-ios-cocoapods-tests name: Objective-C iOS Test Suite command: ./scripts/objc-test-ios-cocoapods.sh test From d830687e6111f41f487a36c6eb4d28ed01b53ba9 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:28:06 +1100 Subject: [PATCH 12/14] _cocoapods --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index e4b71edae6018c..41a50f2e7cf8ca 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -379,7 +379,7 @@ jobs: - run: *build-objc-ios-cocoapods-install # Builds iOS test app - cocoapods flavour - build_objc_ios_test_app: + build_objc_ios_test_app_cocoapods: <<: *macos_defaults dependencies: pre: @@ -391,7 +391,7 @@ jobs: - run: *build-objc-ios-cocoapods-test-app # Runs unit tests on iOS devices - cocoapods flavour - test_objc_ios: + test_objc_ios_cocoapods: <<: *macos_defaults dependencies: pre: From d4b64b92b26bc7657b4a8eeafbd20ca1bc3bd52a Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:37:04 +1100 Subject: [PATCH 13/14] again --- .circleci/config.yml | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 41a50f2e7cf8ca..58f5eb01d71a3c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -366,30 +366,6 @@ jobs: - store_artifacts: path: ~/react-native/reports/junit - # Installs Cocoapods - install_cocoapods_objc_ios_test_app: - <<: *macos_defaults - dependencies: - pre: - - xcrun instruments -w "iPhone 5s (11.1)" || true - steps: - - attach_workspace: - at: ~/react-native - - - run: *build-objc-ios-cocoapods-install - - # Builds iOS test app - cocoapods flavour - build_objc_ios_test_app_cocoapods: - <<: *macos_defaults - dependencies: - pre: - - xcrun instruments -w "iPhone 5s (11.1)" || true - steps: - - attach_workspace: - at: ~/react-native - - - run: *build-objc-ios-cocoapods-test-app - # Runs unit tests on iOS devices - cocoapods flavour test_objc_ios_cocoapods: <<: *macos_defaults @@ -399,7 +375,8 @@ jobs: steps: - attach_workspace: at: ~/react-native - + - run: *build-objc-ios-cocoapods-install + - run: *build-objc-ios-cocoapods-test-app - run: *run-objc-ios-cocoapods-tests - store_test_results: @@ -665,6 +642,13 @@ workflows: requires: - checkout_code + # Test Cocoapods Integration + - test_objc_ios_cocoapods: + filters: *filter-ignore-gh-pages + requires: + - checkout_code + + # Only runs on PRs analyze: jobs: From f923a9f0488b891dd7550417ff50f36698373b0f Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Mon, 26 Feb 2018 18:39:55 +1100 Subject: [PATCH 14/14] correct directory --- scripts/objc-test-ios-cocoapods-install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/objc-test-ios-cocoapods-install.sh b/scripts/objc-test-ios-cocoapods-install.sh index 4866e0babc0ebd..f37b1c85de0387 100755 --- a/scripts/objc-test-ios-cocoapods-install.sh +++ b/scripts/objc-test-ios-cocoapods-install.sh @@ -11,7 +11,7 @@ set -ex SCRIPTS=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) ROOT=$(dirname "$SCRIPTS") -cd "$ROOT" +cd "$ROOT/RNTester" SCHEME="RNTester" SDK="iphonesimulator"