Add support for resource-id

[lightboys22]

Summary

Track react tag using android.view.View.tag. Allow developers to set resource id by setting component.testID

Fixes #9777

Test Plan

First, you need to declare the resource id by creating /your_android_studio_folder/res/values/ids.xml

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <item type="id" name="test_id"/>
</resources>

Second. Optionally, you can expose the resource id names so we can access them in our JSX code. Or you can just hard code a list of resource id names.

public class ConstantsModule extends BaseJavaModule {
  @Override
  public String getName() {
    return REACT_NAME;
  }

  @Override
  public Map<String, Object> getConstants() {
    return // return the map with resource ids here.
  }
}

Third, set the testID of your component to the name of a resource id.

<Button
    onPress={onButtonPress}
    title="Press Me"
    testID='test_id'
    />

Forth, run the app and observe the resource id using UIAutomator viewer (/Android/sdk/tools/bin/uiautomatorviewer)

Related PRs

This PR doesn't require a documentation change.

Changelog

[ANDROID] [Fixes] - BaseViewManager: Allow developers to set resource id by setting component.testID

[nes123]

any plans to continue with that?

[erez-guesty]

hi
whats the status of this feature?

[ronilitman]

@lightboys22 any news on that?

[mdvacca]

@lightboys22 thanks for working on this!
I agree that it would be good to not use the View.id field to store the reactTag, but I have few concerns about this change:

• This change is non backward compatible: the View.id field is used as part of events, merging this PR as it is will produce bugs in viewManager that are not part of the Core of React Native.
  Usually for changes like this we first deprecate old methods in one version, we document and communicate this change to the community and then in one or two versions we change the behavior.

• Performance: I wonder if this change will regress performance in any way during rendering. View.id is just a long variable, but when you set a tag, View internally creates a SparseArray where it stores the Tag, in this case the ReactTag.
  This means that every time we need to access the 'reactTag' we need to search in this SparseArray instead of just accessing a variable. This cost will be paid by all the views in React Native. Let's just double check this.

• There are changes in classes that do not exist anymore and classes has changed a lot, you should rebase

I also would like to hear from other core contributors about this change: @dulmandakh @gengjiawen

[icew1nd]

Is there any progress on this? Would help a lot with bot testing 🎉

[lightboys22]

Sorry, I won’t be working on this. You can try using the Espresso JavaScript framework to find view based on tags, (which is the testID）

[LuisBonsembiante]

Waht happen with this PR?... why everithing is complicated in RN?

[lightboys22]

Are you trying to write an unit test? If so, you can try using Expresso

…

On Mon, Mar 16, 2020 at 7:29 AM LuisBonsembiante ***@***.***> wrote: Waht happen with this PR?... why everithing is complicated in RN? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#18527 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCSEXTCY57IWBUMAZZ54PTRHYZVNANCNFSM4EXFBCQA> .

[LuisBonsembiante]

@lightboys22 ...It is for robo test... so I need a resource-id....