Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website improvements #223

Merged
merged 5 commits into from
Mar 26, 2015
Merged

Website improvements #223

merged 5 commits into from
Mar 26, 2015

Conversation

zpao
Copy link
Member

@zpao zpao commented Mar 26, 2015

  • Quick fix for responsiveness
  • Optimized images (shave off ~40% of bytes)
  • Don't link to #content (feels really bad on mobile)

@zpao
Copy link
Member Author

zpao commented Mar 26, 2015

Well, I set the size wrong for that breakpoint image AND I forgot about retina displays, so it's blurry...

@amasad
Copy link
Contributor

amasad commented Mar 26, 2015

Does this fix the horizontal scroll on mobile?

@zpao
Copy link
Member Author

zpao commented Mar 26, 2015

Almost, need to also set overflow: auto on .prism (code).

I'm going to drop the image resizing and just optim them and add the prism fix.

@amasad
Copy link
Contributor

amasad commented Mar 26, 2015

(y)

@zpao zpao force-pushed the website-improvements branch from 5ef0368 to 4c65579 Compare March 26, 2015 18:51
@zpao
Copy link
Member Author

zpao commented Mar 26, 2015

Alright, all better.

screen shot 2015-03-26 at 11 51 23 am

zpao added 5 commits March 26, 2015 11:52
This is a quick fix for "responsive" views. It's not perfect but it's
less bad.
This should fix the remaining horizontal scrolls on mobile.
This looks *less bad* than it currently does but it's still pretty
clowny.
@zpao zpao force-pushed the website-improvements branch from 4c65579 to 35fa5aa Compare March 26, 2015 18:52
sophiebits added a commit that referenced this pull request Mar 26, 2015
@sophiebits sophiebits merged commit b4da77a into facebook:master Mar 26, 2015
mganandraj added a commit to mganandraj/react-native that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants