From 2d8deceb2898a526462f705a87f970654bc73f41 Mon Sep 17 00:00:00 2001 From: michalchudziak Date: Wed, 13 Mar 2019 16:03:00 +0100 Subject: [PATCH 1/5] Add .eslintrc to RN template --- template/_eslintrc | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 template/_eslintrc diff --git a/template/_eslintrc b/template/_eslintrc new file mode 100644 index 00000000000000..42e05bdca5db45 --- /dev/null +++ b/template/_eslintrc @@ -0,0 +1,6 @@ +{ + "env": { + "jest": true + }, + "extends": "@react-native-community" +} \ No newline at end of file From d36eaecf30319bb9ce2594460487825ad7ccf492 Mon Sep 17 00:00:00 2001 From: michalchudziak Date: Wed, 13 Mar 2019 16:51:13 +0100 Subject: [PATCH 2/5] Add root: true, reorder keys in .eslintrc --- template/_eslintrc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/template/_eslintrc b/template/_eslintrc index 42e05bdca5db45..d3a52a926b2082 100644 --- a/template/_eslintrc +++ b/template/_eslintrc @@ -1,6 +1,9 @@ { + "root": true, + + "extends": "@react-native-community", + "env": { "jest": true - }, - "extends": "@react-native-community" + } } \ No newline at end of file From e745f0ee6704a70892bb8419d4a8bc287c532eb3 Mon Sep 17 00:00:00 2001 From: michalchudziak Date: Tue, 19 Mar 2019 10:38:48 +0000 Subject: [PATCH 3/5] Change .eslintrc to .eslintrc.js --- template/_eslintrc | 9 --------- template/_eslintrc.js | 4 ++++ 2 files changed, 4 insertions(+), 9 deletions(-) delete mode 100644 template/_eslintrc create mode 100644 template/_eslintrc.js diff --git a/template/_eslintrc b/template/_eslintrc deleted file mode 100644 index d3a52a926b2082..00000000000000 --- a/template/_eslintrc +++ /dev/null @@ -1,9 +0,0 @@ -{ - "root": true, - - "extends": "@react-native-community", - - "env": { - "jest": true - } -} \ No newline at end of file diff --git a/template/_eslintrc.js b/template/_eslintrc.js new file mode 100644 index 00000000000000..40c6dcd05f3100 --- /dev/null +++ b/template/_eslintrc.js @@ -0,0 +1,4 @@ +module.exports = { + root: true, + extends: '@react-native-community', +}; From c0160a13d06d6f3d0f2bbbc2b7b31fbf4e4a4ebf Mon Sep 17 00:00:00 2001 From: michalchudziak Date: Tue, 19 Mar 2019 10:39:46 +0000 Subject: [PATCH 4/5] Add jest and jest/globals env to eslint config, bump it's version --- packages/eslint-config-react-native-community/index.js | 2 ++ packages/eslint-config-react-native-community/package.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react-native-community/index.js b/packages/eslint-config-react-native-community/index.js index 9a870649783f55..9a27dd7edcf382 100644 --- a/packages/eslint-config-react-native-community/index.js +++ b/packages/eslint-config-react-native-community/index.js @@ -12,6 +12,8 @@ module.exports = { env: { es6: true, + jest: true, + 'jest/globals': true, }, plugins: [ diff --git a/packages/eslint-config-react-native-community/package.json b/packages/eslint-config-react-native-community/package.json index 59037359a7d5e3..92fff6943818a9 100644 --- a/packages/eslint-config-react-native-community/package.json +++ b/packages/eslint-config-react-native-community/package.json @@ -1,6 +1,6 @@ { "name": "@react-native-community/eslint-config", - "version": "0.0.2", + "version": "0.0.3", "description": "ESLint config for React Native", "main": "index.js", "repository": { From 9e0cced30aa86a55f2130e01f7f75c421855b844 Mon Sep 17 00:00:00 2001 From: michalchudziak Date: Wed, 20 Mar 2019 11:11:35 +0000 Subject: [PATCH 5/5] Extract jest config to overrides section --- packages/eslint-config-react-native-community/index.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/eslint-config-react-native-community/index.js b/packages/eslint-config-react-native-community/index.js index 9a27dd7edcf382..191a7356682ae2 100644 --- a/packages/eslint-config-react-native-community/index.js +++ b/packages/eslint-config-react-native-community/index.js @@ -12,8 +12,6 @@ module.exports = { env: { es6: true, - jest: true, - 'jest/globals': true, }, plugins: [ @@ -32,6 +30,14 @@ module.exports = { }, }, + overrides: { + files: ['**/__tests__/**/*.js', '**/?(*.)(spec|test).js'], + env: { + jest: true, + 'jest/globals': true, + }, + }, + // Map from global var to bool specifying if it can be redefined globals: { __DEV__: true,