Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the android gitignore to sample app #2687

Closed
wants to merge 3 commits into from
Closed

Add the android gitignore to sample app #2687

wants to merge 3 commits into from

Conversation

jhen0409
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@@ -21,6 +21,12 @@ DerivedData
*.ipa
*.xcuserstate

# Android/IJ
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest Android Studio uses this instead:

*/.idea/workspace.xml
*/.idea/libraries

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2015
@kmagiera
Copy link
Contributor

Is this change ignoring anything that is not already covered by .gitignore in the root directory https://github.com/facebook/react-native/blob/master/.gitignore ?

@ide
Copy link
Contributor

ide commented Sep 14, 2015

Right.. this should go under _gitignore instead.

@jhen0409
Copy link
Contributor Author

Oh, sorry. I'm missed _gitignore file. :|

@mkonicek
Copy link
Contributor

@jhen0409 Do you want to update this PR or send a new one?

@jhen0409
Copy link
Contributor Author

@mkonicek I send the new PR #2776. Thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants