Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#31386 Fix Readme link to Testing #31387

Closed
wants to merge 1 commit into from

Conversation

sangeethaKP
Copy link
Contributor

Fix Readme link to Testing section

Summary

Fix Readme link to Testing section

Changelog

[Android] [Fixed] - Fixed link to Testing in React Native Android ReadMe file

Test Plan

Change has been made to a Readme documentation, no changes in code

Fix Readme link to Testing section
@sangeethaKP sangeethaKP requested a review from hramos as a code owner April 19, 2021 21:50
@facebook-github-bot
Copy link
Contributor

Hi @sangeethaKP!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,853,608 +0
android hermes armeabi-v7a 8,374,979 +0
android hermes x86 9,310,564 +0
android hermes x86_64 9,253,558 +0
android jsc arm64-v8a 10,584,531 +0
android jsc armeabi-v7a 10,089,010 +0
android jsc x86 10,602,985 +0
android jsc x86_64 11,186,256 +0

Base commit: 7258afe

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7258afe

@facebook-github-bot
Copy link
Contributor

@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@sangeethaKP
Copy link
Contributor Author

The circleci: test_windows tests seem to be unrelated to this change, but it is unclear how I can get it to pass. @PeteTheHeat could you please help? Thank you!

@PeteTheHeat
Copy link
Contributor

Yeah definitely unrelated, don't worry about it, I'll just merge it anyways.

Thanks for the fix!

@facebook-github-bot
Copy link
Contributor

@PeteTheHeat merged this pull request in 7db89f9.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: React Native Team Attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants