CocoaPods: simplify iOS build directory cleanup #42233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52659429 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 10, 2024
Summary: This diff removes the need for providing the `ios_folder` argument to `use_react_native`. We no longer do any manual path tranformations to get the iOS project root. Instead we use `Pod::Config.instance.installation_root` which always points to the correct directory. Changelog: [Internal] Differential Revision: D52659429
dmytrorykun
force-pushed
the
export-D52659429
branch
from
edb2a45 to
88a3c10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52659429 |
Base commit: 8fd2f12 |
Summary: This diff removes the need for providing the `ios_folder` argument to `use_react_native`. We no longer do any manual path tranformations to get the iOS project root. Instead we use `Pod::Config.instance.installation_root` which always points to the correct directory. Changelog: [iOS][Breaking] - CocoaPods: remove the `ios_folder` argument from the `use_react_native` function. Reviewed By: cipolleschi Differential Revision: D52659429
dmytrorykun
force-pushed
the
export-D52659429
branch
from
88a3c10 to
9b87872
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52659429 |
|
This pull request has been merged in be0c353. |
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
Summary: Pull Request resolved: facebook#42233 This diff removes the need for providing the `ios_folder` argument to `use_react_native`. We no longer do any manual path tranformations to get the iOS project root. Instead we use `Pod::Config.instance.installation_root` which always points to the correct directory. Changelog: [iOS][Breaking] - CocoaPods: remove the `ios_folder` argument from the `use_react_native` function. Reviewed By: cipolleschi Differential Revision: D52659429 fbshipit-source-id: 67c79cd9d74a0351ad2c242b74cbd48b6bd2dc94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff removes the need for providing the
ios_folderargument touse_react_native. We no longer do any manual path tranformations to get the iOS project root.Instead we use
Pod::Config.instance.installation_rootwhich always points to the correct directory.Changelog: [iOS][Breaking] - CocoaPods: remove the
ios_folderargument from theuse_react_nativefunction.Differential Revision: D52659429