Fix Android AlertFragment Title Accessibility (#45048) #45395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Changelog: [Android] [Fixed] - Fix AlertDialog title accessibility Pull Request resolved: facebook#45048 Making title accessible for android AlertFragment Reviewed By: blavalla, susnchen Differential Revision: D58684576
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58684576 |
|
This pull request has been merged in 80a3ed7. |
|
This pull request was successfully merged by Peter Abbondanzo in 80a3ed7. When will my fix make it into a release? | How to file a pick request? |
cipolleschi
added a commit
that referenced
this pull request
Oct 17, 2024
This reverts commit 80a3ed7.
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Oct 17, 2024
Summary: The [internal `DialogTitle` implementation from Android](https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/core/java/com/android/internal/widget/DialogTitle.java;l=63?q=DialogTitle) makes additional checks to see if the title should wrap to two lines before applying ellipsis, so this change recreates those same checks. This change also removes the text appearance and size changes made to the layout. Reverts some of the changes made to facebook#45395. **Changelog:** [Android][Fixed] - Fixed styling on alert dialog titles to wrap two lines and retain bold appearance Differential Revision: D64543105
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
) Summary: Pull Request resolved: #47095 The [internal `DialogTitle` implementation from Android](https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/core/java/com/android/internal/widget/DialogTitle.java;l=63?q=DialogTitle) makes additional checks to see if the title should wrap to two lines before applying ellipsis, so this change recreates those same checks. This change also removes the text appearance and size changes made to the layout. Reverts some of the changes made to #45395. **Changelog:** [Android][Fixed] - Fixed styling on alert dialog titles to wrap two lines and retain bold appearance Reviewed By: cortinico Differential Revision: D64543105 fbshipit-source-id: 30d1f9091aa7216eb5d00e4f8f14cbc719c803ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Android] [Fixed] - Fix AlertDialog title accessibility
Making title accessible for android AlertFragment
Reviewed By: blavalla, susnchen
Differential Revision: D58684576