feat(android): height issue fixed with keyboard avoiding component in new architecture #45928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
Can confirm that without this fix, is completely broken on android new arch. |
Titozzz
approved these changes
Aug 9, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 603eb94. |
|
This pull request was successfully merged by @shubhamguptadream11 in 603eb94 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Aug 19, 2024
… new architecture (#45928) Summary: Fixes this issue: #45880 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID] [CHANGED] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Replaced `mLastHeight` with `mVisibleViewArea.height()` since mLastHeight value is not getting updated. For `width` we are already using `mVisibleViewArea.width()` Pull Request resolved: #45928 Test Plan: - Tested the fix in new and old architecture both Reviewed By: christophpurrer Differential Revision: D61023998 Pulled By: cortinico fbshipit-source-id: df67616330effb7b9e6724d94b3be92c0dbd6190
|
This pull request was successfully merged by @shubhamguptadream11 in 1cea8e8. When will my fix make it into a release? | How to file a pick request? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes this issue: #45880
Changelog:
[ANDROID] [CHANGED] - Replaced
mLastHeightwithmVisibleViewArea.height()since mLastHeight value is not getting updated. Forwidthwe are already usingmVisibleViewArea.width()Test Plan: