Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change opacity logic from random to decrement by -0.20 #46830

Closed
wants to merge 2 commits into from
Closed

fix: change opacity logic from random to decrement by -0.20 #46830

wants to merge 2 commits into from

Conversation

sarthak-d11
Copy link
Contributor

Summary:

Part of this: #46757
Solves:

ME2E0003

Changelog:

[ Internal ] [ Changed ] - The opacity logic is changed from random to decrement the opacity by -0.2
For more details, see:

Test Plan:

yarn e2e-test-ios
yarn e2e-test-android

@facebook-github-bot
Copy link
Contributor

Hi @sarthak-d11!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@sarthak-d11 sarthak-d11 closed this Oct 4, 2024
@sarthak-d11 sarthak-d11 reopened this Oct 4, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 4, 2024
cipolleschi
cipolleschi requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarthak-d11 for taking a stance at that. However, I don't think that the current implementation is working as we expect. Can you check the comment I left, please?

packages/rn-tester/NativeComponentExample/js/MyNativeView.js Outdated Show resolved Hide resolved
cipolleschi
cipolleschi requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and thanks for the patience. I'd update the function name as it could be misleading. But looks good, aside for this.

packages/rn-tester/NativeComponentExample/js/MyNativeView.js Outdated Show resolved Hide resolved
packages/rn-tester/NativeComponentExample/js/MyNativeView.js Outdated
@@ -85,6 +85,14 @@ function getTextFor(measureStruct: MeasureStruct): string {
measureStruct.height,
)}`;
}
const opacityDecrementCounter = 0.2;

function getOpacity(opacity: number): number {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function getOpacity(opacity: number): number {
function computeNextOpacity(opacity: number): number {

Can we change the name of the function to make clearer what's its purpose? Otherwise it looks like it should return the opacity value, but it is actually doing much more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the function name as you said. Please review

cipolleschi
cipolleschi approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, thank you so much

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 10, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in af49070.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @sarthak-d11 in af49070

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarthak-d11 @facebook-github-bot @react-native-bot @cipolleschi