Clean up feature flag allowRecursiveCommitsWithSynchronousMountOnAndroid
#47665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roid` Summary: Changelog: [Android][Fixed] Fixes some deadlocks when doing commits and state updates synchronously from the UI thread (e.g.: from reanimated). This removes the gating for the fix to allow recursive commits with synchronous mount on Android. See facebook#44725 (comment) and software-mansion/react-native-reanimated#6418 (comment). Differential Revision: D66095539
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66095539 |
|
This pull request has been merged in 3986eef. |
|
This pull request was successfully merged by @rubennorte in 3986eef When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android][Fixed] Fixes some deadlocks when doing commits and state updates synchronously from the UI thread (e.g.: from reanimated).
This removes the gating for the fix to allow recursive commits with synchronous mount on Android.
See #44725 (comment) and software-mansion/react-native-reanimated#6418 (comment).
Differential Revision: D66095539