Remove the option to use JSC from core #51946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
22875fe to
dd3f52e
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Differential Revision: D76342625 Reviewed By: cortinico
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
dd3f52e to
161d59c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
161d59c to
f41b9ce
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
force-pushed
the
export-D76342625
branch
from
f41b9ce to
3eca56c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
3eca56c to
c34da1e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
c34da1e to
3db65f8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
force-pushed
the
export-D76342625
branch
from
3db65f8 to
631b10f
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Differential Revision: D76342625 Reviewed By: cortinico
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
631b10f to
00b90b7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 12, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
00b90b7 to
df1acd2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
cipolleschi
force-pushed
the
export-D76342625
branch
from
df1acd2 to
43b10eb
Compare
Summary: Pull Request resolved: facebook#51946 This change simplified the setp disallowing to use JSC from core. As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC ## Changelog: [iOS][Removed] - remove the option to use JSC from core Reviewed By: cortinico Differential Revision: D76342625
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76342625 |
cipolleschi
force-pushed
the
export-D76342625
branch
from
43b10eb to
295f1d4
Compare
Contributor
|
This pull request has been merged in a6ea626. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in a6ea626 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change simplified the setp disallowing to use JSC from core.
As a side effect, it simplified the setup by always falling back to hermes if the users decides not to use the third party JSC
Changelog:
[iOS][Removed] - remove the option to use JSC from core
Differential Revision: D76342625