Fix Switch layout with iOS26 #53326
Closed
Fix Switch layout with iOS26 #53326
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80454350 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80454350 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Aug 18, 2025
Summary: Pull Request resolved: facebook#53326 Apple changed the sizes of the UISwitchComponent and now, if you build an iOs app using the <Switch> component, the layout of the app will be broken because of wrong layout measurements. This has been reported also by [https://github.com/facebook/react-native/issues/52823](https://github.com/facebook/react-native/issues/52823). The `<Switch>` component was using hardcoded values for its size. This change fixes the problem by: - Using codegen for interface only - Implementing a custom Sadow Node to ask the platform for the Switch measurements - Updating the JS layout to wrap the size around the native component. ## Changelog: [iOS][Fixed] - Fix Switch layout to work with iOS26 Differential Revision: D80454350
cipolleschi
force-pushed
the
export-D80454350
branch
from
f987d1c to
e198297
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80454350 |
cipolleschi
force-pushed
the
export-D80454350
branch
from
e198297 to
cb890fc
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Aug 18, 2025
Summary: Pull Request resolved: facebook#53326 Apple changed the sizes of the UISwitchComponent and now, if you build an iOs app using the <Switch> component, the layout of the app will be broken because of wrong layout measurements. This has been reported also by [https://github.com/facebook/react-native/issues/52823](https://github.com/facebook/react-native/issues/52823). The `<Switch>` component was using hardcoded values for its size. This change fixes the problem by: - Using codegen for interface only - Implementing a custom Sadow Node to ask the platform for the Switch measurements - Updating the JS layout to wrap the size around the native component. ## Changelog: [iOS][Fixed] - Fix Switch layout to work with iOS26 Differential Revision: D80454350
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80454350 |
cipolleschi
force-pushed
the
export-D80454350
branch
from
cb890fc to
9b47a5e
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Aug 18, 2025
Summary: Pull Request resolved: facebook#53326 Apple changed the sizes of the UISwitchComponent and now, if you build an iOs app using the <Switch> component, the layout of the app will be broken because of wrong layout measurements. This has been reported also by [https://github.com/facebook/react-native/issues/52823](https://github.com/facebook/react-native/issues/52823). The `<Switch>` component was using hardcoded values for its size. This change fixes the problem by: - Using codegen for interface only - Implementing a custom Sadow Node to ask the platform for the Switch measurements - Updating the JS layout to wrap the size around the native component. ## Changelog: [iOS][Fixed] - Fix Switch layout to work with iOS26 Differential Revision: D80454350
cipolleschi
force-pushed
the
export-D80454350
branch
from
9b47a5e to
24f1d71
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 3, 2025
Summary: Apple changed the sizes of the UISwitchComponent and now, if you build an iOs app using the <Switch> component, the layout of the app will be broken because of wrong layout measurements. This has been reported also by [https://github.com/facebook/react-native/issues/52823](https://github.com/facebook/react-native/issues/52823). The `<Switch>` component was using hardcoded values for its size. This change fixes the problem by: - Using codegen for interface only - Implementing a custom Sadow Node to ask the platform for the Switch measurements - Updating the JS layout to wrap the size around the native component. ## Changelog: [iOS][Fixed] - Fix Switch layout to work with iOS26 Reviewed By: sammy-SC Differential Revision: D80454350
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80454350 |
Summary: Apple changed the sizes of the UISwitchComponent and now, if you build an iOs app using the <Switch> component, the layout of the app will be broken because of wrong layout measurements. This has been reported also by [https://github.com/facebook/react-native/issues/52823](https://github.com/facebook/react-native/issues/52823). The `<Switch>` component was using hardcoded values for its size. This change fixes the problem by: - Using codegen for interface only - Implementing a custom Sadow Node to ask the platform for the Switch measurements - Updating the JS layout to wrap the size around the native component. ## Changelog: [iOS][Fixed] - Fix Switch layout to work with iOS26 Reviewed By: sammy-SC Differential Revision: D80454350
cipolleschi
force-pushed
the
export-D80454350
branch
from
24f1d71 to
1913ca7
Compare
Contributor
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating diff in D80454350. |
Contributor
|
This pull request has been merged in 91d427f. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 91d427f When will my fix make it into a release? | How to file a pick request? |
vzaidman
pushed a commit
that referenced
this pull request
Sep 22, 2025
Summary: Pull Request resolved: #53326 Apple changed the sizes of the UISwitchComponent and now, if you build an iOs app using the <Switch> component, the layout of the app will be broken because of wrong layout measurements. This has been reported also by [https://github.com/facebook/react-native/issues/52823](https://github.com/facebook/react-native/issues/52823). The `<Switch>` component was using hardcoded values for its size. This change fixes the problem by: - Using codegen for interface only - Implementing a custom Sadow Node to ask the platform for the Switch measurements - Updating the JS layout to wrap the size around the native component. ## Changelog: [iOS][Fixed] - Fix Switch layout to work with iOS26 Reviewed By: sammy-SC Differential Revision: D80454350 fbshipit-source-id: 1d468910276f7fde4559d2ae87cf60c8494caceb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Apple changed the sizes of the UISwitchComponent and now, if you build an iOs app using the component, the layout of the app will be broken because of wrong layout measurements.
This has been reported also by #52823.
The
<Switch>component was using hardcoded values for its size.This change fixes the problem by:
Changelog:
[iOS][Fixed] - Fix Switch layout to work with iOS26
Differential Revision: D80454350
Test Plan