[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

kitten · 2025-10-06T13:04:45Z

Summary:

An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new autolinking.json correctly; See: #53503

This PR "double" fixes this by:

simply passing the "real" output directory to the artifacts generator in (script_phases.sh) where it's called by Xcode, rather than a temporary directory
preferring $RCT_SCRIPT_OUTPUT_DIR if it's set as an environment variable in the artifacts generator (which it is by script_phases.sh)

While this is technically redundant, future changes here make this feel like a safer option, since both conventions overlap in these two places, and the double fix may prevent a regression here in the shortterm and convey what this path is supposed to be in both places.

Changelog:

[IOS] [FIXED] - Fix autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory

Test Plan:

Prefer $RCT_SCRIPT_OUTPUT_DIR env var for finding build/generated/autolinking/autolinking.json
Always use real $RCT_SCRIPT_OUTPUT_DIR as output in withCodegenDiscovery in react_native_pods_utils/script_phases.sh (which is called by Xcode rather than Cocoapods to invoke the artifacts generator) since the temporary output directory isn't necessary

…pt_phases.sh Avoid ending up in in derive data output folder to be able to discover `autolinking.json` generated in Cocoapods step in all cases, regardless of if the script checks `RCT_SCRIPT_OUTPUT_DIR` itself.

An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new autolinking.json correctly; See: #53503 This has been fixed upstream here: facebook/react-native#54066 Untill this one is merged, released and available to Expo, we need a workaround. Added build phase script for a workaround to autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory.

cipolleschi · 2025-10-06T17:59:00Z

The change is much earlier. We always run codegen in xcode. This allows users to write native modules and native components locally in their app, without having to reinstall cocopods everytime they change the specs of those custom modules/components.

cipolleschi

Overall the changes make sense to me and I'm positive in supporting them. I don't like the approach of looping over some outputPatchCandidates... Cn we find a way not to have that loop?

packages/react-native/scripts/react_native_pods_utils/script_phases.sh

cipolleschi · 2025-10-06T18:03:28Z

packages/react-native/scripts/react_native_pods_utils/script_phases.sh

-    moveOutputs
+    describe "Generating codegen artifacts"
+    pushd "$RCT_SCRIPT_RN_DIR" >/dev/null || exit 1
+        "$NODE_BINARY" "scripts/generate-codegen-artifacts.js" --path "$RCT_SCRIPT_APP_PATH" --outputPath "$RCT_SCRIPT_OUTPUT_DIR" --targetPlatform "ios"


The value of RCT_SCRIPT_OUTPUT_DIR is always RCT_SCRIPT_POD_INSTALLATION_ROOT, which is set to be

pushd "$PODS_ROOT/../" > /dev/null RCT_SCRIPT_POD_INSTALLATION_ROOT=$(pwd)

So it will always be Pods/.., which is where we want codegen to be generated.
Just adding the comment for the future.

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js

…index.js`

An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new autolinking.json correctly; See: #53503 This has been fixed upstream here: facebook/react-native#54066 Untill this one is merged, released and available to Expo, we need a workaround. Added build phase script for a workaround to autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory.

byCedric · 2025-10-07T11:19:06Z

@cipolleschi, just out of curiosity, why is the script_phases.sh running explicitly in the DerivedData folders, and not just in the normal <project>/ios folder?

(I know you are busy with React Conf, this can wait until after)

@byCedric

# Why An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new autolinking.json correctly; See: #53503 This has been fixed upstream here: facebook/react-native#54066 Untill this one is merged, released and available to Expo, we need a workaround. # How Added build phase script for a workaround to autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory. @byCedric participated in the script, and it has been tested with a new Expo project using pnpm. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Cedric van Putten <me@bycedric.com>

@byCedric

An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new autolinking.json correctly; See: #53503 This has been fixed upstream here: facebook/react-native#54066 Untill this one is merged, released and available to Expo, we need a workaround. Added build phase script for a workaround to autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory. @byCedric participated in the script, and it has been tested with a new Expo project using pnpm. - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Cedric van Putten <me@bycedric.com>

cipolleschi

Thanks for updating the PR.

meta-codesync · 2025-10-28T15:36:22Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D85673625.

meta-codesync · 2025-10-28T17:49:33Z

@cipolleschi merged this pull request in c029032.

react-native-bot · 2025-10-28T17:49:35Z

This pull request was successfully merged by @kitten in c029032

^{When will my fix make it into a release? | How to file a pick request?}

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025

facebook-github-bot added p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 6, 2025

kitten force-pushed the @kitten/fix/codegen-run-in-xcode branch 2 times, most recently from 87f82c4 to 79a1ca4 Compare October 6, 2025 15:09

Use RCT_SCRIPT_OUTPUT_DIR env var to find autolinking.json output too

7b562c3

kitten force-pushed the @kitten/fix/codegen-run-in-xcode branch from 79a1ca4 to d08506e Compare October 6, 2025 16:43

kitten force-pushed the @kitten/fix/codegen-run-in-xcode branch from d08506e to b464256 Compare October 6, 2025 16:48

chrfalch mentioned this pull request Oct 6, 2025

[autolinking][ios] Added workaround to autolinking issue in RN expo/expo#40219

Merged

2 tasks

cipolleschi requested changes Oct 6, 2025

View reviewed changes

kitten added 2 commits October 6, 2025 19:25

Add comments and separate pods/xcode autolinking.json loading

c7af004

Revert structural changes in react_native_pods_utils/script_phases.sh

449258e

kitten force-pushed the @kitten/fix/codegen-run-in-xcode branch from 90bc77f to bb178a4 Compare October 6, 2025 19:06

Move RCT_SCRIPT_OUTPUT_DIR switching to `generate-artifacts-executor/…

d5955f2

…index.js`

kitten force-pushed the @kitten/fix/codegen-run-in-xcode branch from bb178a4 to d5955f2 Compare October 6, 2025 19:09

kitten requested a review from cipolleschi October 6, 2025 19:23

Apply prettier

4d334e1

cipolleschi approved these changes Oct 28, 2025

View reviewed changes

meta-codesync bot closed this in c029032 Oct 28, 2025

facebook-github-bot added the Merged This PR has been merged. label Oct 28, 2025

This was referenced Oct 28, 2025

[0.82] Fix outputs when iOS artifacts generator is run from Xcode script phase reactwg/react-native-releases#1159

Open

[0.81] Fix outputs when iOS artifacts generator is run from Xcode script phase reactwg/react-native-releases#1160

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

Uh oh!

kitten commented Oct 6, 2025 •

edited

Loading

Uh oh!

cipolleschi commented Oct 6, 2025

Uh oh!

cipolleschi left a comment

Uh oh!

Uh oh!

cipolleschi Oct 6, 2025

Uh oh!

Uh oh!

byCedric commented Oct 7, 2025

Uh oh!

cipolleschi left a comment

Uh oh!

meta-codesync bot commented Oct 28, 2025

Uh oh!

meta-codesync bot commented Oct 28, 2025

Uh oh!

react-native-bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

Uh oh!

Conversation

kitten commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

cipolleschi commented Oct 6, 2025

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cipolleschi Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

byCedric commented Oct 7, 2025

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

meta-codesync bot commented Oct 28, 2025

Uh oh!

meta-codesync bot commented Oct 28, 2025

Uh oh!

react-native-bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kitten commented Oct 6, 2025 •

edited

Loading