Update to new ReactPerf #7283
Update to new ReactPerf #7283
Conversation
|
By analyzing the blame information on this pull request, we identified @sebmarkbage and @tadeuzagallo to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| @@ -11,7 +11,7 @@ | |||
| */ | |||
| 'use strict'; | |||
|
|
|||
| var ReactDefaultPerf = require('ReactDefaultPerf'); | |||
| var ReactPerfAnalysis = require('ReactPerfAnalysis'); | |||
There was a problem hiding this comment.
ReactPerfAnalysis Required module not found
|
@gaearon updated the pull request. |
| } | ||
| function ReactComponentTreeDevtool() { | ||
| if (!_ReactComponentTreeDevtool) { | ||
| _ReactComponentTreeDevtool = require('ReactComponentTreeDevtool'); |
There was a problem hiding this comment.
ReactComponentTreeDevtool Required module not found
|
@gaearon updated the pull request. |
| } | ||
| function ReactComponentTreeDevtool() { | ||
| if (!_ReactComponentTreeDevtool) { | ||
| _ReactComponentTreeDevtool = require('ReactComponentTreeDevtool'); |
There was a problem hiding this comment.
ReactComponentTreeDevtool Required module not found
|
@gaearon updated the pull request. |
| } | ||
| function ReactComponentTreeDevtool() { | ||
| if (!_ReactComponentTreeDevtool) { | ||
| _ReactComponentTreeDevtool = require('ReactComponentTreeDevtool'); |
There was a problem hiding this comment.
ReactComponentTreeDevtool Required module not found
There was a problem hiding this comment.
ReactComponentTreeDevtool Required module not found
|
This is ready for review. |
|
@gaearon Tests seem to be broken! |
|
Sorry, I should have been clear. |
|
@gaearon Okay then. I'm assigning this to @sebmarkbage as he usually does the sync. |
|
Test plan:
For the other change,
|
|
Landed as part of a95405f, thanks. |
This is a work in progress on removing the dependency on the old ReactPerf and replacing it with the new one. Related PRs in React: facebook/react#6647, facebook/react#6046.