From 06feb90471039a905bdfd47f2bffc071a12dad49 Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Thu, 18 Jul 2024 16:19:12 -0400 Subject: [PATCH] [circleci] Inline scrape_warning_messages This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8fb9cf01d8fffe7e7590729a44def265c79 Pull Request resolved: https://github.com/facebook/react/pull/30388 --- .circleci/config.yml | 27 ++++----------------------- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a95b612e2fdb0..fc24be0cae1b3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -48,22 +48,6 @@ parameters: default: '' jobs: - scrape_warning_messages: - docker: *docker - environment: *environment - - steps: - - checkout - - setup_node_modules - - run: - command: | - mkdir -p ./build/__test_utils__ - node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js - - persist_to_workspace: - root: . - paths: - - build - yarn_build: docker: *docker environment: *environment @@ -106,7 +90,10 @@ jobs: at: . - setup_node_modules - run: echo "<< pipeline.git.revision >>" >> build/COMMIT_SHA - # Compress build directory into a single tarball for easy download + - run: | + mkdir -p ./build/__test_utils__ + node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js + # Compress build directory into a single tarball for easy download - run: tar -zcvf ./build.tgz ./build # TODO: Migrate scripts to use `build` directory instead of `build2` - run: cp ./build.tgz ./build2.tgz @@ -230,14 +217,8 @@ workflows: branches: ignore: - builds/facebook-www - - scrape_warning_messages: - filters: - branches: - ignore: - - builds/facebook-www - process_artifacts_combined: requires: - - scrape_warning_messages - yarn_build devtools_regression_tests: