From 101ea9f55cb4d5c671102bc49a45535af73c02b0 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Mon, 14 Jun 2021 20:10:24 +0100 Subject: [PATCH] Set deletedTreeCleanUpLevel to 3 (#21679) --- packages/shared/ReactFeatureFlags.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-fb.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-oss.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.js | 2 +- .../shared/forks/ReactFeatureFlags.test-renderer.native.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.www.js | 2 +- packages/shared/forks/ReactFeatureFlags.testing.js | 2 +- packages/shared/forks/ReactFeatureFlags.testing.www.js | 2 +- packages/shared/forks/ReactFeatureFlags.www.js | 3 ++- 9 files changed, 10 insertions(+), 9 deletions(-) diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js index d9ea72340c220..60efb97e42017 100644 --- a/packages/shared/ReactFeatureFlags.js +++ b/packages/shared/ReactFeatureFlags.js @@ -123,7 +123,7 @@ export const skipUnmountedBoundaries = false; // // It's an enum so that we can experiment with different levels of // aggressiveness. -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; // Destroy layout effects for components that are hidden because something suspended in an update // and recreate them when they are shown again (after the suspended boundary has resolved). diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index 2fc1faa80ce7b..a58e9e543895f 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -46,7 +46,7 @@ export const enableLegacyFBSupport = false; export const enableFilterEmptyStringAttributesDOM = false; export const disableNativeComponentFrames = false; export const skipUnmountedBoundaries = false; -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js index 28bd6d0e07a3d..1fc0969a3fa90 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-oss.js +++ b/packages/shared/forks/ReactFeatureFlags.native-oss.js @@ -45,7 +45,7 @@ export const enableLegacyFBSupport = false; export const enableFilterEmptyStringAttributesDOM = false; export const disableNativeComponentFrames = false; export const skipUnmountedBoundaries = false; -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.js index 4dc6686c61ca9..fe3abe658bdd4 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.js @@ -45,7 +45,7 @@ export const enableLegacyFBSupport = false; export const enableFilterEmptyStringAttributesDOM = false; export const disableNativeComponentFrames = false; export const skipUnmountedBoundaries = false; -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js index 600eb80153301..bdf3607a1ee82 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js @@ -45,7 +45,7 @@ export const enableLegacyFBSupport = false; export const enableFilterEmptyStringAttributesDOM = false; export const disableNativeComponentFrames = false; export const skipUnmountedBoundaries = false; -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js index 506c778765a6a..a4f209a6b9f30 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js @@ -45,7 +45,7 @@ export const enableLegacyFBSupport = false; export const enableFilterEmptyStringAttributesDOM = false; export const disableNativeComponentFrames = false; export const skipUnmountedBoundaries = false; -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; diff --git a/packages/shared/forks/ReactFeatureFlags.testing.js b/packages/shared/forks/ReactFeatureFlags.testing.js index 0556a6e49489a..5c8baa8a12049 100644 --- a/packages/shared/forks/ReactFeatureFlags.testing.js +++ b/packages/shared/forks/ReactFeatureFlags.testing.js @@ -45,7 +45,7 @@ export const enableLegacyFBSupport = false; export const enableFilterEmptyStringAttributesDOM = false; export const disableNativeComponentFrames = false; export const skipUnmountedBoundaries = false; -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; diff --git a/packages/shared/forks/ReactFeatureFlags.testing.www.js b/packages/shared/forks/ReactFeatureFlags.testing.www.js index 06cc9bed8ffac..30cf572ddce21 100644 --- a/packages/shared/forks/ReactFeatureFlags.testing.www.js +++ b/packages/shared/forks/ReactFeatureFlags.testing.www.js @@ -45,7 +45,7 @@ export const enableLegacyFBSupport = !__EXPERIMENTAL__; export const enableFilterEmptyStringAttributesDOM = false; export const disableNativeComponentFrames = false; export const skipUnmountedBoundaries = true; -export const deletedTreeCleanUpLevel = 1; +export const deletedTreeCleanUpLevel = 3; export const enableSuspenseLayoutEffectSemantics = false; export const enableNewReconciler = false; diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js index a5972151b79a1..04abc20de6464 100644 --- a/packages/shared/forks/ReactFeatureFlags.www.js +++ b/packages/shared/forks/ReactFeatureFlags.www.js @@ -31,7 +31,6 @@ export const { disableNativeComponentFrames, disableSchedulerTimeoutInWorkLoop, enableLazyContextPropagation, - deletedTreeCleanUpLevel, enableSyncDefaultUpdates, } = dynamicFeatureFlags; @@ -95,6 +94,8 @@ export const enableRecursiveCommitTraversal = false; export const allowConcurrentByDefault = true; +export const deletedTreeCleanUpLevel = 3; + // Flow magic to verify the exports of this file match the original version. // eslint-disable-next-line no-unused-vars type Check<_X, Y: _X, X: Y = _X> = null;