;
- var html = ReactDOMServer.renderToString(div);
+ const div = ;
+ const html = ReactDOMServer.renderToString(div);
expect(html).toContain('"left:0;margin:16px;opacity:0.5;padding:4px"');
});
it('should trim values', () => {
- var styles = {
+ const styles = {
left: '16 ',
opacity: 0.5,
right: ' 4 ',
};
- var div = ;
- var html = ReactDOMServer.renderToString(div);
+ const div = ;
+ const html = ReactDOMServer.renderToString(div);
expect(html).toContain('"left:16;opacity:0.5;right:4"');
});
it('should not append `px` to styles that might need a number', () => {
- var styles = {
+ const styles = {
flex: 0,
opacity: 0.5,
};
- var div = ;
- var html = ReactDOMServer.renderToString(div);
+ const div = ;
+ const html = ReactDOMServer.renderToString(div);
expect(html).toContain('"flex:0;opacity:0.5"');
});
it('should create vendor-prefixed markup correctly', () => {
- var styles = {
+ const styles = {
msTransition: 'none',
MozTransition: 'none',
};
- var div = ;
- var html = ReactDOMServer.renderToString(div);
+ const div = ;
+ const html = ReactDOMServer.renderToString(div);
expect(html).toContain('"-ms-transition:none;-moz-transition:none"');
});
it('should set style attribute when styles exist', () => {
- var styles = {
+ const styles = {
backgroundColor: '#000',
display: 'none',
};
- var div = ;
- var root = document.createElement('div');
+ let div = ;
+ const root = document.createElement('div');
div = ReactDOM.render(div, root);
expect(/style=".*"/.test(root.innerHTML)).toBe(true);
});
it('should not set style attribute when no styles exist', () => {
- var styles = {
+ const styles = {
backgroundColor: null,
display: null,
};
- var div = ;
- var html = ReactDOMServer.renderToString(div);
+ const div = ;
+ const html = ReactDOMServer.renderToString(div);
expect(/style=/.test(html)).toBe(false);
});
@@ -92,7 +92,7 @@ describe('CSSPropertyOperations', () => {
}
spyOnDev(console, 'error');
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
if (__DEV__) {
expect(console.error.calls.count()).toBe(1);
@@ -114,11 +114,11 @@ describe('CSSPropertyOperations', () => {
}
spyOnDev(console, 'error');
- var styles = {
+ const styles = {
'-ms-transform': 'translate3d(0, 0, 0)',
'-webkit-transform': 'translate3d(0, 0, 0)',
};
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
ReactDOM.render(, root);
@@ -155,7 +155,7 @@ describe('CSSPropertyOperations', () => {
}
spyOnDev(console, 'error');
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
if (__DEV__) {
// msTransform is correct already and shouldn't warn
@@ -194,7 +194,7 @@ describe('CSSPropertyOperations', () => {
}
spyOnDev(console, 'error');
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
if (__DEV__) {
expect(console.error.calls.count()).toBe(2);
@@ -223,7 +223,7 @@ describe('CSSPropertyOperations', () => {
}
spyOnDev(console, 'error');
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
if (__DEV__) {
@@ -243,7 +243,7 @@ describe('CSSPropertyOperations', () => {
}
}
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
});
@@ -257,7 +257,7 @@ describe('CSSPropertyOperations', () => {
}
spyOnDev(console, 'error');
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
if (__DEV__) {
@@ -277,7 +277,7 @@ describe('CSSPropertyOperations', () => {
}
}
- var root = document.createElement('div');
+ const root = document.createElement('div');
ReactDOM.render(, root);
expect(root.children[0].style.Foo).toEqual('5');
diff --git a/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js b/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js
index 7c5358831446a..8cdf53f1c4ba8 100644
--- a/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js
+++ b/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js
@@ -10,8 +10,8 @@
'use strict';
describe('DOMPropertyOperations', () => {
- var React;
- var ReactDOM;
+ let React;
+ let ReactDOM;
beforeEach(() => {
jest.resetModules();
@@ -21,20 +21,20 @@ describe('DOMPropertyOperations', () => {
describe('setValueForProperty', () => {
it('should set values as properties by default', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.title).toBe('Tip!');
});
it('should set values as attributes if necessary', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.getAttribute('role')).toBe('#');
expect(container.firstChild.role).toBeUndefined();
});
it('should set values as namespace attributes if necessary', () => {
- var container = document.createElement('svg');
+ const container = document.createElement('svg');
ReactDOM.render(, container);
expect(
container.firstChild.getAttributeNS(
@@ -45,7 +45,7 @@ describe('DOMPropertyOperations', () => {
});
it('should set values as boolean properties', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.getAttribute('disabled')).toBe('');
ReactDOM.render(, container);
@@ -63,32 +63,32 @@ describe('DOMPropertyOperations', () => {
it('should convert attribute values to string first', () => {
// Browsers default to this behavior, but some test environments do not.
// This ensures that we have consistent behavior.
- var obj = {
+ const obj = {
toString: function() {
return 'css-class';
},
};
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.getAttribute('class')).toBe('css-class');
});
it('should not remove empty attributes for special properties', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.getAttribute('value')).toBe('');
expect(container.firstChild.value).toBe('');
});
it('should remove for falsey boolean properties', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
});
it('should remove when setting custom attr to null', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.hasAttribute('data-foo')).toBe(true);
ReactDOM.render(, container);
@@ -96,7 +96,7 @@ describe('DOMPropertyOperations', () => {
});
it('should set className to empty string instead of null', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.className).toBe('selected');
ReactDOM.render(, container);
@@ -107,7 +107,7 @@ describe('DOMPropertyOperations', () => {
});
it('should remove property properly for boolean properties', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.hasAttribute('hidden')).toBe(true);
ReactDOM.render(, container);
@@ -117,7 +117,7 @@ describe('DOMPropertyOperations', () => {
describe('value mutation method', function() {
it('should update an empty attribute to zero', function() {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(
,
container,
@@ -131,7 +131,7 @@ describe('DOMPropertyOperations', () => {
});
it('should always assign the value attribute for non-inputs', function() {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
spyOnDevAndProd(container.firstChild, 'setAttribute');
ReactDOM.render(, container);
@@ -142,7 +142,7 @@ describe('DOMPropertyOperations', () => {
describe('deleteValueForProperty', () => {
it('should remove attributes for normal properties', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.firstChild.getAttribute('title')).toBe('foo');
ReactDOM.render(, container);
@@ -150,7 +150,7 @@ describe('DOMPropertyOperations', () => {
});
it('should not remove attributes for special properties', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
spyOnDev(console, 'error');
ReactDOM.render(
,
diff --git a/packages/react-dom/src/__tests__/EventPluginHub-test.js b/packages/react-dom/src/__tests__/EventPluginHub-test.js
index ec1f83d0ee821..3fb1aa72c4501 100644
--- a/packages/react-dom/src/__tests__/EventPluginHub-test.js
+++ b/packages/react-dom/src/__tests__/EventPluginHub-test.js
@@ -12,8 +12,8 @@
jest.mock('../events/isEventSupported');
describe('EventPluginHub', () => {
- var React;
- var ReactTestUtils;
+ let React;
+ let ReactTestUtils;
beforeEach(() => {
jest.resetModules();
@@ -23,7 +23,7 @@ describe('EventPluginHub', () => {
it('should prevent non-function listeners, at dispatch', () => {
spyOnDev(console, 'error');
- var node = ReactTestUtils.renderIntoDocument(
+ const node = ReactTestUtils.renderIntoDocument(
,
);
expect(function() {
@@ -40,7 +40,7 @@ describe('EventPluginHub', () => {
});
it('should not prevent null listeners, at dispatch', () => {
- var node = ReactTestUtils.renderIntoDocument();
+ const node = ReactTestUtils.renderIntoDocument();
expect(function() {
ReactTestUtils.SimulateNative.click(node);
}).not.toThrow();
diff --git a/packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.internal.js b/packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.internal.js
index ddbd8fa95ef55..e590851146416 100644
--- a/packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.internal.js
+++ b/packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.internal.js
@@ -9,42 +9,42 @@
'use strict';
-var EventPluginHub;
-var EventPluginRegistry;
-var React;
-var ReactDOM;
-var ReactDOMComponentTree;
-var ReactBrowserEventEmitter;
-var ReactTestUtils;
-
-var idCallOrder;
-var recordID = function(id) {
+let EventPluginHub;
+let EventPluginRegistry;
+let React;
+let ReactDOM;
+let ReactDOMComponentTree;
+let ReactBrowserEventEmitter;
+let ReactTestUtils;
+
+let idCallOrder;
+const recordID = function(id) {
idCallOrder.push(id);
};
-var recordIDAndStopPropagation = function(id, event) {
+const recordIDAndStopPropagation = function(id, event) {
recordID(id);
event.stopPropagation();
};
-var recordIDAndReturnFalse = function(id, event) {
+const recordIDAndReturnFalse = function(id, event) {
recordID(id);
return false;
};
-var LISTENER = jest.fn();
-var ON_CLICK_KEY = 'onClick';
-var ON_CHANGE_KEY = 'onChange';
-var ON_MOUSE_ENTER_KEY = 'onMouseEnter';
+const LISTENER = jest.fn();
+const ON_CLICK_KEY = 'onClick';
+const ON_CHANGE_KEY = 'onChange';
+const ON_MOUSE_ENTER_KEY = 'onMouseEnter';
-var GRANDPARENT;
-var PARENT;
-var CHILD;
+let GRANDPARENT;
+let PARENT;
+let CHILD;
-var getListener;
-var putListener;
-var deleteAllListeners;
+let getListener;
+let putListener;
+let deleteAllListeners;
function registerSimpleTestHandler() {
putListener(CHILD, ON_CLICK_KEY, LISTENER);
- var listener = getListener(CHILD, ON_CLICK_KEY);
+ const listener = getListener(CHILD, ON_CLICK_KEY);
expect(listener).toEqual(LISTENER);
return getListener(CHILD, ON_CLICK_KEY);
}
@@ -63,11 +63,11 @@ describe('ReactBrowserEventEmitter', () => {
ReactBrowserEventEmitter = require('../events/ReactBrowserEventEmitter');
ReactTestUtils = require('react-dom/test-utils');
- var container = document.createElement('div');
+ const container = document.createElement('div');
- var GRANDPARENT_PROPS = {};
- var PARENT_PROPS = {};
- var CHILD_PROPS = {};
+ let GRANDPARENT_PROPS = {};
+ let PARENT_PROPS = {};
+ let CHILD_PROPS = {};
function Child(props) {
return
(CHILD = c)} {...props} />;
@@ -93,7 +93,7 @@ describe('ReactBrowserEventEmitter', () => {
renderTree();
getListener = function(node, eventName) {
- var inst = ReactDOMComponentTree.getInstanceFromNode(node);
+ const inst = ReactDOMComponentTree.getInstanceFromNode(node);
return EventPluginHub.getListener(inst, eventName);
};
putListener = function(node, eventName, listener) {
@@ -131,20 +131,20 @@ describe('ReactBrowserEventEmitter', () => {
it('should store a listener correctly', () => {
registerSimpleTestHandler();
- var listener = getListener(CHILD, ON_CLICK_KEY);
+ const listener = getListener(CHILD, ON_CLICK_KEY);
expect(listener).toBe(LISTENER);
});
it('should retrieve a listener correctly', () => {
registerSimpleTestHandler();
- var listener = getListener(CHILD, ON_CLICK_KEY);
+ const listener = getListener(CHILD, ON_CLICK_KEY);
expect(listener).toEqual(LISTENER);
});
it('should clear all handlers when asked to', () => {
registerSimpleTestHandler();
deleteAllListeners(CHILD);
- var listener = getListener(CHILD, ON_CLICK_KEY);
+ const listener = getListener(CHILD, ON_CLICK_KEY);
expect(listener).toBe(undefined);
});
@@ -298,8 +298,8 @@ describe('ReactBrowserEventEmitter', () => {
*/
it('should invoke handlers that were removed while bubbling', () => {
- var handleParentClick = jest.fn();
- var handleChildClick = function(event) {
+ const handleParentClick = jest.fn();
+ const handleChildClick = function(event) {
deleteAllListeners(PARENT);
};
putListener(CHILD, ON_CLICK_KEY, handleChildClick);
@@ -309,8 +309,8 @@ describe('ReactBrowserEventEmitter', () => {
});
it('should not invoke newly inserted handlers while bubbling', () => {
- var handleParentClick = jest.fn();
- var handleChildClick = function(event) {
+ const handleParentClick = jest.fn();
+ const handleChildClick = function(event) {
putListener(PARENT, ON_CLICK_KEY, handleParentClick);
};
putListener(CHILD, ON_CLICK_KEY, handleChildClick);
@@ -347,17 +347,17 @@ describe('ReactBrowserEventEmitter', () => {
ReactBrowserEventEmitter.listenTo(ON_CHANGE_KEY, document);
- var setEventListeners = [];
- var listenCalls = EventTarget.prototype.addEventListener.calls.allArgs();
- for (var i = 0; i < listenCalls.length; i++) {
+ const setEventListeners = [];
+ const listenCalls = EventTarget.prototype.addEventListener.calls.allArgs();
+ for (let i = 0; i < listenCalls.length; i++) {
setEventListeners.push(listenCalls[i][1]);
}
- var module = EventPluginRegistry.registrationNameModules[ON_CHANGE_KEY];
- var dependencies = module.eventTypes.change.dependencies;
+ const module = EventPluginRegistry.registrationNameModules[ON_CHANGE_KEY];
+ const dependencies = module.eventTypes.change.dependencies;
expect(setEventListeners.length).toEqual(dependencies.length);
- for (i = 0; i < setEventListeners.length; i++) {
+ for (let i = 0; i < setEventListeners.length; i++) {
expect(dependencies.indexOf(setEventListeners[i])).toBeTruthy();
}
});
diff --git a/packages/react-dom/src/__tests__/ReactChildReconciler-test.js b/packages/react-dom/src/__tests__/ReactChildReconciler-test.js
index 9bbf9176cf69a..ebc03fa0ff99a 100644
--- a/packages/react-dom/src/__tests__/ReactChildReconciler-test.js
+++ b/packages/react-dom/src/__tests__/ReactChildReconciler-test.js
@@ -12,8 +12,8 @@
'use strict';
-var React;
-var ReactTestUtils;
+let React;
+let ReactTestUtils;
describe('ReactChildReconciler', () => {
function normalizeCodeLocInfo(str) {
@@ -30,7 +30,7 @@ describe('ReactChildReconciler', () => {
function createIterable(array) {
return {
'@@iterator': function() {
- var i = 0;
+ let i = 0;
return {
next() {
const next = {
diff --git a/packages/react-dom/src/__tests__/ReactComponent-test.js b/packages/react-dom/src/__tests__/ReactComponent-test.js
index 1f7da05821317..a0a8fde8b8661 100644
--- a/packages/react-dom/src/__tests__/ReactComponent-test.js
+++ b/packages/react-dom/src/__tests__/ReactComponent-test.js
@@ -9,10 +9,10 @@
'use strict';
-var React;
-var ReactDOM;
-var ReactDOMServer;
-var ReactTestUtils;
+let React;
+let ReactDOM;
+let ReactDOMServer;
+let ReactTestUtils;
describe('ReactComponent', () => {
function normalizeCodeLocInfo(str) {
@@ -27,7 +27,7 @@ describe('ReactComponent', () => {
});
it('should throw on invalid render targets', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
// jQuery objects are basically arrays; people often pass them in by mistake
expect(function() {
ReactDOM.render(, [container]);
@@ -39,7 +39,7 @@ describe('ReactComponent', () => {
});
it('should throw when supplying a ref outside of render method', () => {
- var instance = ;
+ let instance = ;
expect(function() {
instance = ReactTestUtils.renderIntoDocument(instance);
}).toThrow();
@@ -108,8 +108,8 @@ describe('ReactComponent', () => {
});
it('should support refs on owned components', () => {
- var innerObj = {};
- var outerObj = {};
+ const innerObj = {};
+ const outerObj = {};
class Wrapper extends React.Component {
getObject = () => {
@@ -123,8 +123,8 @@ describe('ReactComponent', () => {
class Component extends React.Component {
render() {
- var inner = ;
- var outer = (
+ const inner = ;
+ const outer = (
{inner}
@@ -166,8 +166,8 @@ describe('ReactComponent', () => {
});
it('should support new-style refs', () => {
- var innerObj = {};
- var outerObj = {};
+ const innerObj = {};
+ const outerObj = {};
class Wrapper extends React.Component {
getObject = () => {
@@ -179,14 +179,14 @@ describe('ReactComponent', () => {
}
}
- var mounted = false;
+ let mounted = false;
class Component extends React.Component {
render() {
- var inner = (
+ const inner = (
(this.innerRef = c)} />
);
- var outer = (
+ const outer = (
(this.outerRef = c)}>
{inner}
@@ -216,7 +216,7 @@ describe('ReactComponent', () => {
}
}
- var mounted = false;
+ let mounted = false;
class Component extends React.Component {
getInner = () => {
@@ -248,7 +248,7 @@ describe('ReactComponent', () => {
});
it('should call refs at the correct time', () => {
- var log = [];
+ const log = [];
class Inner extends React.Component {
render() {
@@ -303,7 +303,7 @@ describe('ReactComponent', () => {
}
// mount, update, unmount
- var el = document.createElement('div');
+ const el = document.createElement('div');
log.push('start mount');
ReactDOM.render(, el);
log.push('start update');
@@ -344,8 +344,8 @@ describe('ReactComponent', () => {
});
it('fires the callback after a component is rendered', () => {
- var callback = jest.fn();
- var container = document.createElement('div');
+ const callback = jest.fn();
+ const container = document.createElement('div');
ReactDOM.render(, container, callback);
expect(callback.mock.calls.length).toBe(1);
ReactDOM.render(, container, callback);
@@ -357,7 +357,7 @@ describe('ReactComponent', () => {
it('throws usefully when rendering badly-typed elements', () => {
spyOnDev(console, 'error');
- var X = undefined;
+ const X = undefined;
expect(() => ReactTestUtils.renderIntoDocument()).toThrowError(
'Element type is invalid: expected a string (for built-in components) ' +
'or a class/function (for composite components) but got: undefined.' +
@@ -367,7 +367,7 @@ describe('ReactComponent', () => {
: ''),
);
- var Y = null;
+ const Y = null;
expect(() => ReactTestUtils.renderIntoDocument()).toThrowError(
'Element type is invalid: expected a string (for built-in components) ' +
'or a class/function (for composite components) but got: null.',
@@ -382,7 +382,7 @@ describe('ReactComponent', () => {
it('includes owner name in the error about badly-typed elements', () => {
spyOnDev(console, 'error');
- var X = undefined;
+ const X = undefined;
function Indirection(props) {
return
{props.children}
;
@@ -417,14 +417,14 @@ describe('ReactComponent', () => {
});
it('throws if a plain object is used as a child', () => {
- var children = {
+ const children = {
x: ,
y: ,
z: ,
};
- var element =
{[children]}
;
- var container = document.createElement('div');
- var ex;
+ const element =
{[children]}
;
+ const container = document.createElement('div');
+ let ex;
try {
ReactDOM.render(element, container);
} catch (e) {
@@ -444,7 +444,7 @@ describe('ReactComponent', () => {
it('throws if a plain object even if it is in an owner', () => {
class Foo extends React.Component {
render() {
- var children = {
+ const children = {
a: ,
b: ,
c: ,
@@ -452,8 +452,8 @@ describe('ReactComponent', () => {
return
{[children]}
;
}
}
- var container = document.createElement('div');
- var ex;
+ const container = document.createElement('div');
+ let ex;
try {
ReactDOM.render(, container);
} catch (e) {
@@ -472,13 +472,13 @@ describe('ReactComponent', () => {
});
it('throws if a plain object is used as a child when using SSR', async () => {
- var children = {
+ const children = {
x: ,
y: ,
z: ,
};
- var element =
{[children]}
;
- var ex;
+ const element =
{[children]}
;
+ let ex;
try {
ReactDOMServer.renderToString(element);
} catch (e) {
@@ -498,7 +498,7 @@ describe('ReactComponent', () => {
it('throws if a plain object even if it is in an owner when using SSR', async () => {
class Foo extends React.Component {
render() {
- var children = {
+ const children = {
a: ,
b: ,
c: ,
@@ -506,8 +506,8 @@ describe('ReactComponent', () => {
return
{[children]}
;
}
}
- var container = document.createElement('div');
- var ex;
+ const container = document.createElement('div');
+ let ex;
try {
ReactDOMServer.renderToString(, container);
} catch (e) {
@@ -531,7 +531,7 @@ describe('ReactComponent', () => {
return Foo;
}
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
if (__DEV__) {
expect(console.error.calls.count()).toBe(1);
@@ -551,7 +551,7 @@ describe('ReactComponent', () => {
}
}
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
if (__DEV__) {
expect(console.error.calls.count()).toBe(1);
@@ -573,7 +573,7 @@ describe('ReactComponent', () => {
);
}
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
if (__DEV__) {
expect(console.error.calls.count()).toBe(1);
@@ -595,7 +595,7 @@ describe('ReactComponent', () => {
function Foo() {
return {() => 'Hello'};
}
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
expect(container.innerHTML).toBe('Hello');
});
@@ -620,8 +620,8 @@ describe('ReactComponent', () => {
);
}
}
- var container = document.createElement('div');
- var component = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const component = ReactDOM.render(, container);
component.setState({type: 'portobello mushrooms'});
if (__DEV__) {
expect(console.error.calls.count()).toBe(2);
diff --git a/packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js b/packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
index 4da75f8629121..33730716ac1e2 100644
--- a/packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
+++ b/packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
@@ -9,51 +9,51 @@
'use strict';
-var React;
-var ReactDOM;
-var ReactTestUtils;
-var PropTypes;
+let React;
+let ReactDOM;
+let ReactTestUtils;
+let PropTypes;
-var clone = function(o) {
+const clone = function(o) {
return JSON.parse(JSON.stringify(o));
};
-var GET_INIT_STATE_RETURN_VAL = {
+const GET_INIT_STATE_RETURN_VAL = {
hasWillMountCompleted: false,
hasRenderCompleted: false,
hasDidMountCompleted: false,
hasWillUnmountCompleted: false,
};
-var INIT_RENDER_STATE = {
+const INIT_RENDER_STATE = {
hasWillMountCompleted: true,
hasRenderCompleted: false,
hasDidMountCompleted: false,
hasWillUnmountCompleted: false,
};
-var DID_MOUNT_STATE = {
+const DID_MOUNT_STATE = {
hasWillMountCompleted: true,
hasRenderCompleted: true,
hasDidMountCompleted: false,
hasWillUnmountCompleted: false,
};
-var NEXT_RENDER_STATE = {
+const NEXT_RENDER_STATE = {
hasWillMountCompleted: true,
hasRenderCompleted: true,
hasDidMountCompleted: true,
hasWillUnmountCompleted: false,
};
-var WILL_UNMOUNT_STATE = {
+const WILL_UNMOUNT_STATE = {
hasWillMountCompleted: true,
hasDidMountCompleted: true,
hasRenderCompleted: true,
hasWillUnmountCompleted: false,
};
-var POST_WILL_UNMOUNT_STATE = {
+const POST_WILL_UNMOUNT_STATE = {
hasWillMountCompleted: true,
hasDidMountCompleted: true,
hasRenderCompleted: true,
@@ -94,7 +94,7 @@ describe('ReactComponentLifeCycle', () => {
});
it('should not reuse an instance when it has been unmounted', () => {
- var container = document.createElement('div');
+ const container = document.createElement('div');
class StatefulComponent extends React.Component {
state = {};
@@ -104,10 +104,10 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var element = ;
- var firstInstance = ReactDOM.render(element, container);
+ const element = ;
+ const firstInstance = ReactDOM.render(element, container);
ReactDOM.unmountComponentAtNode(container);
- var secondInstance = ReactDOM.render(element, container);
+ const secondInstance = ReactDOM.render(element, container);
expect(firstInstance).not.toBe(secondInstance);
});
@@ -116,7 +116,7 @@ describe('ReactComponentLifeCycle', () => {
* that second onDOMReady should not fail.
*/
it('it should fire onDOMReady when already in onDOMReady', () => {
- var _testJournal = [];
+ const _testJournal = [];
class Child extends React.Component {
componentDidMount() {
@@ -174,7 +174,7 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var instance = ;
+ let instance = ;
expect(function() {
instance = ReactTestUtils.renderIntoDocument(instance);
}).toThrow();
@@ -191,7 +191,7 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var instance = ;
+ let instance = ;
expect(function() {
instance = ReactTestUtils.renderIntoDocument(instance);
}).not.toThrow();
@@ -251,9 +251,9 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var element = ;
+ const element = ;
- var instance = ReactTestUtils.renderIntoDocument(element);
+ const instance = ReactTestUtils.renderIntoDocument(element);
expect(instance._isMounted()).toBeTruthy();
if (__DEV__) {
@@ -284,9 +284,9 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var element = ;
+ const element = ;
- var instance = ReactTestUtils.renderIntoDocument(element);
+ const instance = ReactTestUtils.renderIntoDocument(element);
expect(instance._isMounted()).toBeTruthy();
if (__DEV__) {
@@ -304,8 +304,8 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var container = document.createElement('div');
- var instance = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const instance = ReactDOM.render(, container);
// No longer a public API, but we can test that it works internally by
// reaching into the updater.
@@ -347,7 +347,7 @@ describe('ReactComponentLifeCycle', () => {
constructor(props, context) {
super(props, context);
this._testJournal = {};
- var initState = {
+ const initState = {
hasWillMountCompleted: false,
hasDidMountCompleted: false,
hasRenderCompleted: false,
@@ -373,7 +373,7 @@ describe('ReactComponentLifeCycle', () => {
}
render() {
- var isInitialRender = !this.state.hasRenderCompleted;
+ const isInitialRender = !this.state.hasRenderCompleted;
if (isInitialRender) {
this._testJournal.stateInInitialRender = clone(this.state);
this._testJournal.lifeCycleInInitialRender = getLifeCycleState(this);
@@ -398,8 +398,8 @@ describe('ReactComponentLifeCycle', () => {
// A component that is merely "constructed" (as in "constructor") but not
// yet initialized, or rendered.
//
- var container = document.createElement('div');
- var instance = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const instance = ReactDOM.render(, container);
// getInitialState
expect(instance._testJournal.returnedFromGetInitialState).toEqual(
@@ -490,7 +490,7 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
// Since `instance` is a root component, we can set its props. This also
@@ -516,7 +516,7 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var instance = (
+ let instance = (
{
});
it('should call nested lifecycle methods in the right order', () => {
- var log;
- var logger = function(msg) {
+ let log;
+ const logger = function(msg) {
return function() {
// return true for shouldComponentUpdate
log.push(msg);
@@ -565,7 +565,7 @@ describe('ReactComponentLifeCycle', () => {
}
}
- var container = document.createElement('div');
+ const container = document.createElement('div');
log = [];
ReactDOM.render(, container);
expect(log).toEqual([
diff --git a/packages/react-dom/src/__tests__/ReactCompositeComponent-test.js b/packages/react-dom/src/__tests__/ReactCompositeComponent-test.js
index 1bac93ec046c1..3ae6384dbbcc4 100644
--- a/packages/react-dom/src/__tests__/ReactCompositeComponent-test.js
+++ b/packages/react-dom/src/__tests__/ReactCompositeComponent-test.js
@@ -9,16 +9,16 @@
'use strict';
-var ChildUpdates;
-var MorphingComponent;
-var React;
-var ReactDOM;
-var ReactDOMServer;
-var ReactCurrentOwner;
-var ReactTestUtils;
-var PropTypes;
-var shallowEqual;
-var shallowCompare;
+let ChildUpdates;
+let MorphingComponent;
+let React;
+let ReactDOM;
+let ReactDOMServer;
+let ReactCurrentOwner;
+let ReactTestUtils;
+let PropTypes;
+let shallowEqual;
+let shallowCompare;
describe('ReactCompositeComponent', () => {
beforeEach(() => {
@@ -47,7 +47,7 @@ describe('ReactCompositeComponent', () => {
};
render() {
- var toggleActivatedState = this._toggleActivatedState;
+ const toggleActivatedState = this._toggleActivatedState;
return !this.state.activated ? (
) : (
@@ -66,7 +66,7 @@ describe('ReactCompositeComponent', () => {
};
render() {
- var className = this.props.anchorClassOn ? 'anchorClass' : '';
+ const className = this.props.anchorClassOn ? 'anchorClass' : '';
return this.props.renderAnchor ? (
) : (
@@ -85,15 +85,15 @@ describe('ReactCompositeComponent', () => {
};
}
- var el = document.createElement('div');
+ const el = document.createElement('div');
ReactDOM.render(, el);
expect(el.textContent).toBe('test');
});
it('should support rendering to different child types over time', () => {
- var instance = ReactTestUtils.renderIntoDocument();
- var el = ReactDOM.findDOMNode(instance);
+ const instance = ReactTestUtils.renderIntoDocument();
+ let el = ReactDOM.findDOMNode(instance);
expect(el.tagName).toBe('A');
instance._toggleActivatedState();
@@ -123,10 +123,10 @@ describe('ReactCompositeComponent', () => {
}
spyOnDev(console, 'warn');
- var markup = ReactDOMServer.renderToString();
+ const markup = ReactDOMServer.renderToString();
// Old API based on heuristic
- var container = document.createElement('div');
+ let container = document.createElement('div');
container.innerHTML = markup;
ReactDOM.render(, container);
if (__DEV__) {
@@ -148,8 +148,8 @@ describe('ReactCompositeComponent', () => {
});
it('should react to state changes from callbacks', () => {
- var instance = ReactTestUtils.renderIntoDocument();
- var el = ReactDOM.findDOMNode(instance);
+ const instance = ReactTestUtils.renderIntoDocument();
+ let el = ReactDOM.findDOMNode(instance);
expect(el.tagName).toBe('A');
ReactTestUtils.Simulate.click(el);
@@ -158,7 +158,7 @@ describe('ReactCompositeComponent', () => {
});
it('should rewire refs when rendering to different child types', () => {
- var instance = ReactTestUtils.renderIntoDocument();
+ const instance = ReactTestUtils.renderIntoDocument();
expect(ReactDOM.findDOMNode(instance.refs.x).tagName).toBe('A');
instance._toggleActivatedState();
@@ -168,8 +168,8 @@ describe('ReactCompositeComponent', () => {
});
it('should not cache old DOM nodes when switching constructors', () => {
- var container = document.createElement('div');
- var instance = ReactDOM.render(
+ const container = document.createElement('div');
+ const instance = ReactDOM.render(
,
container,
);
@@ -200,15 +200,15 @@ describe('ReactCompositeComponent', () => {
}
}
- var instance1 = ReactTestUtils.renderIntoDocument();
+ const instance1 = ReactTestUtils.renderIntoDocument();
expect(instance1.props).toEqual({prop: 'testKey'});
- var instance2 = ReactTestUtils.renderIntoDocument(
+ const instance2 = ReactTestUtils.renderIntoDocument(
,
);
expect(instance2.props).toEqual({prop: 'testKey'});
- var instance3 = ReactTestUtils.renderIntoDocument(
+ const instance3 = ReactTestUtils.renderIntoDocument(
,
);
expect(instance3.props).toEqual({prop: null});
@@ -223,8 +223,8 @@ describe('ReactCompositeComponent', () => {
}
}
- var inputProps = {};
- var instance1 = ;
+ const inputProps = {};
+ let instance1 = ;
instance1 = ReactTestUtils.renderIntoDocument(instance1);
expect(instance1.props.prop).toBe('testKey');
@@ -236,7 +236,7 @@ describe('ReactCompositeComponent', () => {
it('should warn about `forceUpdate` on unmounted components', () => {
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
document.body.appendChild(container);
class Component extends React.Component {
@@ -245,7 +245,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var instance = ;
+ let instance = ;
expect(instance.forceUpdate).not.toBeDefined();
instance = ReactDOM.render(instance, container);
@@ -277,10 +277,10 @@ describe('ReactCompositeComponent', () => {
it('should warn about `setState` on unmounted components', () => {
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
document.body.appendChild(container);
- var renders = 0;
+ let renders = 0;
class Component extends React.Component {
state = {value: 0};
@@ -291,7 +291,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var instance = ;
+ let instance = ;
expect(instance.setState).not.toBeDefined();
instance = ReactDOM.render(instance, container);
@@ -323,8 +323,8 @@ describe('ReactCompositeComponent', () => {
});
it('should silently allow `setState`, not call cb on unmounting components', () => {
- var cbCalled = false;
- var container = document.createElement('div');
+ let cbCalled = false;
+ const container = document.createElement('div');
document.body.appendChild(container);
class Component extends React.Component {
@@ -343,7 +343,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var instance = ReactDOM.render(, container);
+ const instance = ReactDOM.render(, container);
instance.setState({value: 1});
ReactDOM.unmountComponentAtNode(container);
@@ -352,7 +352,7 @@ describe('ReactCompositeComponent', () => {
it('should warn when rendering a class with a render method that does not extend React.Component', () => {
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
class ClassWithRenderNotExtended {
render() {
return ;
@@ -377,10 +377,10 @@ describe('ReactCompositeComponent', () => {
it('should warn about `setState` in render', () => {
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
- var renderedState = -1;
- var renderPasses = 0;
+ let renderedState = -1;
+ let renderPasses = 0;
class Component extends React.Component {
state = {value: 0};
@@ -399,7 +399,7 @@ describe('ReactCompositeComponent', () => {
expect(console.error.calls.count()).toBe(0);
}
- var instance = ReactDOM.render(, container);
+ const instance = ReactDOM.render(, container);
if (__DEV__) {
expect(console.error.calls.count()).toBe(1);
@@ -419,7 +419,7 @@ describe('ReactCompositeComponent', () => {
expect(instance.state.value).toBe(1);
// Forcing a rerender anywhere will cause the update to happen.
- var instance2 = ReactDOM.render(, container);
+ const instance2 = ReactDOM.render(, container);
expect(instance).toBe(instance2);
expect(renderedState).toBe(1);
expect(instance2.state.value).toBe(1);
@@ -435,9 +435,9 @@ describe('ReactCompositeComponent', () => {
it('should warn about `setState` in getChildContext', () => {
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
- var renderPasses = 0;
+ let renderPasses = 0;
class Component extends React.Component {
state = {value: 0};
@@ -458,7 +458,7 @@ describe('ReactCompositeComponent', () => {
if (__DEV__) {
expect(console.error.calls.count()).toBe(0);
}
- var instance = ReactDOM.render(, container);
+ const instance = ReactDOM.render(, container);
expect(renderPasses).toBe(2);
expect(instance.state.value).toBe(1);
if (__DEV__) {
@@ -483,7 +483,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var instance = ;
+ let instance = ;
expect(ReactCurrentOwner.current).toBe(null);
@@ -495,8 +495,8 @@ describe('ReactCompositeComponent', () => {
});
it('should call componentWillUnmount before unmounting', () => {
- var container = document.createElement('div');
- var innerUnmounted = false;
+ const container = document.createElement('div');
+ let innerUnmounted = false;
class Component extends React.Component {
render() {
@@ -539,7 +539,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var instance = ReactTestUtils.renderIntoDocument();
+ const instance = ReactTestUtils.renderIntoDocument();
instance.setState({bogus: true});
if (__DEV__) {
@@ -661,7 +661,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var component = ReactTestUtils.renderIntoDocument();
+ const component = ReactTestUtils.renderIntoDocument();
expect(ReactDOM.findDOMNode(component).innerHTML).toBe('bar');
});
@@ -672,7 +672,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var childRenders = 0;
+ let childRenders = 0;
class Child extends React.Component {
render() {
@@ -681,8 +681,8 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
- var child = ;
+ const container = document.createElement('div');
+ const child = ;
ReactDOM.render({child}, container);
ReactDOM.render({child}, container);
@@ -690,8 +690,8 @@ describe('ReactCompositeComponent', () => {
});
it('should pass context when re-rendered for static child', () => {
- var parentInstance = null;
- var childInstance = null;
+ let parentInstance = null;
+ let childInstance = null;
class Parent extends React.Component {
static childContextTypes = {
@@ -790,7 +790,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var wrapper = ReactTestUtils.renderIntoDocument();
+ const wrapper = ReactTestUtils.renderIntoDocument();
expect(wrapper.refs.parent.state.flag).toEqual(true);
expect(wrapper.refs.child.context).toEqual({flag: true});
@@ -803,8 +803,8 @@ describe('ReactCompositeComponent', () => {
});
it('should pass context transitively', () => {
- var childInstance = null;
- var grandchildInstance = null;
+ let childInstance = null;
+ let grandchildInstance = null;
class Parent extends React.Component {
static childContextTypes = {
@@ -864,8 +864,8 @@ describe('ReactCompositeComponent', () => {
});
it('should pass context when re-rendered', () => {
- var parentInstance = null;
- var childInstance = null;
+ let parentInstance = null;
+ let childInstance = null;
class Parent extends React.Component {
static childContextTypes = {
@@ -885,7 +885,7 @@ describe('ReactCompositeComponent', () => {
}
render() {
- var output = ;
+ let output = ;
if (!this.state.flag) {
output = Child;
}
@@ -968,7 +968,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var div = document.createElement('div');
+ const div = document.createElement('div');
ReactDOM.render(, div);
expect(div.children[0].innerHTML).toBe('noise');
div.children[0].innerHTML = 'aliens';
@@ -981,8 +981,8 @@ describe('ReactCompositeComponent', () => {
});
it('should trigger componentWillReceiveProps for context changes', () => {
- var contextChanges = 0;
- var propChanges = 0;
+ let contextChanges = 0;
+ let propChanges = 0;
class GrandChild extends React.Component {
static contextTypes = {
@@ -1066,9 +1066,9 @@ describe('ReactCompositeComponent', () => {
}
}
- var div = document.createElement('div');
+ const div = document.createElement('div');
- var parentInstance = null;
+ let parentInstance = null;
ReactDOM.render(
(parentInstance = inst)}>
@@ -1121,7 +1121,7 @@ describe('ReactCompositeComponent', () => {
});
it('only renders once if updated in componentWillReceiveProps', () => {
- var renders = 0;
+ let renders = 0;
class Component extends React.Component {
state = {updated: false};
@@ -1139,8 +1139,8 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
- var instance = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const instance = ReactDOM.render(, container);
expect(renders).toBe(1);
expect(instance.state.updated).toBe(false);
ReactDOM.render(, container);
@@ -1149,7 +1149,7 @@ describe('ReactCompositeComponent', () => {
});
it('only renders once if updated in componentWillReceiveProps when batching', () => {
- var renders = 0;
+ let renders = 0;
class Component extends React.Component {
state = {updated: false};
@@ -1167,8 +1167,8 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
- var instance = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const instance = ReactDOM.render(, container);
expect(renders).toBe(1);
expect(instance.state.updated).toBe(false);
ReactDOM.unstable_batchedUpdates(() => {
@@ -1217,8 +1217,8 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
- var comp = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const comp = ReactDOM.render(, container);
expect(ReactDOM.findDOMNode(comp.refs.static0).textContent).toBe('A');
expect(ReactDOM.findDOMNode(comp.refs.static1).textContent).toBe('B');
@@ -1230,8 +1230,8 @@ describe('ReactCompositeComponent', () => {
});
it('should allow access to findDOMNode in componentWillUnmount', () => {
- var a = null;
- var b = null;
+ let a = null;
+ let b = null;
class Component extends React.Component {
componentDidMount() {
@@ -1249,7 +1249,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
+ const container = document.createElement('div');
expect(a).toBe(container.firstChild);
ReactDOM.render(, container);
ReactDOM.unmountComponentAtNode(container);
@@ -1283,7 +1283,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var div = document.createElement('div');
+ const div = document.createElement('div');
ReactDOM.render(
@@ -1300,7 +1300,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var moo = ReactTestUtils.renderIntoDocument();
+ const moo = ReactTestUtils.renderIntoDocument();
// No longer a public API, but we can test that it works internally by
// reaching into the updater.
moo.updater.enqueueReplaceState(moo, {y: 2});
@@ -1309,7 +1309,7 @@ describe('ReactCompositeComponent', () => {
});
it('should support objects with prototypes as state', () => {
- var NotActuallyImmutable = function(str) {
+ const NotActuallyImmutable = function(str) {
this.str = str;
};
NotActuallyImmutable.prototype.amIImmutable = function() {
@@ -1325,11 +1325,11 @@ describe('ReactCompositeComponent', () => {
}
}
- var moo = ReactTestUtils.renderIntoDocument();
+ const moo = ReactTestUtils.renderIntoDocument();
expect(moo.state.str).toBe('first');
expect(moo.state.amIImmutable()).toBe(true);
- var secondState = new NotActuallyImmutable('second');
+ const secondState = new NotActuallyImmutable('second');
moo._replaceState(secondState);
expect(moo.state.str).toBe('second');
expect(moo.state.amIImmutable()).toBe(true);
@@ -1341,7 +1341,7 @@ describe('ReactCompositeComponent', () => {
expect(moo.state.amIImmutable).toBe(undefined);
// When more than one state update is enqueued, we have the same behavior
- var fifthState = new NotActuallyImmutable('fifth');
+ const fifthState = new NotActuallyImmutable('fifth');
ReactDOM.unstable_batchedUpdates(function() {
moo.setState({str: 'fourth'});
moo._replaceState(fifthState);
@@ -1349,7 +1349,7 @@ describe('ReactCompositeComponent', () => {
expect(moo.state).toBe(fifthState);
// When more than one state update is enqueued, we have the same behavior
- var sixthState = new NotActuallyImmutable('sixth');
+ const sixthState = new NotActuallyImmutable('sixth');
ReactDOM.unstable_batchedUpdates(function() {
moo._replaceState(sixthState);
moo.setState({str: 'seventh'});
@@ -1359,8 +1359,8 @@ describe('ReactCompositeComponent', () => {
});
it('should not warn about unmounting during unmounting', () => {
- var container = document.createElement('div');
- var layer = document.createElement('div');
+ const container = document.createElement('div');
+ const layer = document.createElement('div');
class Component extends React.Component {
componentDidMount() {
@@ -1394,11 +1394,11 @@ describe('ReactCompositeComponent', () => {
it('should warn when mutated props are passed', () => {
spyOnDev(console, 'error');
- var container = document.createElement('div');
+ const container = document.createElement('div');
class Foo extends React.Component {
constructor(props) {
- var _props = {idx: props.idx + '!'};
+ const _props = {idx: props.idx + '!'};
super(_props);
}
@@ -1423,8 +1423,8 @@ describe('ReactCompositeComponent', () => {
});
it('should only call componentWillUnmount once', () => {
- var app;
- var count = 0;
+ let app;
+ let count = 0;
class App extends React.Component {
render() {
@@ -1448,9 +1448,9 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
+ const container = document.createElement('div');
- var setRef = ref => {
+ const setRef = ref => {
if (ref) {
app = ref;
}
@@ -1464,7 +1464,7 @@ describe('ReactCompositeComponent', () => {
});
it('prepares new child before unmounting old', () => {
- var log = [];
+ const log = [];
class Spy extends React.Component {
componentWillMount() {
@@ -1488,7 +1488,7 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
+ const container = document.createElement('div');
ReactDOM.render(, container);
ReactDOM.render(, container);
@@ -1505,7 +1505,7 @@ describe('ReactCompositeComponent', () => {
});
it('respects a shallow shouldComponentUpdate implementation', () => {
- var renderCalls = 0;
+ let renderCalls = 0;
class PlasticWrap extends React.Component {
constructor(props, context) {
super(props, context);
@@ -1548,8 +1548,8 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
- var instance = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const instance = ReactDOM.render(, container);
expect(renderCalls).toBe(1);
// Do not re-render based on props
@@ -1581,8 +1581,8 @@ describe('ReactCompositeComponent', () => {
};
}
- var renderCalls = 0;
- var initialSettings = getInitialState();
+ let renderCalls = 0;
+ const initialSettings = getInitialState();
class Component extends React.Component {
state = initialSettings;
@@ -1597,12 +1597,12 @@ describe('ReactCompositeComponent', () => {
}
}
- var container = document.createElement('div');
- var instance = ReactDOM.render(, container);
+ const container = document.createElement('div');
+ const instance = ReactDOM.render(, container);
expect(renderCalls).toBe(1);
// Do not re-render if state is equal
- var settings = {
+ const settings = {
foo: initialSettings.foo,
bar: initialSettings.bar,
};
diff --git a/packages/react-dom/src/__tests__/ReactCompositeComponentDOMMinimalism-test.js b/packages/react-dom/src/__tests__/ReactCompositeComponentDOMMinimalism-test.js
index 75ccd6cb422f9..557c9676780d2 100644
--- a/packages/react-dom/src/__tests__/ReactCompositeComponentDOMMinimalism-test.js
+++ b/packages/react-dom/src/__tests__/ReactCompositeComponentDOMMinimalism-test.js
@@ -10,15 +10,15 @@
'use strict';
// Requires
-var React;
-var ReactDOM;
-var ReactTestUtils;
+let React;
+let ReactDOM;
+let ReactTestUtils;
// Test components
-var LowerLevelComposite;
-var MyCompositeComponent;
+let LowerLevelComposite;
+let MyCompositeComponent;
-var expectSingleChildlessDiv;
+let expectSingleChildlessDiv;
/**
* Integration test, testing the combination of JSX with our unit of
@@ -44,20 +44,20 @@ describe('ReactCompositeComponentDOMMinimalism', () => {
};
expectSingleChildlessDiv = function(instance) {
- var el = ReactDOM.findDOMNode(instance);
+ const el = ReactDOM.findDOMNode(instance);
expect(el.tagName).toBe('DIV');
expect(el.children.length).toBe(0);
};
});
it('should not render extra nodes for non-interpolated text', () => {
- var instance = A string child;
+ let instance = A string child;
instance = ReactTestUtils.renderIntoDocument(instance);
expectSingleChildlessDiv(instance);
});
it('should not render extra nodes for non-interpolated text', () => {
- var instance = (
+ let instance = (
{'Interpolated String Child'}
);
instance = ReactTestUtils.renderIntoDocument(instance);
@@ -65,13 +65,13 @@ describe('ReactCompositeComponentDOMMinimalism', () => {
});
it('should not render extra nodes for non-interpolated text', () => {
- var instance = (
+ let instance = (
This text causes no children in ul, just innerHTML