diff --git a/packages/react-dom/src/__tests__/CSSPropertyOperations-test.js b/packages/react-dom/src/__tests__/CSSPropertyOperations-test.js index 10190db51ef9e..d1f97800dd993 100644 --- a/packages/react-dom/src/__tests__/CSSPropertyOperations-test.js +++ b/packages/react-dom/src/__tests__/CSSPropertyOperations-test.js @@ -9,9 +9,9 @@ 'use strict'; -var React = require('react'); -var ReactDOM = require('react-dom'); -var ReactDOMServer = require('react-dom/server'); +const React = require('react'); +const ReactDOM = require('react-dom'); +const ReactDOMServer = require('react-dom/server'); function normalizeCodeLocInfo(str) { return str && str.replace(/at .+?:\d+/g, 'at **'); @@ -19,66 +19,66 @@ function normalizeCodeLocInfo(str) { describe('CSSPropertyOperations', () => { it('should automatically append `px` to relevant styles', () => { - var styles = { + const styles = { left: 0, margin: 16, opacity: 0.5, padding: '4px', }; - var div =
; - var html = ReactDOMServer.renderToString(div); + const div =
; + const html = ReactDOMServer.renderToString(div); expect(html).toContain('"left:0;margin:16px;opacity:0.5;padding:4px"'); }); it('should trim values', () => { - var styles = { + const styles = { left: '16 ', opacity: 0.5, right: ' 4 ', }; - var div =
; - var html = ReactDOMServer.renderToString(div); + const div =
; + const html = ReactDOMServer.renderToString(div); expect(html).toContain('"left:16;opacity:0.5;right:4"'); }); it('should not append `px` to styles that might need a number', () => { - var styles = { + const styles = { flex: 0, opacity: 0.5, }; - var div =
; - var html = ReactDOMServer.renderToString(div); + const div =
; + const html = ReactDOMServer.renderToString(div); expect(html).toContain('"flex:0;opacity:0.5"'); }); it('should create vendor-prefixed markup correctly', () => { - var styles = { + const styles = { msTransition: 'none', MozTransition: 'none', }; - var div =
; - var html = ReactDOMServer.renderToString(div); + const div =
; + const html = ReactDOMServer.renderToString(div); expect(html).toContain('"-ms-transition:none;-moz-transition:none"'); }); it('should set style attribute when styles exist', () => { - var styles = { + const styles = { backgroundColor: '#000', display: 'none', }; - var div =
; - var root = document.createElement('div'); + let div =
; + const root = document.createElement('div'); div = ReactDOM.render(div, root); expect(/style=".*"/.test(root.innerHTML)).toBe(true); }); it('should not set style attribute when no styles exist', () => { - var styles = { + const styles = { backgroundColor: null, display: null, }; - var div =
; - var html = ReactDOMServer.renderToString(div); + const div =
; + const html = ReactDOMServer.renderToString(div); expect(/style=/.test(html)).toBe(false); }); @@ -92,7 +92,7 @@ describe('CSSPropertyOperations', () => { } spyOnDev(console, 'error'); - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); if (__DEV__) { expect(console.error.calls.count()).toBe(1); @@ -114,11 +114,11 @@ describe('CSSPropertyOperations', () => { } spyOnDev(console, 'error'); - var styles = { + const styles = { '-ms-transform': 'translate3d(0, 0, 0)', '-webkit-transform': 'translate3d(0, 0, 0)', }; - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); ReactDOM.render(, root); @@ -155,7 +155,7 @@ describe('CSSPropertyOperations', () => { } spyOnDev(console, 'error'); - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); if (__DEV__) { // msTransform is correct already and shouldn't warn @@ -194,7 +194,7 @@ describe('CSSPropertyOperations', () => { } spyOnDev(console, 'error'); - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); if (__DEV__) { expect(console.error.calls.count()).toBe(2); @@ -223,7 +223,7 @@ describe('CSSPropertyOperations', () => { } spyOnDev(console, 'error'); - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); if (__DEV__) { @@ -243,7 +243,7 @@ describe('CSSPropertyOperations', () => { } } - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); }); @@ -257,7 +257,7 @@ describe('CSSPropertyOperations', () => { } spyOnDev(console, 'error'); - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); if (__DEV__) { @@ -277,7 +277,7 @@ describe('CSSPropertyOperations', () => { } } - var root = document.createElement('div'); + const root = document.createElement('div'); ReactDOM.render(, root); expect(root.children[0].style.Foo).toEqual('5'); diff --git a/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js b/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js index 7c5358831446a..8cdf53f1c4ba8 100644 --- a/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js +++ b/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js @@ -10,8 +10,8 @@ 'use strict'; describe('DOMPropertyOperations', () => { - var React; - var ReactDOM; + let React; + let ReactDOM; beforeEach(() => { jest.resetModules(); @@ -21,20 +21,20 @@ describe('DOMPropertyOperations', () => { describe('setValueForProperty', () => { it('should set values as properties by default', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(
, container); expect(container.firstChild.title).toBe('Tip!'); }); it('should set values as attributes if necessary', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(
, container); expect(container.firstChild.getAttribute('role')).toBe('#'); expect(container.firstChild.role).toBeUndefined(); }); it('should set values as namespace attributes if necessary', () => { - var container = document.createElement('svg'); + const container = document.createElement('svg'); ReactDOM.render(, container); expect( container.firstChild.getAttributeNS( @@ -45,7 +45,7 @@ describe('DOMPropertyOperations', () => { }); it('should set values as boolean properties', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(
, container); expect(container.firstChild.getAttribute('disabled')).toBe(''); ReactDOM.render(
, container); @@ -63,32 +63,32 @@ describe('DOMPropertyOperations', () => { it('should convert attribute values to string first', () => { // Browsers default to this behavior, but some test environments do not. // This ensures that we have consistent behavior. - var obj = { + const obj = { toString: function() { return 'css-class'; }, }; - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(
, container); expect(container.firstChild.getAttribute('class')).toBe('css-class'); }); it('should not remove empty attributes for special properties', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(, container); expect(container.firstChild.getAttribute('value')).toBe(''); expect(container.firstChild.value).toBe(''); }); it('should remove for falsey boolean properties', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(
, container); expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false); }); it('should remove when setting custom attr to null', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(
, container); expect(container.firstChild.hasAttribute('data-foo')).toBe(true); ReactDOM.render(
, container); @@ -96,7 +96,7 @@ describe('DOMPropertyOperations', () => { }); it('should set className to empty string instead of null', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(
, container); expect(container.firstChild.className).toBe('selected'); ReactDOM.render(
, container); @@ -107,7 +107,7 @@ describe('DOMPropertyOperations', () => { }); it('should remove property properly for boolean properties', () => { - var container = document.createElement('div'); + const container = document.createElement('div'); ReactDOM.render(