From 95c9a578dd9f4d3d5c0f5e9cfecf6e66f00ce941 Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Fri, 6 Oct 2023 14:40:04 -0400 Subject: [PATCH] Disable ServerContext in stable --- packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js | 1 + .../src/__tests__/ReactFlightDOMBrowser-test.js | 1 + packages/react/index.classic.fb.js | 1 - packages/react/index.modern.fb.js | 1 - packages/react/index.stable.js | 1 - packages/shared/ReactFeatureFlags.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-fb.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-oss.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.native.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.www.js | 2 +- packages/shared/forks/ReactFeatureFlags.www.js | 2 +- 12 files changed, 9 insertions(+), 10 deletions(-) diff --git a/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js b/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js index a801be661f49c..a873a257528c5 100644 --- a/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js @@ -5608,6 +5608,7 @@ describe('ReactDOMFizzServer', () => { expect(getVisibleChildren(container)).toEqual('ABC'); }); + // @gate enableServerContext it('basic use(context)', async () => { const ContextA = React.createContext('default'); const ContextB = React.createContext('B'); diff --git a/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js b/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js index 7eef417035aca..0a453e0c07865 100644 --- a/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js +++ b/packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js @@ -618,6 +618,7 @@ describe('ReactFlightDOMBrowser', () => { expect(container.innerHTML).toBe('ABC'); }); + // @gate enableServerContext it('basic use(context)', async () => { let ContextA; let ContextB; diff --git a/packages/react/index.classic.fb.js b/packages/react/index.classic.fb.js index 5ea1945956a82..f096b478708df 100644 --- a/packages/react/index.classic.fb.js +++ b/packages/react/index.classic.fb.js @@ -22,7 +22,6 @@ export { createElement, createFactory, createRef, - createServerContext, use, forwardRef, isValidElement, diff --git a/packages/react/index.modern.fb.js b/packages/react/index.modern.fb.js index 1ba7d1b42bc51..601c4eebca4ab 100644 --- a/packages/react/index.modern.fb.js +++ b/packages/react/index.modern.fb.js @@ -21,7 +21,6 @@ export { createContext, createElement, createRef, - createServerContext, use, forwardRef, isValidElement, diff --git a/packages/react/index.stable.js b/packages/react/index.stable.js index de0a17cdb7913..b88a83d78b9b2 100644 --- a/packages/react/index.stable.js +++ b/packages/react/index.stable.js @@ -22,7 +22,6 @@ export { createElement, createFactory, createRef, - createServerContext, use, forwardRef, isValidElement, diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js index 5178f2c90ff7b..db3d4a822e77f 100644 --- a/packages/shared/ReactFeatureFlags.js +++ b/packages/shared/ReactFeatureFlags.js @@ -222,7 +222,7 @@ export const enableDebugTracing = false; // Track which Fiber(s) schedule render work. export const enableUpdaterTracking = __PROFILE__; -export const enableServerContext = true; +export const enableServerContext = __EXPERIMENTAL__; // Internal only. export const enableGetInspectorDataForInstanceInProduction = false; diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index 9b7b7f2f383f2..08a7d2a7ca459 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -76,7 +76,7 @@ export const allowConcurrentByDefault = true; export const enableCustomElementPropertySupport = false; export const consoleManagedByDevToolsDuringStrictMode = false; -export const enableServerContext = true; +export const enableServerContext = false; export const enableTransitionTracing = false; diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js index ebab18441223f..97069869747d7 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-oss.js +++ b/packages/shared/forks/ReactFeatureFlags.native-oss.js @@ -62,7 +62,7 @@ export const allowConcurrentByDefault = false; export const enableCustomElementPropertySupport = false; export const consoleManagedByDevToolsDuringStrictMode = false; -export const enableServerContext = true; +export const enableServerContext = false; export const enableTransitionTracing = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.js index 392c8cbb538b9..00f8723aae8fc 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.js @@ -62,7 +62,7 @@ export const allowConcurrentByDefault = false; export const enableCustomElementPropertySupport = false; export const consoleManagedByDevToolsDuringStrictMode = false; -export const enableServerContext = true; +export const enableServerContext = false; export const enableTransitionTracing = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js index b690f237b130b..66458ea0652e3 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js @@ -60,7 +60,7 @@ export const enableUnifiedSyncLane = false; export const allowConcurrentByDefault = true; export const consoleManagedByDevToolsDuringStrictMode = false; -export const enableServerContext = true; +export const enableServerContext = false; export const enableTransitionTracing = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js index e426ade2df12a..57e52bb0061df 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js @@ -62,7 +62,7 @@ export const allowConcurrentByDefault = true; export const enableCustomElementPropertySupport = false; export const consoleManagedByDevToolsDuringStrictMode = false; -export const enableServerContext = true; +export const enableServerContext = false; export const enableTransitionTracing = false; diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js index 16e6114e5153e..2e47b4b9f7db0 100644 --- a/packages/shared/forks/ReactFeatureFlags.www.js +++ b/packages/shared/forks/ReactFeatureFlags.www.js @@ -102,7 +102,7 @@ export const disableTextareaChildren = __EXPERIMENTAL__; export const allowConcurrentByDefault = true; export const consoleManagedByDevToolsDuringStrictMode = true; -export const enableServerContext = true; +export const enableServerContext = false; export const useModernStrictMode = false; export const enableFizzExternalRuntime = true;