diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js index 097628db06d15..eae4ff6bd408e 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.new.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.new.js @@ -893,6 +893,12 @@ function commitLayoutEffectOnFiber( // TODO: revisit this when we implement resuming. commitCallbacks(updateQueue, instance); } + + if (finishedWork.flags & Ref) { + if (!offscreenSubtreeWasHidden) { + commitAttachRef(finishedWork); + } + } break; } case HostRoot: { @@ -930,6 +936,11 @@ function commitLayoutEffectOnFiber( commitMount(instance, type, props, finishedWork); } + if (finishedWork.flags & Ref) { + if (!offscreenSubtreeWasHidden) { + commitAttachRef(finishedWork); + } + } break; } case HostText: { @@ -1020,20 +1031,6 @@ function commitLayoutEffectOnFiber( ); } } - - if (!offscreenSubtreeWasHidden) { - if (enableScopeAPI) { - // TODO: This is a temporary solution that allowed us to transition away - // from React Flare on www. - if (finishedWork.flags & Ref && finishedWork.tag !== ScopeComponent) { - commitAttachRef(finishedWork); - } - } else { - if (finishedWork.flags & Ref) { - commitAttachRef(finishedWork); - } - } - } } function reappearLayoutEffectsOnFiber(node: Fiber) { diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js index 252200fd5fbf3..5b3ae31df0b00 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.old.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.old.js @@ -893,6 +893,12 @@ function commitLayoutEffectOnFiber( // TODO: revisit this when we implement resuming. commitCallbacks(updateQueue, instance); } + + if (finishedWork.flags & Ref) { + if (!offscreenSubtreeWasHidden) { + commitAttachRef(finishedWork); + } + } break; } case HostRoot: { @@ -930,6 +936,11 @@ function commitLayoutEffectOnFiber( commitMount(instance, type, props, finishedWork); } + if (finishedWork.flags & Ref) { + if (!offscreenSubtreeWasHidden) { + commitAttachRef(finishedWork); + } + } break; } case HostText: { @@ -1020,20 +1031,6 @@ function commitLayoutEffectOnFiber( ); } } - - if (!offscreenSubtreeWasHidden) { - if (enableScopeAPI) { - // TODO: This is a temporary solution that allowed us to transition away - // from React Flare on www. - if (finishedWork.flags & Ref && finishedWork.tag !== ScopeComponent) { - commitAttachRef(finishedWork); - } - } else { - if (finishedWork.flags & Ref) { - commitAttachRef(finishedWork); - } - } - } } function reappearLayoutEffectsOnFiber(node: Fiber) {