Skip to content

Commit

Permalink
[compiler] Remove sleep in manual release script
Browse files Browse the repository at this point in the history
I originally added this prior to the compiler being OSS'd as a "just in
case" feature to panic cancel if something went wrong. Now that the
compiler is already launched this is unnecessary.

ghstack-source-id: dd17dc8a331657ce23c0cbc012ba967cfc3b9542
Pull Request resolved: #30613
  • Loading branch information
poteto committed Aug 6, 2024
1 parent ff0d262 commit e8a2b47
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions compiler/scripts/release/publish-manual.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const PUBLISHABLE_PACKAGES = [
'eslint-plugin-react-compiler',
'react-compiler-healthcheck',
];
const TIME_TO_RECONSIDER = 3_000;

function _spawn(command, args, options, cb) {
const child = cp.spawn(command, args, options);
Expand All @@ -33,10 +32,6 @@ function execHelper(command, options, streamStdout = false) {
});
}

function sleep(ms) {
return new Promise(resolve => setTimeout(resolve, ms));
}

async function getDateStringForCommit(commit) {
let dateString = await execHelper(
`git show -s --no-show-signature --format=%cd --date=format:%Y%m%d ${commit}`
Expand Down Expand Up @@ -191,15 +186,6 @@ async function main() {
);
}

if (debug === false) {
spinner.info(
`🚨🚨🚨 About to publish to npm in ${
TIME_TO_RECONSIDER / 1000
} seconds. You still have time to kill this script!`
);
await sleep(TIME_TO_RECONSIDER);
}

for (const pkgName of pkgNames) {
const pkgDir = path.resolve(__dirname, `../../packages/${pkgName}`);
console.log(`\n========== ${pkgName} ==========\n`);
Expand Down

0 comments on commit e8a2b47

Please sign in to comment.