Prevent error thrown when removing event target #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Member
|
Thanks for fixing this! I actually had a task for this assigned to me internally at Facebook, but I wasn't sure of the best way to fix it. |
Collaborator
Author
|
I'm not super thrilled with this, but it works. If it's okay for the parent events to be fired first then we could also write it as a recursive function without the array, which might be a little cleaner. |
Member
There was a problem hiding this comment.
Not used, is this doing something magical?
petehunt
added a commit
that referenced
this pull request
Feb 18, 2014
Prevent error thrown when removing event target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105.