From 075d6769f0439ce108c49b92ca91bf3de2bd9b9b Mon Sep 17 00:00:00 2001 From: Adrian Carolli Date: Sat, 25 Nov 2017 13:06:05 -0500 Subject: [PATCH 1/7] Add bundle linting and tests to the release script - add yarn lint-build - use yarn lint-build in circle ci build.sh - add yarn lint-build, yarn test-prod, yarn test-build, and yarn test-build-prod to the realse script --- package.json | 1 + scripts/circleci/build.sh | 2 +- .../build-commands/run-automated-tests.js | 23 +++++++++++++++++-- 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index c8ce7b99bce..75ffbc4da79 100644 --- a/package.json +++ b/package.json @@ -103,6 +103,7 @@ "build": "npm run version-check && node scripts/rollup/build.js", "linc": "node ./scripts/tasks/linc.js", "lint": "node ./scripts/tasks/eslint.js", + "lint-build": "node ./scripts/rollup/validate/index", "postinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json", "test": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js", "test-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source.js", diff --git a/scripts/circleci/build.sh b/scripts/circleci/build.sh index 97acc1462ff..779931cddf8 100755 --- a/scripts/circleci/build.sh +++ b/scripts/circleci/build.sh @@ -9,7 +9,7 @@ yarn build --extract-errors # See https://github.com/facebook/react/pull/11655. # Do a sanity check on bundles -node ./scripts/rollup/validate/index +yarn lint-build # Check that the standalone reconciler isn't borked cd fixtures/reconciler diff --git a/scripts/release/build-commands/run-automated-tests.js b/scripts/release/build-commands/run-automated-tests.js index 56a1cb42760..92ddc6cbb60 100644 --- a/scripts/release/build-commands/run-automated-tests.js +++ b/scripts/release/build-commands/run-automated-tests.js @@ -22,13 +22,32 @@ const runYarnTask = async (cwd, task, errorMessage) => { module.exports = async ({cwd}) => { await logPromise(runYarnTask(cwd, 'lint', 'Lint failed'), 'Running ESLint'); + await logPromise( + runYarnTask(cwd, 'lint-build', 'Lint build failed'), + 'Running ESLint on build' + ); await logPromise( runYarnTask(cwd, 'flow', 'Flow failed'), 'Running Flow checks' ); await logPromise( - runYarnTask(cwd, 'test', 'Jest failed'), - 'Running Jest tests', + runYarnTask(cwd, 'test', 'Development Jest tests failed'), + 'Running development Jest tests', + true + ); + await logPromise( + runYarnTask(cwd, 'test-prod', 'Production Jest tests failed'), + 'Running production Jest tests', + true + ); + await logPromise( + runYarnTask(cwd, 'test-build', 'Development build Jest tests failed'), + 'Running development build Jest tests', + true + ); + await logPromise( + runYarnTask(cwd, 'test-build-prod', 'Production build Jest tests failed'), + 'Running production build Jest tests', true ); }; From 34abbeb6ad61502acc1ea00740dcf97c821a597e Mon Sep 17 00:00:00 2001 From: Adrian Carolli Date: Sat, 25 Nov 2017 13:23:45 -0500 Subject: [PATCH 2/7] Improve readability of release test messages --- .../build-commands/run-automated-tests.js | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/release/build-commands/run-automated-tests.js b/scripts/release/build-commands/run-automated-tests.js index 92ddc6cbb60..2f37a7fd798 100644 --- a/scripts/release/build-commands/run-automated-tests.js +++ b/scripts/release/build-commands/run-automated-tests.js @@ -23,31 +23,31 @@ const runYarnTask = async (cwd, task, errorMessage) => { module.exports = async ({cwd}) => { await logPromise(runYarnTask(cwd, 'lint', 'Lint failed'), 'Running ESLint'); await logPromise( - runYarnTask(cwd, 'lint-build', 'Lint build failed'), - 'Running ESLint on build' + runYarnTask(cwd, 'lint-build', 'Lint bundle failed'), + 'Running ESLint on bundle' ); await logPromise( runYarnTask(cwd, 'flow', 'Flow failed'), 'Running Flow checks' ); await logPromise( - runYarnTask(cwd, 'test', 'Development Jest tests failed'), - 'Running development Jest tests', + runYarnTask(cwd, 'test', 'Jest tests failed in development'), + 'Running Jest tests in the development environment', true ); await logPromise( - runYarnTask(cwd, 'test-prod', 'Production Jest tests failed'), - 'Running production Jest tests', + runYarnTask(cwd, 'test-prod', 'Jest tests failed in production'), + 'Running Jest tests in the production environment', true ); await logPromise( - runYarnTask(cwd, 'test-build', 'Development build Jest tests failed'), - 'Running development build Jest tests', + runYarnTask(cwd, 'test-build', 'Jest tests on the bundle failed in development'), + 'Running Jest tests on the bundle in the development environment', true ); await logPromise( - runYarnTask(cwd, 'test-build-prod', 'Production build Jest tests failed'), - 'Running production build Jest tests', + runYarnTask(cwd, 'test-build-prod', 'Jest tests on the bundle failed in production'), + 'Running Jest tests on the bundle in the production environment', true ); }; From 7d341464212528e54ecefa630dbd35b396c2660a Mon Sep 17 00:00:00 2001 From: Adrian Carolli Date: Sat, 25 Nov 2017 13:26:06 -0500 Subject: [PATCH 3/7] Run prettier --- .../release/build-commands/run-automated-tests.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/scripts/release/build-commands/run-automated-tests.js b/scripts/release/build-commands/run-automated-tests.js index 2f37a7fd798..0b340832c56 100644 --- a/scripts/release/build-commands/run-automated-tests.js +++ b/scripts/release/build-commands/run-automated-tests.js @@ -23,7 +23,7 @@ const runYarnTask = async (cwd, task, errorMessage) => { module.exports = async ({cwd}) => { await logPromise(runYarnTask(cwd, 'lint', 'Lint failed'), 'Running ESLint'); await logPromise( - runYarnTask(cwd, 'lint-build', 'Lint bundle failed'), + runYarnTask(cwd, 'lint-build', 'Lint bundle failed'), 'Running ESLint on bundle' ); await logPromise( @@ -41,12 +41,20 @@ module.exports = async ({cwd}) => { true ); await logPromise( - runYarnTask(cwd, 'test-build', 'Jest tests on the bundle failed in development'), + runYarnTask( + cwd, + 'test-build', + 'Jest tests on the bundle failed in development' + ), 'Running Jest tests on the bundle in the development environment', true ); await logPromise( - runYarnTask(cwd, 'test-build-prod', 'Jest tests on the bundle failed in production'), + runYarnTask( + cwd, + 'test-build-prod', + 'Jest tests on the bundle failed in production' + ), 'Running Jest tests on the bundle in the production environment', true ); From 17e051b77cbabb9b0fda37b9c88c6981e167b4f4 Mon Sep 17 00:00:00 2001 From: Adrian Carolli Date: Sat, 25 Nov 2017 14:26:29 -0500 Subject: [PATCH 4/7] Updating package versions for release 16.2.0 --- package.json | 2 +- packages/react-art/package.json | 2 +- packages/react-call-return/package.json | 2 +- packages/react-dom/package.json | 2 +- packages/react-reconciler/package.json | 2 +- packages/react-test-renderer/package.json | 2 +- packages/react/package.json | 2 +- packages/shared/ReactVersion.js | 2 +- scripts/release/build.js | 36 +++++++++++------------ 9 files changed, 26 insertions(+), 26 deletions(-) diff --git a/package.json b/package.json index 75ffbc4da79..b8cb375e9f6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "private": true, - "version": "16.1.1", + "version": "16.2.0", "workspaces": [ "packages/*" ], diff --git a/packages/react-art/package.json b/packages/react-art/package.json index c591dc76eba..3631c1784ff 100644 --- a/packages/react-art/package.json +++ b/packages/react-art/package.json @@ -1,7 +1,7 @@ { "name": "react-art", "description": "React ART is a JavaScript library for drawing vector graphics using React. It provides declarative and reactive bindings to the ART library. Using the same declarative API you can render the output to either Canvas, SVG or VML (IE8).", - "version": "16.1.1", + "version": "16.2.0", "main": "index.js", "repository": "facebook/react", "keywords": [ diff --git a/packages/react-call-return/package.json b/packages/react-call-return/package.json index c752313f7ec..dcacff7d70e 100644 --- a/packages/react-call-return/package.json +++ b/packages/react-call-return/package.json @@ -1,7 +1,7 @@ { "name": "react-call-return", "description": "Experimental APIs for multi-pass rendering in React.", - "version": "0.4.0", + "version": "0.5.0", "repository": "facebook/react", "files": [ "LICENSE", diff --git a/packages/react-dom/package.json b/packages/react-dom/package.json index 09779e21f02..a20aa619337 100644 --- a/packages/react-dom/package.json +++ b/packages/react-dom/package.json @@ -1,6 +1,6 @@ { "name": "react-dom", - "version": "16.1.1", + "version": "16.2.0", "description": "React package for working with the DOM.", "main": "index.js", "repository": "facebook/react", diff --git a/packages/react-reconciler/package.json b/packages/react-reconciler/package.json index d01cacad1b1..970a231cae0 100644 --- a/packages/react-reconciler/package.json +++ b/packages/react-reconciler/package.json @@ -1,7 +1,7 @@ { "name": "react-reconciler", "description": "React package for creating custom renderers.", - "version": "0.6.0", + "version": "0.7.0", "keywords": [ "react" ], diff --git a/packages/react-test-renderer/package.json b/packages/react-test-renderer/package.json index bd95d2f6e43..1ba1e517f07 100644 --- a/packages/react-test-renderer/package.json +++ b/packages/react-test-renderer/package.json @@ -1,6 +1,6 @@ { "name": "react-test-renderer", - "version": "16.1.1", + "version": "16.2.0", "description": "React package for snapshot testing.", "main": "index.js", "repository": "facebook/react", diff --git a/packages/react/package.json b/packages/react/package.json index 606123550ca..e2ad5dbf382 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -4,7 +4,7 @@ "keywords": [ "react" ], - "version": "16.1.1", + "version": "16.2.0", "homepage": "https://reactjs.org/", "bugs": "https://github.com/facebook/react/issues", "license": "MIT", diff --git a/packages/shared/ReactVersion.js b/packages/shared/ReactVersion.js index 8cb3f775259..f387bbb479d 100644 --- a/packages/shared/ReactVersion.js +++ b/packages/shared/ReactVersion.js @@ -8,4 +8,4 @@ 'use strict'; // TODO: this is special because it gets imported during build. -module.exports = '16.1.1'; +module.exports = '16.2.0'; diff --git a/scripts/release/build.js b/scripts/release/build.js index 5d133e82caf..6327f48e6fb 100755 --- a/scripts/release/build.js +++ b/scripts/release/build.js @@ -12,33 +12,33 @@ const run = async () => { const addGitTag = require('./build-commands/add-git-tag'); const buildArtifacts = require('./build-commands/build-artifacts'); - const checkCircleCiStatus = require('./build-commands/check-circle-ci-status'); - const checkEnvironmentVariables = require('./build-commands/check-environment-variables'); - const checkNpmPermissions = require('./build-commands/check-npm-permissions'); - const checkPackageDependencies = require('./build-commands/check-package-dependencies'); - const checkUncommittedChanges = require('./build-commands/check-uncommitted-changes'); - const installYarnDependencies = require('./build-commands/install-yarn-dependencies'); + // const checkCircleCiStatus = require('./build-commands/check-circle-ci-status'); + // const checkEnvironmentVariables = require('./build-commands/check-environment-variables'); + // const checkNpmPermissions = require('./build-commands/check-npm-permissions'); + // const checkPackageDependencies = require('./build-commands/check-package-dependencies'); + // const checkUncommittedChanges = require('./build-commands/check-uncommitted-changes'); + // const installYarnDependencies = require('./build-commands/install-yarn-dependencies'); const parseBuildParameters = require('./build-commands/parse-build-parameters'); const printPostBuildSummary = require('./build-commands/print-post-build-summary'); const runAutomatedTests = require('./build-commands/run-automated-tests'); - const updateGit = require('./build-commands/update-git'); + // const updateGit = require('./build-commands/update-git'); const updatePackageVersions = require('./build-commands/update-package-versions'); - const updateYarnDependencies = require('./build-commands/update-yarn-dependencies'); - const validateVersion = require('./build-commands/validate-version'); + // const updateYarnDependencies = require('./build-commands/update-yarn-dependencies'); + // const validateVersion = require('./build-commands/validate-version'); try { const params = parseBuildParameters(); params.packages = getPublicPackages(); - await checkEnvironmentVariables(params); - await validateVersion(params); - await checkUncommittedChanges(params); - await checkNpmPermissions(params); - await updateGit(params); - await checkCircleCiStatus(params); - await installYarnDependencies(params); - await checkPackageDependencies(params); - await updateYarnDependencies(params); + // await checkEnvironmentVariables(params); + // await validateVersion(params); + // await checkUncommittedChanges(params); + // await checkNpmPermissions(params); + // await updateGit(params); + // await checkCircleCiStatus(params); + // await installYarnDependencies(params); + // await checkPackageDependencies(params); + // await updateYarnDependencies(params); await runAutomatedTests(params); await updatePackageVersions(params); await buildArtifacts(params); From 51405fcacf4e25cf3cf6f3a3ab3a0d785b81ca32 Mon Sep 17 00:00:00 2001 From: Adrian Carolli Date: Sun, 26 Nov 2017 10:38:32 -0500 Subject: [PATCH 5/7] Seperate bundle specific tests - Moved the runYarnTask into utils since its being used two files now - Uncomment out checks I mistakenly committed --- .../run-automated-bundle-tests.js | 30 ++++++++++++++ .../build-commands/run-automated-tests.js | 40 +------------------ scripts/release/build.js | 38 +++++++++--------- scripts/release/utils.js | 15 +++++++ 4 files changed, 66 insertions(+), 57 deletions(-) create mode 100644 scripts/release/build-commands/run-automated-bundle-tests.js diff --git a/scripts/release/build-commands/run-automated-bundle-tests.js b/scripts/release/build-commands/run-automated-bundle-tests.js new file mode 100644 index 00000000000..3fed6b30026 --- /dev/null +++ b/scripts/release/build-commands/run-automated-bundle-tests.js @@ -0,0 +1,30 @@ +#!/usr/bin/env node + +'use strict'; + +const {logPromise, runYarnTask} = require('../utils'); + +module.exports = async ({cwd}) => { + await logPromise( + runYarnTask(cwd, 'lint-build', 'Lint bundle failed'), + 'Running ESLint on bundle' + ); + await logPromise( + runYarnTask( + cwd, + 'test-build', + 'Jest tests on the bundle failed in development' + ), + 'Running Jest tests on the bundle in the development environment', + true + ); + await logPromise( + runYarnTask( + cwd, + 'test-build-prod', + 'Jest tests on the bundle failed in production' + ), + 'Running Jest tests on the bundle in the production environment', + true + ); +}; diff --git a/scripts/release/build-commands/run-automated-tests.js b/scripts/release/build-commands/run-automated-tests.js index 0b340832c56..676034ba6ee 100644 --- a/scripts/release/build-commands/run-automated-tests.js +++ b/scripts/release/build-commands/run-automated-tests.js @@ -2,30 +2,10 @@ 'use strict'; -const chalk = require('chalk'); -const {exec} = require('child-process-promise'); -const {logPromise} = require('../utils'); - -const runYarnTask = async (cwd, task, errorMessage) => { - try { - await exec(`yarn ${task}`, {cwd}); - } catch (error) { - throw Error( - chalk` - ${errorMessage} - - {white ${error.stdout}} - ` - ); - } -}; +const {logPromise, runYarnTask} = require('../utils'); module.exports = async ({cwd}) => { await logPromise(runYarnTask(cwd, 'lint', 'Lint failed'), 'Running ESLint'); - await logPromise( - runYarnTask(cwd, 'lint-build', 'Lint bundle failed'), - 'Running ESLint on bundle' - ); await logPromise( runYarnTask(cwd, 'flow', 'Flow failed'), 'Running Flow checks' @@ -40,22 +20,4 @@ module.exports = async ({cwd}) => { 'Running Jest tests in the production environment', true ); - await logPromise( - runYarnTask( - cwd, - 'test-build', - 'Jest tests on the bundle failed in development' - ), - 'Running Jest tests on the bundle in the development environment', - true - ); - await logPromise( - runYarnTask( - cwd, - 'test-build-prod', - 'Jest tests on the bundle failed in production' - ), - 'Running Jest tests on the bundle in the production environment', - true - ); }; diff --git a/scripts/release/build.js b/scripts/release/build.js index 6327f48e6fb..9ab5b99192f 100755 --- a/scripts/release/build.js +++ b/scripts/release/build.js @@ -12,36 +12,38 @@ const run = async () => { const addGitTag = require('./build-commands/add-git-tag'); const buildArtifacts = require('./build-commands/build-artifacts'); - // const checkCircleCiStatus = require('./build-commands/check-circle-ci-status'); - // const checkEnvironmentVariables = require('./build-commands/check-environment-variables'); - // const checkNpmPermissions = require('./build-commands/check-npm-permissions'); - // const checkPackageDependencies = require('./build-commands/check-package-dependencies'); - // const checkUncommittedChanges = require('./build-commands/check-uncommitted-changes'); - // const installYarnDependencies = require('./build-commands/install-yarn-dependencies'); + const checkCircleCiStatus = require('./build-commands/check-circle-ci-status'); + const checkEnvironmentVariables = require('./build-commands/check-environment-variables'); + const checkNpmPermissions = require('./build-commands/check-npm-permissions'); + const checkPackageDependencies = require('./build-commands/check-package-dependencies'); + const checkUncommittedChanges = require('./build-commands/check-uncommitted-changes'); + const installYarnDependencies = require('./build-commands/install-yarn-dependencies'); const parseBuildParameters = require('./build-commands/parse-build-parameters'); const printPostBuildSummary = require('./build-commands/print-post-build-summary'); const runAutomatedTests = require('./build-commands/run-automated-tests'); - // const updateGit = require('./build-commands/update-git'); + const runAutomatedBundleTests = require('./build-commands/run-automated-bundle-tests'); + const updateGit = require('./build-commands/update-git'); const updatePackageVersions = require('./build-commands/update-package-versions'); - // const updateYarnDependencies = require('./build-commands/update-yarn-dependencies'); - // const validateVersion = require('./build-commands/validate-version'); + const updateYarnDependencies = require('./build-commands/update-yarn-dependencies'); + const validateVersion = require('./build-commands/validate-version'); try { const params = parseBuildParameters(); params.packages = getPublicPackages(); - // await checkEnvironmentVariables(params); - // await validateVersion(params); - // await checkUncommittedChanges(params); - // await checkNpmPermissions(params); - // await updateGit(params); - // await checkCircleCiStatus(params); - // await installYarnDependencies(params); - // await checkPackageDependencies(params); - // await updateYarnDependencies(params); + await checkEnvironmentVariables(params); + await validateVersion(params); + await checkUncommittedChanges(params); + await checkNpmPermissions(params); + await updateGit(params); + await checkCircleCiStatus(params); + await installYarnDependencies(params); + await checkPackageDependencies(params); + await updateYarnDependencies(params); await runAutomatedTests(params); await updatePackageVersions(params); await buildArtifacts(params); + await runAutomatedBundleTests(params); await addGitTag(params); await printPostBuildSummary(params); } catch (error) { diff --git a/scripts/release/utils.js b/scripts/release/utils.js index 7eb99ee4a4a..d5be8b1a5a5 100644 --- a/scripts/release/utils.js +++ b/scripts/release/utils.js @@ -82,10 +82,25 @@ const logPromise = async (promise, text, isLongRunningTask = false) => { } }; +const runYarnTask = async (cwd, task, errorMessage) => { + try { + await exec(`yarn ${task}`, {cwd}); + } catch (error) { + throw Error( + chalk` + ${errorMessage} + + {white ${error.stdout}} + ` + ); + } +}; + module.exports = { execRead, execUnlessDry, getPublicPackages, getUnexecutedCommands, logPromise, + runYarnTask, }; From 9209b34c26017becf3392f5482309146ec1560da Mon Sep 17 00:00:00 2001 From: Adrian Carolli Date: Sun, 26 Nov 2017 10:42:35 -0500 Subject: [PATCH 6/7] Revert a bunch of version bump changes Mistakenly commited by release script --- package.json | 2 +- packages/react-art/package.json | 2 +- packages/react-call-return/package.json | 2 +- packages/react-dom/package.json | 2 +- packages/react-reconciler/package.json | 2 +- packages/react-test-renderer/package.json | 2 +- packages/react/package.json | 2 +- packages/shared/ReactVersion.js | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index b8cb375e9f6..75ffbc4da79 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "private": true, - "version": "16.2.0", + "version": "16.1.1", "workspaces": [ "packages/*" ], diff --git a/packages/react-art/package.json b/packages/react-art/package.json index 3631c1784ff..c591dc76eba 100644 --- a/packages/react-art/package.json +++ b/packages/react-art/package.json @@ -1,7 +1,7 @@ { "name": "react-art", "description": "React ART is a JavaScript library for drawing vector graphics using React. It provides declarative and reactive bindings to the ART library. Using the same declarative API you can render the output to either Canvas, SVG or VML (IE8).", - "version": "16.2.0", + "version": "16.1.1", "main": "index.js", "repository": "facebook/react", "keywords": [ diff --git a/packages/react-call-return/package.json b/packages/react-call-return/package.json index dcacff7d70e..c752313f7ec 100644 --- a/packages/react-call-return/package.json +++ b/packages/react-call-return/package.json @@ -1,7 +1,7 @@ { "name": "react-call-return", "description": "Experimental APIs for multi-pass rendering in React.", - "version": "0.5.0", + "version": "0.4.0", "repository": "facebook/react", "files": [ "LICENSE", diff --git a/packages/react-dom/package.json b/packages/react-dom/package.json index a20aa619337..09779e21f02 100644 --- a/packages/react-dom/package.json +++ b/packages/react-dom/package.json @@ -1,6 +1,6 @@ { "name": "react-dom", - "version": "16.2.0", + "version": "16.1.1", "description": "React package for working with the DOM.", "main": "index.js", "repository": "facebook/react", diff --git a/packages/react-reconciler/package.json b/packages/react-reconciler/package.json index 970a231cae0..d01cacad1b1 100644 --- a/packages/react-reconciler/package.json +++ b/packages/react-reconciler/package.json @@ -1,7 +1,7 @@ { "name": "react-reconciler", "description": "React package for creating custom renderers.", - "version": "0.7.0", + "version": "0.6.0", "keywords": [ "react" ], diff --git a/packages/react-test-renderer/package.json b/packages/react-test-renderer/package.json index 1ba1e517f07..bd95d2f6e43 100644 --- a/packages/react-test-renderer/package.json +++ b/packages/react-test-renderer/package.json @@ -1,6 +1,6 @@ { "name": "react-test-renderer", - "version": "16.2.0", + "version": "16.1.1", "description": "React package for snapshot testing.", "main": "index.js", "repository": "facebook/react", diff --git a/packages/react/package.json b/packages/react/package.json index e2ad5dbf382..606123550ca 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -4,7 +4,7 @@ "keywords": [ "react" ], - "version": "16.2.0", + "version": "16.1.1", "homepage": "https://reactjs.org/", "bugs": "https://github.com/facebook/react/issues", "license": "MIT", diff --git a/packages/shared/ReactVersion.js b/packages/shared/ReactVersion.js index f387bbb479d..8cb3f775259 100644 --- a/packages/shared/ReactVersion.js +++ b/packages/shared/ReactVersion.js @@ -8,4 +8,4 @@ 'use strict'; // TODO: this is special because it gets imported during build. -module.exports = '16.2.0'; +module.exports = '16.1.1'; From fdfe42a27a43aec61078efa415f88e581b7d874a Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sun, 26 Nov 2017 16:45:47 +0000 Subject: [PATCH 7/7] .js for consistency --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 75ffbc4da79..bcbc98450d2 100644 --- a/package.json +++ b/package.json @@ -103,7 +103,7 @@ "build": "npm run version-check && node scripts/rollup/build.js", "linc": "node ./scripts/tasks/linc.js", "lint": "node ./scripts/tasks/eslint.js", - "lint-build": "node ./scripts/rollup/validate/index", + "lint-build": "node ./scripts/rollup/validate/index.js", "postinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json", "test": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js", "test-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source.js",