Skip to content

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Dec 30, 2019

Might as well leverage Circle CI to test our DevTools builds, and if we're doing that- we might as well store the artifacts as well. Maybe in the future, we should release DevTools directly from CI artifacts as well, like we do for NPM packages.

Let's see if these changes actually work... 😄

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 30, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd76991:

Sandbox Source
agitated-aryabhata-idpr7 Configuration

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptive stamp

@sizebot
Copy link

sizebot commented Dec 30, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against cd76991

@sizebot
Copy link

sizebot commented Dec 30, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against cd76991

@bvaughn bvaughn force-pushed the circle-ci-store-devtools-artifacts branch 2 times, most recently from 5889930 to 1f5f2e5 Compare December 31, 2019 00:31
@bvaughn
Copy link
Contributor Author

bvaughn commented Dec 31, 2019

I think Circle CI is confused. Looks like it re-ran part of the build commands without cleaning up, so now some things are failing b'c files are left over from previous runs. I used to have the option to clear cache and re-run but I don't see it anymore.

@bvaughn bvaughn force-pushed the circle-ci-store-devtools-artifacts branch from aa577a8 to 756dfc9 Compare December 31, 2019 17:01
@bvaughn bvaughn force-pushed the circle-ci-store-devtools-artifacts branch from 756dfc9 to cd76991 Compare December 31, 2019 17:03
@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 1, 2020

Yay Circle CI seems to have finally passed after the last round of changes.

@bvaughn bvaughn merged commit 2c1e5d2 into facebook:master Jan 1, 2020
@bvaughn bvaughn deleted the circle-ci-store-devtools-artifacts branch January 1, 2020 15:58
@xusai2014
Copy link

Might as well leverage Circle CI to test our DevTools builds, and if we're doing that- we might as well store the artifacts as well. Maybe in the future, we should release DevTools directly from CI artifacts as well, like we do for NPM packages.

Let's see if these changes actually work... 😄

Hi Guys

Your ideas appeal to me. Could you describe the detail of the ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants