From 119645f92a64918bf75f7399dda86a806bd8a0c0 Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Wed, 15 Jul 2020 10:27:32 -0400 Subject: [PATCH] Disable DevTools minification DevTools isn't being downloaded like typical JavaScript, so bundle size concerns don't apply. Parsing is still a consideration (so I'm open for discussion here) but I think this change would provide a couple of benefits: * People are more likely to *actually read* non-minified source code when e.g. a breakpoint is hit (as with the recent debugger statement) * Component stacks will be easier to parse on bug reports --- packages/react-devtools-extensions/webpack.backend.js | 10 +--------- packages/react-devtools-extensions/webpack.config.js | 3 +++ packages/react-devtools-inline/webpack.config.js | 10 +--------- packages/react-devtools-shell/webpack.config.js | 10 +--------- 4 files changed, 6 insertions(+), 27 deletions(-) diff --git a/packages/react-devtools-extensions/webpack.backend.js b/packages/react-devtools-extensions/webpack.backend.js index 0148c2b217f82..2399c10892e35 100644 --- a/packages/react-devtools-extensions/webpack.backend.js +++ b/packages/react-devtools-extensions/webpack.backend.js @@ -2,7 +2,6 @@ const {resolve} = require('path'); const {DefinePlugin} = require('webpack'); -const TerserPlugin = require('terser-webpack-plugin'); const {GITHUB_URL, getVersionString} = require('./utils'); const NODE_ENV = process.env.NODE_ENV; @@ -41,14 +40,7 @@ module.exports = { }, }, optimization: { - minimizer: [ - new TerserPlugin({ - terserOptions: { - compress: {drop_debugger: false}, - output: {comments: true}, - }, - }), - ], + minimize: false, }, plugins: [ new DefinePlugin({ diff --git a/packages/react-devtools-extensions/webpack.config.js b/packages/react-devtools-extensions/webpack.config.js index 73edf8c5947c8..162d418d83c32 100644 --- a/packages/react-devtools-extensions/webpack.config.js +++ b/packages/react-devtools-extensions/webpack.config.js @@ -44,6 +44,9 @@ module.exports = { scheduler: resolve(builtModulesDir, 'scheduler'), }, }, + optimization: { + minimize: false, + }, plugins: [ new DefinePlugin({ __DEV__: false, diff --git a/packages/react-devtools-inline/webpack.config.js b/packages/react-devtools-inline/webpack.config.js index 84b6ed0ac19d4..d841f48199e7a 100644 --- a/packages/react-devtools-inline/webpack.config.js +++ b/packages/react-devtools-inline/webpack.config.js @@ -1,6 +1,5 @@ const {resolve} = require('path'); const {DefinePlugin} = require('webpack'); -const TerserPlugin = require('terser-webpack-plugin'); const { GITHUB_URL, getVersionString, @@ -38,14 +37,7 @@ module.exports = { scheduler: 'scheduler', }, optimization: { - minimizer: [ - new TerserPlugin({ - terserOptions: { - compress: {drop_debugger: false}, - output: {comments: true}, - }, - }), - ], + minimize: false, }, plugins: [ new DefinePlugin({ diff --git a/packages/react-devtools-shell/webpack.config.js b/packages/react-devtools-shell/webpack.config.js index c1687f54d47e7..b1c737f6fa569 100644 --- a/packages/react-devtools-shell/webpack.config.js +++ b/packages/react-devtools-shell/webpack.config.js @@ -1,6 +1,5 @@ const {resolve} = require('path'); const {DefinePlugin} = require('webpack'); -const TerserPlugin = require('terser-webpack-plugin'); const { GITHUB_URL, getVersionString, @@ -41,14 +40,7 @@ const config = { }, }, optimization: { - minimizer: [ - new TerserPlugin({ - terserOptions: { - compress: {drop_debugger: false}, - output: {comments: true}, - }, - }), - ], + minimize: false, }, plugins: [ new DefinePlugin({