Don't build shallow renderer UMD bundles #19372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
approved these changes
Jul 15, 2020
Contributor
|
This change was manually cherry picked into master, so I'm going to close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the blocker for #19368.
We've stopped building CJS bundles for shallow, but we're still building UMDs. They're only available in the UMD folder. I think it's reasonable to drop UMDs for the shallow renderer in our package because they can be found in https://unpkg.com/browse/react-shallow-renderer/umd/ anyway. And since master is already 17-only we can do it now.
Note this doesn't delete shallow renderer integration tests or the entry point. That keeps working.