Skip to content

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Mar 16, 2021

I noticed that it's building both the stable and experimental release channels of React (when it only needs the experimental channel) and it's building non-node modules artifacts.

This should reduce the build time to like 25% or less of what it was before.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 16, 2021
@sizebot
Copy link

sizebot commented Mar 16, 2021

Comparing: 0203b65...598091c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.83 kB 122.83 kB = 39.52 kB 39.52 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.33 kB 129.33 kB = 41.59 kB 41.59 kB
facebook-www/ReactDOM-prod.classic.js = 408.70 kB 408.70 kB = 75.80 kB 75.80 kB
facebook-www/ReactDOM-prod.modern.js = 396.96 kB 396.96 kB = 73.86 kB 73.86 kB
facebook-www/ReactDOMForked-prod.classic.js = 408.71 kB 408.71 kB = 75.80 kB 75.80 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 598091c

@bvaughn bvaughn merged commit 533aed8 into facebook:master Mar 16, 2021
@bvaughn bvaughn deleted the speedup-devtools-build-target branch March 16, 2021 18:02
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Mar 23, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants