Sync internal #2415
Merged
Sync internal #2415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, warning might be replaced with a module that throws errors, as is the case internally when running tests. Previously we were whitelisting this test to provide time to update callsites. Now we aren't and it fails.
On ios device, browser simulates mouse events, but does that with a delay, because of double tap gesture. The problem is that TapEventPlugins listens to both types of events, so it fires twice Everytime there is a touch event, we should ignore mouse events that follow it. This way, we still respond to both mouse and touch events, just ignore the device generated ones.
Collaborator
|
Not sure if this move of Object.assign is really necessary but ok. |
Member
Author
|
Discussed in person. It is, for now. |
s0meone
added a commit
to zilverline/react-tap-event-plugin
that referenced
this pull request
Mar 26, 2015
Facebook [included the fix](facebook@ff12423) in their `TapEvenPlugin` with PR facebook#2415 but did not include it in the release yet. This closes #12, closes #11, and closes #9.
madjam002
pushed a commit
to zilverline/react-tap-event-plugin
that referenced
this pull request
Feb 3, 2016
Facebook [included the fix](facebook@ff12423) in their `TapEvenPlugin` with PR facebook#2415 but did not include it in the release yet. This closes #12, closes #11, and closes #9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a couple things that needed to be done differently internally (or snuck in) and this brings us mostly into sync. cc @sebmarkbage
Side note: I'm doing this with a PR instead of just pushing because I want to try a thing where we can just run down a list of PRs when generating changelogs.