From c02d5c30f8cb312b7bd8f273385c7721dc45b54e Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Tue, 13 Feb 2024 12:58:56 -0800 Subject: [PATCH 1/7] fix documentation link for hidpi canvas --- packages/react-devtools-timeline/src/view-base/Surface.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-devtools-timeline/src/view-base/Surface.js b/packages/react-devtools-timeline/src/view-base/Surface.js index 4708cd95f78..81c0199cc74 100644 --- a/packages/react-devtools-timeline/src/view-base/Surface.js +++ b/packages/react-devtools-timeline/src/view-base/Surface.js @@ -21,7 +21,7 @@ export type ViewRefs = { hoveredView: View | null, }; -// hidpi canvas: https://www.html5rocks.com/en/tutorials/canvas/hidpi/ +// hidpi canvas: https://web.dev/articles/canvas-hidipi function configureRetinaCanvas( canvas: HTMLCanvasElement, height: number, From bc1caa48af535538ce8acc9db9385bc20f36232c Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Tue, 13 Feb 2024 13:18:29 -0800 Subject: [PATCH 2/7] https://www.w3.org/TR/custom-elements/ --- packages/react-dom-bindings/src/shared/isCustomElement.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dom-bindings/src/shared/isCustomElement.js b/packages/react-dom-bindings/src/shared/isCustomElement.js index 39d5d7fe187..32318d7106f 100644 --- a/packages/react-dom-bindings/src/shared/isCustomElement.js +++ b/packages/react-dom-bindings/src/shared/isCustomElement.js @@ -15,7 +15,7 @@ function isCustomElement(tagName: string, props: Object): boolean { // These are reserved SVG and MathML elements. // We don't mind this list too much because we expect it to never grow. // The alternative is to track the namespace in a few places which is convoluted. - // https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts + // https://www.w3.org/TR/custom-elements/ case 'annotation-xml': case 'color-profile': case 'font-face': From 18cebff30dc2856303b2d9901634b8b90a1a2925 Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Tue, 13 Feb 2024 13:19:25 -0800 Subject: [PATCH 3/7] https://www.w3.org/TR/custom-elements/ --- packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js index b6fe8d9109a..b34d650e254 100644 --- a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js +++ b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js @@ -3698,7 +3698,7 @@ export function pushStartInstance( return pushSelfClosing(target, props, type); } // These are reserved SVG and MathML elements, that are never custom elements. - // https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts + // https://www.w3.org/TR/custom-elements/ case 'annotation-xml': case 'color-profile': case 'font-face': From 83c20986d785b0953b82497e857972de04d0e58f Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Tue, 13 Feb 2024 13:22:28 -0800 Subject: [PATCH 4/7] https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js --- .../src/view-base/utils/normalizeWheel.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js b/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js index 9b27792c95d..95f3db1aea2 100644 --- a/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js +++ b/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js @@ -7,7 +7,7 @@ * @flow */ -// Adapted from: https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js +// Adapted from: https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js export type NormalizedWheelDelta = { deltaX: number, From 6f3793fd4e45360032d44ed18d924ba56dd824a9 Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Tue, 13 Feb 2024 13:24:09 -0800 Subject: [PATCH 5/7] https://github.com/facebook/react/blob/main/packages/react-cache/src/ReactCacheOld.js --- packages/react-devtools-shared/src/devtools/cache.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-devtools-shared/src/devtools/cache.js b/packages/react-devtools-shared/src/devtools/cache.js index 4bb44bacb3a..a11032caf59 100644 --- a/packages/react-devtools-shared/src/devtools/cache.js +++ b/packages/react-devtools-shared/src/devtools/cache.js @@ -15,7 +15,7 @@ import {createContext} from 'react'; // TODO (cache) Remove this cache; it is outdated and will not work with newer APIs like startTransition. // Cache implementation was forked from the React repo: -// https://github.com/facebook/react/blob/main/packages/react-cache/src/ReactCache.js +// https://github.com/facebook/react/blob/main/packages/react-cache/src/ReactCacheOld.js // // This cache is simpler than react-cache in that: // 1. Individual items don't need to be invalidated. From 106f652166bb2e23ba55794cacc778e2d64a521d Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Tue, 13 Feb 2024 13:26:37 -0800 Subject: [PATCH 6/7] https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png --- fixtures/dom/src/components/fixtures/suspense/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fixtures/dom/src/components/fixtures/suspense/index.js b/fixtures/dom/src/components/fixtures/suspense/index.js index ce4c64f30e8..552f9ba23ad 100644 --- a/fixtures/dom/src/components/fixtures/suspense/index.js +++ b/fixtures/dom/src/components/fixtures/suspense/index.js @@ -213,7 +213,7 @@ class TextInputFixtures extends React.Component { - + React is cool From 2a822b269f74b5ebeabc7c830b4c38278b34b35a Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Tue, 27 Feb 2024 20:13:22 -0800 Subject: [PATCH 7/7] https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-core-concepts --- packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js | 2 +- packages/react-dom-bindings/src/shared/isCustomElement.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js index 54b9c14da58..a66bd99a9b3 100644 --- a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js +++ b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js @@ -3710,7 +3710,7 @@ export function pushStartInstance( return pushSelfClosing(target, props, type); } // These are reserved SVG and MathML elements, that are never custom elements. - // https://www.w3.org/TR/custom-elements/ + // https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-core-concepts case 'annotation-xml': case 'color-profile': case 'font-face': diff --git a/packages/react-dom-bindings/src/shared/isCustomElement.js b/packages/react-dom-bindings/src/shared/isCustomElement.js index 32318d7106f..c5465010407 100644 --- a/packages/react-dom-bindings/src/shared/isCustomElement.js +++ b/packages/react-dom-bindings/src/shared/isCustomElement.js @@ -15,7 +15,7 @@ function isCustomElement(tagName: string, props: Object): boolean { // These are reserved SVG and MathML elements. // We don't mind this list too much because we expect it to never grow. // The alternative is to track the namespace in a few places which is convoluted. - // https://www.w3.org/TR/custom-elements/ + // https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-core-concepts case 'annotation-xml': case 'color-profile': case 'font-face':