[Flight][Fizz] ping work within current task #28894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fizz and Flight both currently have a work schedule that enqueues tasks for retrying in a new macrotask. however it means that any given render will be split across multiple tasks even if any thenables that suspend are available within a microtask. This PR updates the ping mechanism for both renderers to schedule retry work on the microtask queue. As we've run into many times in React this is another instance where being able to schedule a microtask to run at the end of the queue would be ideal since we can optimize flushing better.
facebook-github-bot
added
CLA Signed
React Core Team
Jesus-Rojas
reviewed
Apr 23, 2024
| @@ -589,6 +589,7 @@ describe('ReactDOMFizzServerNode', () => { | |||
| if (!hasLoaded) { | |||
| throw promise; | |||
| } | |||
| console.log('rendering'); | |||
There was a problem hiding this comment.
Remove is unnecessary
Suggested change
| console.log('rendering'); | |
| console.log('rendering'); |
| @@ -38,7 +38,7 @@ describe('ReactDOMFizzServerNode', () => { | |||
| writable.on('finish', () => { | |||
| resolve(); | |||
| }); | |||
| writable.on('error', () => { | |||
| writable.on('error', pl => { | |||
There was a problem hiding this comment.
Param not used
Suggested change
| writable.on('error', pl => { | |
| writable.on('error', () => { |
sebmarkbage
requested changes
Apr 23, 2024
There was a problem hiding this comment.
This is problematic because there can be many macro tasks already scheduled on the queue from the I/O threads. The goal of the macro task is to exhaust as many of those as possible to be able to render through as much as possible.
This was more efficient when we were able to synchronously render through things that had already loaded in RSC. We still can do that for instrumented promises such as those coming from a Flight stream. I.e. most Fizz work. But ideally we could also do it with more preloads and such with Flight too.
|
closing in favor of #28907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fizz and Flight both currently have a work schedule that enqueues tasks for retrying in a new macrotask. however it means that any given render will be split across multiple tasks even if any thenables that suspend are available within a microtask. This PR updates the ping mechanism for both renderers to schedule retry work on the microtask queue.
As we've run into many times in React this is another instance where being able to schedule a microtask to run at the end of the queue would be ideal since we can optimize flushing better.