-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for all SVG elements #2893
Conversation
This takes the list of SVG elements from the W3 specification (http://www.w3.org/TR/SVG/eltindex.html) and adds support for all of them. In addition, added support for additional SVG attributes.
For reference, here's the
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Worth noting that, unless I comment out the attributes listed below in
|
+1 |
1 similar comment
+1 |
I wonder which parts of this are relevant after we started passing all SVG attributes through in #5714. |
This diff is over a year old, has merge conflicts, last comment was over a month ago, #5714 merged over a month ago. If there is anything actionable, we can open a new issue/PR. |
This takes the list of SVG elements from the W3 specification
(http://www.w3.org/TR/SVG/eltindex.html) and adds support for all of
them.
In addition, added support for additional SVG attributes.
Note: some of this work is based on @zpao's existing branch. Also, the commit applies cleanly on top of the 0.12-stable branch, if anyone is interested.