Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for all SVG elements #2893

Closed
wants to merge 1 commit into from
Closed

Implement support for all SVG elements #2893

wants to merge 1 commit into from

Conversation

andrew-d
Copy link

This takes the list of SVG elements from the W3 specification
(http://www.w3.org/TR/SVG/eltindex.html) and adds support for all of
them.

In addition, added support for additional SVG attributes.

Note: some of this work is based on @zpao's existing branch. Also, the commit applies cleanly on top of the 0.12-stable branch, if anyone is interested.

This takes the list of SVG elements from the W3 specification
(http://www.w3.org/TR/SVG/eltindex.html) and adds support for all of
them.

In addition, added support for additional SVG attributes.
@andrew-d
Copy link
Author

For reference, here's the build/ directory after running grunt clean build (to see the built size):

drwxr-xr-x   12 andrew  andrew     408 Jan 21 14:01 .
drwxr-xr-x   39 andrew  andrew    1326 Jan 21 13:59 ..
-rw-r--r--    1 andrew  andrew  475037 Jan 21 14:00 JSXTransformer.js
drwxr-xr-x  172 andrew  andrew    5848 Jan 21 14:00 modules
drwxr-xr-x    8 andrew  andrew     272 Jan 21 14:01 npm-react
drwxr-xr-x    8 andrew  andrew     272 Jan 21 14:01 npm-react-tools
-rw-r--r--    1 andrew  andrew  270284 Jan 21 14:01 react-tools.tgz
-rw-r--r--    1 andrew  andrew  654376 Jan 21 14:00 react-with-addons.js
-rw-r--r--    1 andrew  andrew  136610 Jan 21 14:01 react-with-addons.min.js
-rw-r--r--    1 andrew  andrew  595499 Jan 21 14:00 react.js
-rw-r--r--    1 andrew  andrew  126579 Jan 21 14:00 react.min.js
-rw-r--r--    1 andrew  andrew  601885 Jan 21 14:01 react.tgz

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andrew-d
Copy link
Author

Worth noting that, unless I comment out the attributes listed below in SVGDOMPropertyConfig.js, this error is triggered. It appears that this is since they conflict with the HTML attributes in HTMLDOMPropertyConfig.js. I'm not as familiar with the internals of React as I could be, so is simply removing the below attributes the appropriate way of handling this?

  • class
  • height
  • lang
  • method
  • title
  • type
  • width

@eliseumds
Copy link

+1

1 similar comment
@shaunbent
Copy link

+1

@gaearon
Copy link
Collaborator

gaearon commented Dec 25, 2015

I wonder which parts of this are relevant after we started passing all SVG attributes through in #5714.

@jimfb
Copy link
Contributor

jimfb commented Feb 3, 2016

This diff is over a year old, has merge conflicts, last comment was over a month ago, #5714 merged over a month ago. If there is anything actionable, we can open a new issue/PR.

@jimfb jimfb closed this Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants