[compiler][repro] False positives for ValidatePreserveMemo #30629
Conversation
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
| * of its scope (but after its mutable range ends). | ||
| */ | ||
|
|
||
| function useFoo(a, b) { |
There was a problem hiding this comment.
This is the only false positive not fixed by #30630 and unrelated to #30603. Included since it shows a use-case for an identifier's original mutable range (instead of the currently used scope range).
Currently, forget (incorrectly) infers that x is potentially mutated after StartMemoize deps=[x, ...]
| useIdentity(2); | ||
| mutate(x); | ||
|
|
||
| return useCallback(() => [x, []], [x]); |
There was a problem hiding this comment.
This is a false positive because the input wasn't memoized in source, right? Just making sure i'm interpreting this the same way you are.
There was a problem hiding this comment.
Yep exactly! I added this fixture to show changes from #30630
| * We currently bail out because `a` has a scope and is not transitively memoized | ||
| * (as its scope is pruned due to a hook call) |
There was a problem hiding this comment.
Interesting - looks like we are grouping the argument destructuring into a scope? that seems wrong, a and b aren't mutable so they shouldn't be getting added into any scopes.
There was a problem hiding this comment.
My understanding is that this is because x is a context variable, and since our understanding of mutable context variables is imprecise, x and all potential aliases get marked as mutable. I might be incorrect though -- can look into this more
ghstack-source-id: 7fa94fea867371f3d77737dad80a321094f10600 Pull Request resolved: #30629
Stack from ghstack (oldest at bottom):
Found when syncing changes from #30603 to meta codebase, see fixture comments for explanations