[compiler][ez] Add types for Math.min, recursive global #30641
Merged
+62
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
josephsavona
approved these changes
Aug 8, 2024
kassens
approved these changes
Aug 8, 2024
| DEFAULT_GLOBALS.set( | ||
| 'globalThis', | ||
| addObject(DEFAULT_SHAPES, 'globalThis', TYPED_GLOBALS), | ||
| ); | ||
| DEFAULT_GLOBALS.set( | ||
| 'global', |
There was a problem hiding this comment.
I debated on adding window but figured we should leave it out for now. I wonder if we want to handle window and document separately as people often use these for DOM-manipulation (global mutable state)
| @@ -136,6 +136,17 @@ const TYPED_GLOBALS: Array<[string, BuiltInType]> = [ | |||
| returnValueKind: ValueKind.Primitive, | |||
| }), | |||
| ], | |||
| [ | |||
| 'min', | |||
There was a problem hiding this comment.
whole bunch more Math.* stuff missing.
There was a problem hiding this comment.
Makes sense, added min as Math.min and Math.max differences surprised me a few times. Will go ahead and add a few others
[ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Aug 9, 2024
ghstack-source-id: 9940b8f96eec3fb2b411af8a7c92d93aae6da85e Pull Request resolved: #30641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):