Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable lazy context propagation #30935

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Enable lazy context propagation #30935

merged 1 commit into from
Sep 12, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Last I heard this was great so not sure there are any more blockers to just include it in 19?

@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 5:53pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 10, 2024
@react-sizebot
Copy link

Comparing: 66cf2cf...e2552bc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.43% 505.22 kB 507.40 kB +0.50% 90.29 kB 90.75 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.56 kB 512.56 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 600.88 kB 600.88 kB = 106.29 kB 106.29 kB
facebook-www/ReactDOM-prod.modern.js = 577.17 kB 577.17 kB = 102.43 kB 102.43 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-art/cjs/react-art.production.js +0.73% 295.86 kB 298.01 kB +0.83% 50.82 kB 51.24 kB
oss-stable-semver/react-art/cjs/react-art.production.js +0.73% 295.86 kB 298.01 kB +0.83% 50.82 kB 51.24 kB
oss-stable/react-art/cjs/react-art.production.js +0.73% 295.92 kB 298.07 kB +0.83% 50.84 kB 51.26 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.production.js +0.64% 380.81 kB 383.24 kB +0.71% 62.41 kB 62.85 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js +0.64% 380.81 kB 383.24 kB +0.71% 62.41 kB 62.85 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js +0.64% 380.84 kB 383.27 kB +0.71% 62.42 kB 62.87 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.profiling.js +0.60% 408.64 kB 411.07 kB +0.71% 66.48 kB 66.96 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js +0.60% 408.64 kB 411.07 kB +0.71% 66.48 kB 66.96 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js +0.60% 408.66 kB 411.10 kB +0.71% 66.50 kB 66.98 kB
oss-stable-rc/react-art/cjs/react-art.development.js +0.47% 551.16 kB 553.76 kB +0.43% 89.42 kB 89.80 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.47% 551.16 kB 553.76 kB +0.43% 89.42 kB 89.80 kB
oss-stable/react-art/cjs/react-art.development.js +0.47% 551.22 kB 553.82 kB +0.43% 89.44 kB 89.82 kB
oss-stable-rc/react-dom/cjs/react-dom-client.production.js +0.43% 505.12 kB 507.29 kB +0.51% 90.27 kB 90.73 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js +0.43% 505.12 kB 507.29 kB +0.51% 90.27 kB 90.73 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.43% 505.22 kB 507.40 kB +0.50% 90.29 kB 90.75 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.development.js +0.42% 633.54 kB 636.22 kB +0.41% 102.00 kB 102.42 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.42% 633.54 kB 636.22 kB +0.41% 102.00 kB 102.42 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.42% 633.56 kB 636.25 kB +0.42% 102.02 kB 102.44 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.profiling.js +0.41% 537.41 kB 539.59 kB +0.49% 95.47 kB 95.94 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js +0.41% 537.41 kB 539.59 kB +0.49% 95.47 kB 95.94 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js +0.41% 537.51 kB 539.69 kB +0.49% 95.49 kB 95.96 kB
oss-stable-rc/react-dom/cjs/react-dom-client.development.js +0.28% 936.06 kB 938.67 kB +0.32% 158.49 kB 158.99 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js +0.28% 936.06 kB 938.67 kB +0.32% 158.49 kB 158.99 kB
oss-stable/react-dom/cjs/react-dom-client.development.js +0.28% 936.17 kB 938.77 kB +0.32% 158.51 kB 159.01 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.development.js +0.27% 952.50 kB 955.11 kB +0.31% 161.32 kB 161.82 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js +0.27% 952.50 kB 955.11 kB +0.31% 161.32 kB 161.82 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js +0.27% 952.61 kB 955.21 kB +0.31% 161.35 kB 161.85 kB

Generated by 🚫 dangerJS against 79fea8c

@josephsavona
Copy link
Contributor

I think @jackpope is still investigating this, Jack can you add thoughts here?

@jackpope
Copy link
Contributor

Yes the results were good and we can move forward with this.

In terms of timing, we had discussed holding off on the change until after 19 stable just to prevent additional changes from the release out of an abundance of caution. But at this point there's no evidence of bugs or regressions.

We have also discussed ways to improve propagation performance when React.memo boundaries are hit by combining the eager propagation fallback pass and the render pass into a single lazy render pass that only checks on changed context values. But this could be an additional optimization we look into and doesn't need to block this improvement.

@sebmarkbage sebmarkbage merged commit 89b4457 into facebook:main Sep 12, 2024
184 checks passed
@vercel-release-bot vercel-release-bot mentioned this pull request Sep 13, 2024
Merged
@jackpope jackpope mentioned this pull request Sep 26, 2024
Merged
jackpope added a commit that referenced this pull request Sep 26, 2024
@jackpope
Turn on lazy context propagation for RN and RTR (#31076)
60b1420 
Following #30935 let's turn this
on across the board so we can clean up experiments in RN.
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@jackpope
Turn on lazy context propagation for RN and RTR (#31076)
b2fb6f5 
Following #30935 let's turn this
on across the board so we can clean up experiments in RN.

DiffTrain build for [60b1420](60b1420)
@ztanner ztanner mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpope jackpope jackpope approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebmarkbage @react-sizebot @josephsavona @jackpope @facebook-github-bot