Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call cleanup of insertion effects when hidden #30954

Merged
merged 7 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. Call cleanup of insertion effects when hidden

    Insertion effects do not unmount when a subtree goes offscreen, this means we still have to traverse the subtree in that case.
    
    Likely also fixes facebook#26670
    kassens committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    91bf47c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce11376 View commit details
    Browse the repository at this point in the history
  3. fix lint

    rickhanlonii committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a8a5809 View commit details
    Browse the repository at this point in the history
  4. fix comment

    rickhanlonii committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    87dfb87 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86ebb9f View commit details
    Browse the repository at this point in the history
  6. fix dev only tests

    rickhanlonii committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2d09e53 View commit details
    Browse the repository at this point in the history
  7. ass assertion back

    rickhanlonii committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    32fb3eb View commit details
    Browse the repository at this point in the history