Skip to content

Conversation

@rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Mar 3, 2025

Based off PR: #32499

There's a comment in the code added in this commit that we should replace LegacyHidden with an Activity mode:

// TODO: Delete in LegacyHidden. It's an unstable API only used in the
// www build. As a migration step, we could add a special prop to Offscreen
// that simulates the old behavior (no hiding, no change to effects).

This PR is an example of what that could look like, but it also exposes how difficult it is in the current model to add different modes with different behaviors. We could merge this, get on this version, and then iterate and improve.

Or we could just use this as an example to figure out the right model and layering.

Note: this kinda just ignores the view transition stuff for the legacy modes.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 3, 2025
@rickhanlonii rickhanlonii requested review from acdlite and sebmarkbage and removed request for sebmarkbage March 3, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants