From d61733bcf74fac89f077b3c1b186bea3269de410 Mon Sep 17 00:00:00 2001 From: Jan Kassens Date: Mon, 23 Jun 2025 15:14:01 -0400 Subject: [PATCH] rename ReactFiberContext to ReactFiberLegacyContext It wasn't immediately obvious to me, that all the exports here are related to legacy context, so renaming for clarity. Modern context lives in `ReactFiberNewContext` which we could probably also raname in a separate step to just Context. --- packages/react-reconciler/src/ReactFiberBeginWork.js | 2 +- packages/react-reconciler/src/ReactFiberClassComponent.js | 4 ++-- packages/react-reconciler/src/ReactFiberCompleteWork.js | 2 +- packages/react-reconciler/src/ReactFiberHotReloading.js | 2 +- .../src/{ReactFiberContext.js => ReactFiberLegacyContext.js} | 0 packages/react-reconciler/src/ReactFiberReconciler.js | 2 +- packages/react-reconciler/src/ReactFiberUnwindWork.js | 2 +- packages/react-reconciler/src/ReactFiberWorkLoop.js | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) rename packages/react-reconciler/src/{ReactFiberContext.js => ReactFiberLegacyContext.js} (100%) diff --git a/packages/react-reconciler/src/ReactFiberBeginWork.js b/packages/react-reconciler/src/ReactFiberBeginWork.js index 10b10a74b94e6..c195e840e6eb1 100644 --- a/packages/react-reconciler/src/ReactFiberBeginWork.js +++ b/packages/react-reconciler/src/ReactFiberBeginWork.js @@ -236,7 +236,7 @@ import { isContextProvider as isLegacyContextProvider, pushTopLevelContextObject, invalidateContextProvider, -} from './ReactFiberContext'; +} from './ReactFiberLegacyContext'; import { getIsHydrating, enterHydrationState, diff --git a/packages/react-reconciler/src/ReactFiberClassComponent.js b/packages/react-reconciler/src/ReactFiberClassComponent.js index 137e22cb12c3e..7076c678833dc 100644 --- a/packages/react-reconciler/src/ReactFiberClassComponent.js +++ b/packages/react-reconciler/src/ReactFiberClassComponent.js @@ -53,7 +53,7 @@ import { getUnmaskedContext, hasContextChanged, emptyContextObject, -} from './ReactFiberContext'; +} from './ReactFiberLegacyContext'; import {readContext, checkIfContextChanged} from './ReactFiberNewContext'; import {requestUpdateLane, scheduleUpdateOnFiber} from './ReactFiberWorkLoop'; import { @@ -695,7 +695,7 @@ function constructClassInstance( } // Cache unmasked context so we can avoid recreating masked context unless necessary. - // ReactFiberContext usually updates this cache but can't for newly-created instances. + // ReactFiberLegacyContext usually updates this cache but can't for newly-created instances. if (isLegacyContextConsumer) { cacheContext(workInProgress, unmaskedContext, context); } diff --git a/packages/react-reconciler/src/ReactFiberCompleteWork.js b/packages/react-reconciler/src/ReactFiberCompleteWork.js index 1e6ddd75955cd..645eaeb50a146 100644 --- a/packages/react-reconciler/src/ReactFiberCompleteWork.js +++ b/packages/react-reconciler/src/ReactFiberCompleteWork.js @@ -150,7 +150,7 @@ import { isContextProvider as isLegacyContextProvider, popContext as popLegacyContext, popTopLevelContextObject as popTopLevelLegacyContextObject, -} from './ReactFiberContext'; +} from './ReactFiberLegacyContext'; import {popProvider} from './ReactFiberNewContext'; import { prepareToHydrateHostInstance, diff --git a/packages/react-reconciler/src/ReactFiberHotReloading.js b/packages/react-reconciler/src/ReactFiberHotReloading.js index e1d33f07dca27..3bf8e98d86a00 100644 --- a/packages/react-reconciler/src/ReactFiberHotReloading.js +++ b/packages/react-reconciler/src/ReactFiberHotReloading.js @@ -20,7 +20,7 @@ import { } from './ReactFiberWorkLoop'; import {enqueueConcurrentRenderForLane} from './ReactFiberConcurrentUpdates'; import {updateContainerSync} from './ReactFiberReconciler'; -import {emptyContextObject} from './ReactFiberContext'; +import {emptyContextObject} from './ReactFiberLegacyContext'; import {SyncLane} from './ReactFiberLane'; import { ClassComponent, diff --git a/packages/react-reconciler/src/ReactFiberContext.js b/packages/react-reconciler/src/ReactFiberLegacyContext.js similarity index 100% rename from packages/react-reconciler/src/ReactFiberContext.js rename to packages/react-reconciler/src/ReactFiberLegacyContext.js diff --git a/packages/react-reconciler/src/ReactFiberReconciler.js b/packages/react-reconciler/src/ReactFiberReconciler.js index ab7b1fcdd11e9..778518116ff2a 100644 --- a/packages/react-reconciler/src/ReactFiberReconciler.js +++ b/packages/react-reconciler/src/ReactFiberReconciler.js @@ -57,7 +57,7 @@ import { processChildContext, emptyContextObject, isContextProvider as isLegacyContextProvider, -} from './ReactFiberContext'; +} from './ReactFiberLegacyContext'; import {createFiberRoot} from './ReactFiberRoot'; import {isRootDehydrated} from './ReactFiberShellHydration'; import { diff --git a/packages/react-reconciler/src/ReactFiberUnwindWork.js b/packages/react-reconciler/src/ReactFiberUnwindWork.js index 6de76ee2037c8..efe08a43ac713 100644 --- a/packages/react-reconciler/src/ReactFiberUnwindWork.js +++ b/packages/react-reconciler/src/ReactFiberUnwindWork.js @@ -49,7 +49,7 @@ import { isContextProvider as isLegacyContextProvider, popContext as popLegacyContext, popTopLevelContextObject as popTopLevelLegacyContextObject, -} from './ReactFiberContext'; +} from './ReactFiberLegacyContext'; import {popProvider} from './ReactFiberNewContext'; import {popCacheProvider} from './ReactFiberCacheComponent'; import {transferActualDuration} from './ReactProfilerTimer'; diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.js b/packages/react-reconciler/src/ReactFiberWorkLoop.js index 813633656eed7..a8b5dfadeb736 100644 --- a/packages/react-reconciler/src/ReactFiberWorkLoop.js +++ b/packages/react-reconciler/src/ReactFiberWorkLoop.js @@ -357,7 +357,7 @@ import { flushSyncWorkOnLegacyRootsOnly, requestTransitionLane, } from './ReactFiberRootScheduler'; -import {getMaskedContext, getUnmaskedContext} from './ReactFiberContext'; +import {getMaskedContext, getUnmaskedContext} from './ReactFiberLegacyContext'; import {logUncaughtError} from './ReactFiberErrorLogger'; import { deleteScheduledGesture,