[DevTools] Add regression test for custom hook named "useState" crash #34213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression test for issue #20613 where DevTools crashes when inspecting components with custom hooks named "useState". This has been a known issue since 2021 affecting libraries like Hookstate that export custom hooks with this naming pattern.
How did you test this change?
Added test case to
packages/react-devtools-shared/src/__tests__/inspectedElement-test.jsthat creates a custom hook function nameduseState, uses both the custom hook and React's built-inuseState, and verifies DevTools can inspect the component without throwing.Ran
yarn test-build-devtoolsto verify the test passes and all existing DevTools tests continue to work.