-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startOffset to supported SVG Attributes #5210
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This will "just work" after #5714. |
Verified that |
Hey @gaearon , thanks for all the awesome work improving React's handling of SVG's. I'm running into an issue where it doesn't appear my startOffset is making it through to the dom: Here's my JSX element with a startOffset attribute: <text x='0' y='0'>
<textPath xlinkHref={`#${id}`} startOffset={"50%"}>
{label}
</textPath>
</text> And here's a snapshot of the DOM: The xlink:href seems to make it through, but the startOffset doesn't. I'm using "react": "^0.14.3". Any ideas as to what might be going wrong? Thanks! |
This is fixed in master, but that master refers to v15 release. Cheers. |
Good to hear, thanks very much! Until then your:
trick is working well :) |
It's really handy for axis labels in pie/radar/etc charts.