Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable coverage on Travis #6712

Merged
merged 1 commit into from
May 6, 2016
Merged

Disable coverage on Travis #6712

merged 1 commit into from
May 6, 2016

Conversation

sophiebits
Copy link
Collaborator

cc @zpao

@zpao
Copy link
Member

zpao commented May 5, 2016

It doesn't look like it worked… but do whatever it takes

@ghost
Copy link

ghost commented May 6, 2016

@spicyj updated the pull request.

@gaearon
Copy link
Collaborator

gaearon commented May 6, 2016

It used to work 😞 What happened?

@sophiebits
Copy link
Collaborator Author

sophiebits commented May 6, 2016

¯_(ツ)_/¯ want to dig into it?

@sophiebits sophiebits merged commit 82ab58e into facebook:master May 6, 2016
@keyz
Copy link
Contributor

keyz commented May 6, 2016

Last time I checked, the ./coverage folder contains nothing after running grunt jest:coverage. But jest --coverage works. Could it be a grunt script related issue? It might be related to jestjs/jest#433

@keyz
Copy link
Contributor

keyz commented May 6, 2016

Looking at travis logs, it seems that the coverage stopped working after #6620.
If I remove '--runInBand' from our grunt task then it generates coverage correctly. Am I on the right path @zpao @cpojer? :)

@sophiebits
Copy link
Collaborator Author

That sounds believable. I think not using runInBand was making the tests flakier. Maybe because of the extra memory overhead? Not sure. So the issue is that jest might not support coverage with runInBand properly. I haven't looked into it at all, but that might not be too hard to fix.

@keyz
Copy link
Contributor

keyz commented May 6, 2016

Yeah, Jest doesn't generate coverage when used with runInBand.

@cpojer
Copy link
Contributor

cpojer commented May 9, 2016

That is weird and seems like a bug in Jest. It is probably a silly thing that's easy to fix.

@zpao zpao added this to the 15-next milestone Jun 1, 2016
@zpao
Copy link
Member

zpao commented Jun 1, 2016

Going to bring this over to 15-stable. We already don't run coverage there but want to try to keep these in sync.

zpao pushed a commit to zpao/react that referenced this pull request Jun 8, 2016
zpao pushed a commit that referenced this pull request Jun 14, 2016
(cherry picked from commit 82ab58e)
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants