-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable coverage on Travis #6712
Conversation
It doesn't look like it worked… but do whatever it takes |
@spicyj updated the pull request. |
It used to work 😞 What happened? |
¯_(ツ)_/¯ want to dig into it? |
Last time I checked, the |
Looking at travis logs, it seems that the coverage stopped working after #6620. |
That sounds believable. I think not using runInBand was making the tests flakier. Maybe because of the extra memory overhead? Not sure. So the issue is that jest might not support coverage with runInBand properly. I haven't looked into it at all, but that might not be too hard to fix. |
Yeah, Jest doesn't generate coverage when used with runInBand. |
That is weird and seems like a bug in Jest. It is probably a silly thing that's easy to fix. |
Going to bring this over to 15-stable. We already don't run coverage there but want to try to keep these in sync. |
(cherry picked from commit 82ab58e)
(cherry picked from commit 82ab58e)
cc @zpao