Fix #6153: Warning for PropTypes with the wrong case. #6935
Conversation
| @@ -114,6 +115,11 @@ function createChainableTypeChecker(validate) { | |||
| ) { | |||
| componentName = componentName || ANONYMOUS; | |||
| propFullName = propFullName || propName; | |||
| if (__DEV__) { | |||
There was a problem hiding this comment.
Is this check necessary? I'm pretty sure that prop types are only validated in __DEV__ anyways so this would only be executed in the __DEV__ code path anyways.
|
@wali-s updated the pull request. |
Re-based code from facebook#6255
wali-s
force-pushed
the
warn-for-miscapitalized-propname
branch
from
4b9cb0b
to
05779a9
Compare
|
@wali-s updated the pull request. |
|
If you rebase someone else’s PR, I think it’s best to first comment on that PR and offer help. It was the author’s first PR in React repo, and they were waiting for the further review. I think they might be surprised somebody else rebased their PR, and they no longer get an entry in “contributed to” 😉 . |
|
I left a few comments in #6255 which is the original PR. I think the approach itself might be problematic so let’s discuss there first. If the author doesn’t respond we can resurrect this PR but it’s best to give the original author a chance to handle this first. Thank you for the effort though! |
Re-based code from #6255
The warning outputting twice issue in that PR has since been fixed in react itself.
The cache that he added has been removed as it would hit a lot of false positives (multiple components using the same proptypes).