Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword invariant message about empty tags (fixes #7065) #7066

Merged
merged 5 commits into from
Jun 27, 2016

Conversation

starkch
Copy link
Contributor

@starkch starkch commented Jun 17, 2016

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (grunt test).
  5. Make sure your code lints (grunt lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

@ghost
Copy link

ghost commented Jun 17, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost
Copy link

ghost commented Jun 22, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Jun 22, 2016
@starkch
Copy link
Contributor Author

starkch commented Jun 23, 2016

Hi, I updated the tests so they all pass with the message change that was made.
Thanks.

@gaearon
Copy link
Collaborator

gaearon commented Jun 26, 2016

Let’s change to must neither ... nor ... for clarity.

@gaearon gaearon changed the title addresses issue #7065 Reword invariant message about empty tags (fixes #7065) Jun 26, 2016
@gaearon gaearon added this to the 15-next milestone Jun 27, 2016
@gaearon gaearon merged commit f949125 into facebook:master Jun 27, 2016
@starkch starkch deleted the issue-7065 branch June 28, 2016 13:58
zpao pushed a commit that referenced this pull request Jul 8, 2016
* addresses issue #7065

* fix test to use new message

* fix string in tests

* fix test string

* Update error message and tests

(cherry picked from commit f949125)
@zpao zpao modified the milestones: 15-next, 15.2.1 Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants