Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a proper no-op warning for async state changes on server #7127

Merged
merged 1 commit into from
Jul 4, 2016
Merged

Trigger a proper no-op warning for async state changes on server #7127

merged 1 commit into from
Jul 4, 2016

Commits on Jun 30, 2016

  1. Trigger a proper no-op warning for async state changes on server

    This commit fixes #5473: ReactDOMServer.renderToString: presence of onClick
    handler causes errors on async update
    
    This commit performs the following changes:
    
    - Adds a getUpdateQueue method to ReactServerRenderingTransaction,
      ReactReconcileTransaction, ReactNativeReconcileTransaction and
      ReactTestReconcileTransaction
    - Make the ReactCompositeComponent call this getUpdateQueue instead of using
      ReactUpdateQueue that was unwanted at certain moments on server
    - On ReactServerRenderingTransaction, dispatch ReactUpdateQueue's methods
      while rendering and warning methods afterwards. This is done through the new
      ReactServerUpdateQueue class
    - Added a series of tests that mimics the case presented in #5473 with setState,
      forceUpdate and replaceState
    - Add flow typechecking on concerned files
    rricard committed Jun 30, 2016
    Configuration menu
    Copy the full SHA
    8bd70b7 View commit details
    Browse the repository at this point in the history