Fix memory leak in ReactChildrenMutationWarningHook for SSR #7410
+39
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2016 14:38
and get element from `ReactComponentTreeHook` instead of keeping an internal store
ghost
added
keyz
changed the title
|
Awesome job! Will there be a patch release for this fix? |
| ); | ||
| }); | ||
|
|
||
| it('should warn when children are mutated', function() { |
There was a problem hiding this comment.
Nit: not very clear why there are two tests, and how they are different (right not the name only differences is starting with "should")
|
This will probably go in 15.3.1. @franjohn21 Can you build from master and verify this fixes it? |
|
This looks right but I'd appreciate if you could verify this indeed fixes the leak. |
|
@keyanzhang @gaearon I can confirm I am seeing the memory leak removed with this change. Thanks for the quick turnaround time! |
|
I’m going to get this in because it’s better than status quo and I also need it for DEV perf regression I’m tackling right now. |
| }, | ||
| onComponentHasMounted(debugID) { | ||
| handleElement(debugID, elements[debugID]); | ||
| delete elements[debugID]; |
There was a problem hiding this comment.
For future reference: delete is super slow on V8 with many items when using numeric keys. Even toString() is not enough—you have to prepend them with something like .
gaearon
added a commit
that referenced
this pull request
Aug 11, 2016
* Remove onBeforeMountComponent hook event It is unnecessary. We now pass the element as part of onInstantiateComponent, and it can't change before mounting. * Remove onComponentHasMounted hook event It is unused after #7410. * Replace on(Begin|End)ReconcilerTimer hook events We already have onBeforeUpdateComponent. Let's just have on(Before?)(Mount|Update|Unmount)Component and stick with them. This removes double event dispatches in some hot spots. * Remove onComponentHasUpdated hook The tests still pass so presumably it was not necessary. * Add missing __DEV__ to TestUtils code * Replace on(InstantiateComponent|SetParent) with onBeforeMountComponent This lets us further consolidate hooks. The parent ID is now passed as an argument to onBeforeMountComponent() with the element. * Remove onMountRootComponent hook event It is unnecessary now that we pass the parent ID to onBeforeMountComponent. * Use parentDebugID = 0 both for roots and production This removes some awkward branching.
zpao
pushed a commit
that referenced
this pull request
Aug 12, 2016
* corrected ReactChildrenMutationWarningHook's name * changed `onComponentHasMounted` to `onMountComponent` and get element from `ReactComponentTreeHook` instead of keeping an internal store (cherry picked from commit 5514ea3)
zpao
pushed a commit
that referenced
this pull request
Aug 12, 2016
* Remove onBeforeMountComponent hook event It is unnecessary. We now pass the element as part of onInstantiateComponent, and it can't change before mounting. * Remove onComponentHasMounted hook event It is unused after #7410. * Replace on(Begin|End)ReconcilerTimer hook events We already have onBeforeUpdateComponent. Let's just have on(Before?)(Mount|Update|Unmount)Component and stick with them. This removes double event dispatches in some hot spots. * Remove onComponentHasUpdated hook The tests still pass so presumably it was not necessary. * Add missing __DEV__ to TestUtils code * Replace on(InstantiateComponent|SetParent) with onBeforeMountComponent This lets us further consolidate hooks. The parent ID is now passed as an argument to onBeforeMountComponent() with the element. * Remove onMountRootComponent hook event It is unnecessary now that we pass the parent ID to onBeforeMountComponent. * Use parentDebugID = 0 both for roots and production This removes some awkward branching. (cherry picked from commit 0e976e1)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7406. Thanks @franjohn21 for providing such a detailed investigation!
Reviewers: @gaearon @jimfb