-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
double-conversion has installed, but configure error #15
Comments
Is double-conversion linked properly? I had to do:
|
Facing the same issue. force linking it didn't help. |
I should have a fix landing soon -- in the meantime try editing configure.ac to change:
into
That should appease configure. (I hope.) |
@bertmaher that doesn't work either
It seems the mac osx build is broken, even removing that check in double-conversion, glog is complaining. Maybe they added OS X last minute, will wait till they checkin the remaining source. |
I'm not really sure what's going on here. Can you post the output of:
|
Sorry I couldn't help much, but here is the output, seems my sdk is missing?
|
I am compiling redex now in Ubuntu, and everything works there. So I have an alternate :) |
I'm thinking the problem is that "Library search paths" doesn't include /usr/local/lib, which is where homebrew installs things, but I'm not quite sure how to convince clang to add that to the path (it was just there for me after installing Xcode)... will let you know if I come up with anything. |
@bertmaher echo $PATH checking for ceil in -ldouble-conversion... no brew install double-conversion why? |
same problem here |
Can you try deleting the AC_CHECK_LIB([double-conversion], ... ) line from configure.ac? |
@bertmaher Deleting that line now gives the following error: |
Heh, how about if you delete the AC_LIB_CHECK([glog]) line after that? (You'll probably just hit the same error in the folly configure, but humor me) |
after disable double-conversion and glog now ... configure: error: Please install google-gflags library |
@bertmaher checking for main in -lglog... no |
Same output as @xiaomadada @bertmaher :) Deleting them relies ... Seems something missing, getting late here in bay area, maybe will help you tomorrow.
|
same output as @xiaomadada |
@mohamedmansour Most redex dev's mostly use OSX, so it wasn't a late-addition. Can't repro the issue locally after doing a brew update and then running through the brew installs on http://fbredex.com/. @sorab2142 brew list gflags |
@shanenay output of brew list gflags is: |
@sorab2142 g++ -E -x c++ - -v < /dev/null We're thinking it could be an xtools issue. We're running older versions (6.0.1 for me yikes!, and Bert 7.0.1 IIRC). I'm doing some software updates so I can get up to 7.3.0 to see if I can repro it there. |
I had to set this line back inside configure.ac:
in order to reach the compile step. |
@shanenay @sorab2142 as @bertmaher guessed it right, it's the issue with not having
And I fixed that one with |
@shanenay $ g++ -E -x c++ - -v < /dev/null 1 ""1 "" 11 "" 3332 "" 31 "" 11 "" 21 "" 2baiyulindeMac-mini:redex macminiserver$ |
@maniramezan solution worked for me: I also got this error: |
after xcode-select --install finished, attempting to compile now gives the following error:
|
@benoitletondor I added |
@xiaomadada didn't solve for me :( |
Just for the record, here ( Ubuntu ), I had this error fixed after typing
|
same issue here on mac :/ |
Could you please try compiling a test program with double-conversion? E.g.:
If this doesn't build OK with the command line:
then the build environment isn't set up for command line builds anyways, and it's not a redex-specific problem. |
@maniramezan: thanks! I had suspected that was the issue but didn't have a way to test. For those following along, the solution seems to be: I'll leave this issue open for a bit so others can find it. |
Yep |
This is in the README now, thanks everybody who reported it! |
Summary: Pull Request resolved: facebook/SPARTA#15 Following a recent Redex move to C++17. Reviewed By: minjang Differential Revision: D28612765 fbshipit-source-id: 270a45c571b2657589793ea360561bc1b327e837
Summary: Pull Request resolved: facebook/SPARTA#15 Following a recent Redex move to C++17. Reviewed By: minjang Differential Revision: D28612765 fbshipit-source-id: 270a45c571b2657589793ea360561bc1b327e837
➜ redex git:(master) ✗
brew install double-conversion
Warning: double-conversion-1.1.5 already installed
// execute
autoreconf -ivf && ./configure && make && make install
...msg...
configure: error: Please install double-conversion
The text was updated successfully, but these errors were encountered: