Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a submodule for folly #6

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "third-party/folly"]
path = third-party/folly
url = https://github.com/facebook/folly
5 changes: 4 additions & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ AUTOMAKE_OPTIONS = foreign

CXXFLAGS = --std=gnu++11 -O3 -Wall -g

SUBDIRS = third-party/folly/folly

bin_PROGRAMS = redex-all

bin_SCRIPTS = redex
Expand Down Expand Up @@ -44,10 +46,11 @@ includes = \
opt/synth \
opt/unterface \
tools/redex-all \
third-party/folly \
util

redex_all_CPPFLAGS = $(foreach i, $(includes), -I$(top_srcdir)/$i)
redex_all_LDADD = -lboost_filesystem -lboost_system -lpthread
redex_all_LDADD = -lboost_filesystem -lboost_system -lpthread third-party/folly/folly/.libs/libfolly.a

redex_all_SOURCES = \
configparser/keeprules.cc \
Expand Down
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ Mac OS X:
```
brew install boost autoconf automake glog double-conversion
```
You will also need to build and install
[folly](https://github.com/facebook/folly) from source.

Ubuntu 14.04 LTS:
```
Expand All @@ -32,13 +30,12 @@ apt-get install \
libdouble-conversion-dev \
libgoogle-glog-dev
```
You will also need to build and install
[folly](https://github.com/facebook/folly) from source.

### Build and Install

Build ReDex using autoconf and make:
Build ReDex using autoconf and make.
```
git submodule update --init --recursive
autoreconf -ivf && ./configure && make && make install
```

Expand Down
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ AC_INIT([redex], [1.0], [not-valid-yet@fb.com])
AM_INIT_AUTOMAKE(redex, 1.0)
AC_CONFIG_SRCDIR([configparser/config.l])
AC_CONFIG_HEADERS([config.h])
AC_CONFIG_SUBDIRS([third-party/folly/folly])

# Checks for programs.
AC_PROG_CXX
Expand All @@ -24,7 +25,6 @@ AX_BOOST_BASE([1.54.0], [], [AC_MSG_ERROR(
[Please install boost >= 1.54 (including filesystem)])])
AX_BOOST_FILESYSTEM
AX_BOOST_SYSTEM
AC_CHECK_LIB([folly], [main], [], [AC_MSG_ERROR([Please install folly])])
AC_CHECK_LIB([z], [adler32], [], [AC_MSG_ERROR([Please install zlib])])
AC_CHECK_LIB([double-conversion], [main], [], [AC_MSG_ERROR([Please install double-conversion])])
AC_CHECK_LIB([glog], [main], [], [AC_MSG_ERROR([Please install glog])])
Expand Down
1 change: 1 addition & 0 deletions third-party/folly
Submodule folly added at 5f9c9a