Update protection info on recovered logs data #9875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Implement key-value checksums on data recovered from the WAL. Test Plan: TBD Reviewers: Andrew Kryczka Subscribers: Tasks: T112036080 Tags: WAL
Summary: Changes originated in suggestions from ajkr. Test Plan: TBD Reviewers: Andrew Kryczka Subscribers: Tasks: T112036080 Tags: WAL
pdillinger
reviewed
Apr 21, 2022
ajkr
reviewed
Apr 24, 2022
|
Added my own benchmark to description. I think the regression (7.2% on in-memory WAL) should be OK to tolerate without a flag for this feature considering it's crash-recovery only. Let me know if anyone disagrees. |
ajkr
approved these changes
Apr 28, 2022
ajkr
reviewed
Apr 28, 2022
|
@akomurav has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@akomurav has updated the pull request. You must reimport the pull request before landing. |
|
@akomurav has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
akomurav
changed the title
|
@akomurav has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@akomurav has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update protection info on recovered logs data
Test Plan:
TEST_TMPDIR=/dev/shm/100MB_WAL_DB/ ./db_bench -benchmarks=fillrandom -write_buffer_size=1048576000TEST_TMPDIR=/dev/shm/100MB_WAL_DB/ /usr/bin/time ./db_bench -use_existing_db=true -benchmarks=overwrite -write_buffer_size=1048576000 -writes=1 -report_open_timing=trueMean regressed 7.2% (2201.4 -> 2359.9)