Unnecessary clones of types

Reviewed By: blackm00n Differential Revision: D63439789 fbshipit-source-id: 6827d94d8e98ce9e8e709c3321a903be933cfb61
facebook · Sep 26, 2024 · 4c31833 · 4c31833
1 parent 3000af2
commit 4c31833
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/starlark/src/typing/callable_param.rs b/starlark/src/typing/callable_param.rs
@@ -333,7 +333,7 @@ impl ParamSpec {
     }
 
     /// All parameters are required and positional only.
-    pub(crate) fn all_required_pos_only(&self) -> Option<Vec<Ty>> {
+    pub(crate) fn all_required_pos_only(&self) -> Option<Vec<&Ty>> {
         match self.split() {
             ParamSpecSplit {
                 pos_only,
@@ -344,7 +344,7 @@ impl ParamSpec {
             } => pos_only
                 .iter()
                 .map(|p| match p.mode {
-                    ParamMode::PosOnly(ParamIsRequired::Yes) => Some(p.ty.dupe()),
+                    ParamMode::PosOnly(ParamIsRequired::Yes) => Some(&p.ty),
                     _ => None,
                 })
                 .collect(),

diff --git a/starlark/src/typing/oracle/ctx.rs b/starlark/src/typing/oracle/ctx.rs
@@ -855,7 +855,7 @@ impl<'a> TypingOracleCtx<'a> {
 
     fn params_all_pos_only_intersect(
         &self,
-        x: &[Ty],
+        x: &[&Ty],
         y: &ParamSpec,
     ) -> Result<bool, InternalError> {
         match self.validate_args(
@@ -864,7 +864,7 @@ impl<'a> TypingOracleCtx<'a> {
                 pos: x
                     .iter()
                     .map(|ty| Spanned {
-                        node: ty.dupe(),
+                        node: (*ty).dupe(),
                         // TODO(nga): proper span.
                         span: Span::default(),
                     })