Assert all arguments consumed by ParameterSpec::parser callback

Summary: Better alternative to D63165674: just check it unconditionally instead of checking at every call site. It is more expensive, but practically it is nothing, see the test plan.

Reviewed By: JakobDegen

Differential Revision: D63280260

fbshipit-source-id: 19197a228a4e7d1f18904bda6d4fd4dd88a96cd7

starlark/src/eval/runtime/params/parser.rs

@@ -65,6 +65,11 @@ impl<'v, 'a> ParametersParser<'v, 'a> {
         };
         T::unpack_named_param(v, name)
     }
+
+    #[inline]
+    pub(crate) fn is_eof(&self) -> bool {
+        self.0.len() == 0
+    }
 }
 
 #[cfg(test)]

starlark/src/eval/runtime/params/spec.rs

@@ -27,6 +27,7 @@ use starlark_derive::Freeze;
 use starlark_derive::Trace;
 use starlark_map::small_map::SmallMap;
 use starlark_map::Hashed;
+use starlark_syntax::other_error;
 use starlark_syntax::syntax::def::DefParamIndices;
 
 use crate as starlark;
@@ -865,7 +866,14 @@ impl<'v> ParametersSpec<Value<'v>> {
             |slots, eval| {
                 self.collect_inline(&args.0, slots, eval.heap())?;
                 let mut parser = ParametersParser::new(slots);
-                k(&mut parser, eval)
+                let r = k(&mut parser, eval)?;
+                if !parser.is_eof() {
+                    return Err(other_error!(
+                        "Parser for `{}` did not consume all arguments",
+                        self.function_name
+                    ));
+                }
+                Ok(r)
             },
         )
     }